Building with Qt4 ?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Building with Qt4 ?

jbect
Hi all,

When I try building from the tip of default I get :

   CXX libgui/graphics/libgui_graphics___init_qt___la-QtHandlesUtils.lo
libgui/graphics/QtHandlesUtils.cc: In function ‘octave_scalar_map
QtHandles::Utils::makeScrollEventStruct(QWheelEvent*)’:
libgui/graphics/QtHandlesUtils.cc:399:47: error: ‘class QWheelEvent’ has
no member named ‘angleDelta’
                         octave_value (- event->angleDelta().y () / 120));
                                                ^~~~~~~~~~

Is it still supposed to be possible to build with Qt4 ?  (I have Qt 4.8.)

@++
Julien


Reply | Threaded
Open this post in threaded view
|

Re: Building with Qt4 ?

Torsten Lilge
On Sat, 2019-06-01 at 19:06 +0200, Julien Bect wrote:

> Hi all,
>
> When I try building from the tip of default I get :
>
>    CXX libgui/graphics/libgui_graphics___init_qt___la-
> QtHandlesUtils.lo
> libgui/graphics/QtHandlesUtils.cc: In function ‘octave_scalar_map
> QtHandles::Utils::makeScrollEventStruct(QWheelEvent*)’:
> libgui/graphics/QtHandlesUtils.cc:399:47: error: ‘class QWheelEvent’
> has
> no member named ‘angleDelta’
>                          octave_value (- event->angleDelta().y () /
> 120));
>                                                 ^~~~~~~~~~
>
> Is it still supposed to be possible to build with Qt4 ?  (I have Qt
> 4.8.)
>
> @++
> Julien
>

Hi Julien,

This was discussed in thread
http://lists.gnu.org/archive/html/octave-maintainers/2019-03/msg00041.html

Torsten



Reply | Threaded
Open this post in threaded view
|

Re: Building with Qt4 ?

jbect
Le 01/06/2019 à 19:41, Torsten Lilge a écrit :

> On Sat, 2019-06-01 at 19:06 +0200, Julien Bect wrote:
>> Hi all,
>>
>> When I try building from the tip of default I get :
>>
>>     CXX libgui/graphics/libgui_graphics___init_qt___la-
>> QtHandlesUtils.lo
>> libgui/graphics/QtHandlesUtils.cc: In function ‘octave_scalar_map
>> QtHandles::Utils::makeScrollEventStruct(QWheelEvent*)’:
>> libgui/graphics/QtHandlesUtils.cc:399:47: error: ‘class QWheelEvent’
>> has
>> no member named ‘angleDelta’
>>                           octave_value (- event->angleDelta().y () /
>> 120));
>>                                                  ^~~~~~~~~~
>>
>> Is it still supposed to be possible to build with Qt4 ?  (I have Qt
>> 4.8.)
>>
>> @++
>> Julien
>>
> Hi Julien,
>
> This was discussed in thread
> http://lists.gnu.org/archive/html/octave-maintainers/2019-03/msg00041.html
>
> Torsten

Thank you Torsten.

I read the thread but the last email says "If we drop checking for Qt
4..." and "If we come to a consensus on this..." so I don't know what
the actuall conclusion is.

Currently, configure silently accepts my configuration (with Qt4) but
then make fails.

If Qt4 support was actually dropped, I should file a bug report
concerning the build system.  If Qt4 is still supported, I should file a
bug report concerning the above issue with angleDelta.

Which one is it ?

Reply | Threaded
Open this post in threaded view
|

Re: Building with Qt4 ?

Mike Miller-4
On Sat, Jun 01, 2019 at 20:16:02 +0200, Julien Bect wrote:
> I read the thread but the last email says "If we drop checking for Qt 4..."
> and "If we come to a consensus on this..." so I don't know what the actuall
> conclusion is.

There has been no conclusion or decision made beyond that.

> Currently, configure silently accepts my configuration (with Qt4) but then
> make fails.

We have had a couple changes recently on the default branch that created
similar situations, not a new problem.

> If Qt4 support was actually dropped, I should file a bug report concerning
> the build system.  If Qt4 is still supported, I should file a bug report
> concerning the above issue with angleDelta.
>
> Which one is it ?

Given the status quo, the latter makes the most sense.

But as a followup to the previous thread, I did intend to, and still
intend to, change the status quo. I intend to work on a patch to test
exactly what I proposed, namely dropping the Qt 4 modules from configure
and making QOpenGLWidget mandatory for the Qt graphics toolkit.

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Building with Qt4 ?

Pantxo
Mike Miller-4 wrote

> On Sat, Jun 01, 2019 at 20:16:02 +0200, Julien Bect wrote:
>> I read the thread but the last email says "If we drop checking for Qt
>> 4..."
>> and "If we come to a consensus on this..." so I don't know what the
>> actuall
>> conclusion is.
>
> There has been no conclusion or decision made beyond that.
>
>> Currently, configure silently accepts my configuration (with Qt4) but
>> then
>> make fails.
>
> We have had a couple changes recently on the default branch that created
> similar situations, not a new problem.
>
>> If Qt4 support was actually dropped, I should file a bug report
>> concerning
>> the build system.  If Qt4 is still supported, I should file a bug report
>> concerning the above issue with angleDelta.
>>
>> Which one is it ?
>
> Given the status quo, the latter makes the most sense.
>
> But as a followup to the previous thread, I did intend to, and still
> intend to, change the status quo. I intend to work on a patch to test
> exactly what I proposed, namely dropping the Qt 4 modules from configure
> and making QOpenGLWidget mandatory for the Qt graphics toolkit.
>
> --
> mike
>
>
> signature.asc (849 bytes)
> <http://octave.1599824.n4.nabble.com/attachment/4693045/0/signature.asc>

FWIW, as the one who introduced this new issue (and the previous one(s)), I
second Mike's idea to make QOpenGLWidget (or roughly Qt-5.5) mandatory in
Octave 6.

Pantxo



--
Sent from: http://octave.1599824.n4.nabble.com/Octave-Maintainers-f1638794.html

Reply | Threaded
Open this post in threaded view
|

Re: Building with Qt4 ?

John W. Eaton
Administrator
On 6/1/19 6:27 PM, Pantxo wrote:

> FWIW, as the one who introduced this new issue (and the previous one(s)), I
> second Mike's idea to make QOpenGLWidget (or roughly Qt-5.5) mandatory in
> Octave 6.

It would be nice to switch to requiring Qt5 so that we could simplify
some things in the sources.  Until then I think we should still try to
allow building with Qt4 but only if it is reasonably easy to do so.  For
the QWheelEvent::angleDelta issue, I pushed the following change:

   http://hg.savannah.gnu.org/hgweb/octave/rev/274766cae722

jwe