New release of control pkg.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

New release of control pkg.

Doug Stewart-4
I want to make a new release of the control package, and it should be soon, so that the new version will get packaged with the next release of stable, and then the soon to come octave-4.4.0 .

I ave made a local release to myself for testing and found that it installs with default  and stable.


What I am not clear about is how to get the new version on -forge web page.

Olaf, could you explain that part please?

There are lots of warning as the control pkg. is being installed, and I hope to work on these soon. so I see an immediate release of control-3.1.0, so that It can be tested before the next octave release for windows etc. Then some minor releases as I fix all the warnings and add more features.

Suggestions?

Doug

--
DASCertificate for 206392



-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------
Reply | Threaded
Open this post in threaded view
|

Re: New release of control pkg.

Olaf Till-2
On Fri, Feb 16, 2018 at 09:08:32AM -0500, Doug Stewart wrote:

> I want to make a new release of the control package, and it should be soon,
> so that the new version will get packaged with the next release of stable,
> and then the soon to come octave-4.4.0 .
>
> I ave made a local release to myself for testing and found that it installs
> with default  and stable.
>
>
> What I am not clear about is how to get the new version on -forge web page.
>
> Olaf, could you explain that part please?
>
> There are lots of warning as the control pkg. is being installed, and I
> hope to work on these soon. so I see an immediate release of control-3.1.0,
> so that It can be tested before the next octave release for windows etc.
> Then some minor releases as I fix all the warnings and add more features.
I've noted you and Alexander now as the maintainers in the DESCRIPTION
file. Since Alexander has made some additions and fixes recently, we
should wait until he agrees that a new release should be made.

As for the release procedure, this is described at our web-page
(currently dead...). In essence, the package and html tarballs should
be put to the release tracker, noting their md5sums. But note that we
(Oliver or me) recreate the release anyway, so posting the tarballs is
only for double-checking that we release what you intended to be
released. You can leave out the double-check, then it's sufficient to
tell us the changeset id from which the release should be made. Also
note that you should _not_ tag the release changeset, this is done by
the admins.


The rest of this post only refers to the compiler warnings.

Currently, DESCRIPTION says

Depends: octave (>= 3.8.0).

This could probably be changed (?), but IMHO we should at least
support Octave versions as far back as 4.0.0, so this should also be
tested (could be done by an admin).

The warnings for deprecated ::nelem () can probably be simply fixed by
changing to ::numel (), since even Octave 4.0.0 already has ::numel().

The other warnings (with Octave 4.3+) need more work. I could do that
for you, if necessary. Or we could leave the warnings in, or silence
them with a compiler option in src/Makefile. But note that this just
postpones the work until Octave versions higher than 4.4, which
probably won't have the now deprecated symbols anymore, while 4.2
hasn't the respective new symbols.

Olaf

--
public key id EAFE0591, e.g. on x-hkp://pool.sks-keyservers.net


-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: New release of control pkg.

alexander-wilms
> I've noted you and Alexander now as the maintainers in the DESCRIPTION
> file. Since Alexander has made some additions and fixes recently, we
> should wait until he agrees that a new release should be made.

Sure, no objections from me.

Alexander



-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------
Reply | Threaded
Open this post in threaded view
|

Re: New release of control pkg.

Doug Stewart-4
I have a private release for testing.
After installing my release :
I noticed that when I run news control It show more than what is in the news file.
start of news file:
Summary of important user-visible changes for releases of the control package

===============================================================================
control-n.n.n
===============================================================================

 ** New functions:
    acker, dsort, esort

===============================================================================
control-3.0.0   Release Date: 2015-10-30   Release Manager: Lukas Reichlin
===============================================================================


now when I run news control I get:

>> news control
Summary of important user-visible changes for releases of the control package



====================================================
impulse fixes Doug Stewart
====================================================

 ** The Impulse section hes been rewritten, and a new file -- imp_invar.m --
    added. the old system tried to use the "zoh" to get an impulse response
    but that is imposable.

 ** The new file "imp_invar.m" converts a Laplace tranfer function to a
    discrete tranfer function


===============================================================================
control-n.n.n
===============================================================================

 ** New functions:
    acker, dsort, esort

===============================================================================
control-3.0.0   Release Date: 2015-10-30   Release Manager: Lukas Reichlin
===============================================================================


I don't understand where this extra part comes from. There is a typo that needs fixed.





On Fri, Feb 16, 2018 at 6:29 PM, Alexander Wilms <[hidden email]> wrote:
I've noted you and Alexander now as the maintainers in the DESCRIPTION
file. Since Alexander has made some additions and fixes recently, we
should wait until he agrees that a new release should be made.

Sure, no objections from me.

Alexander




--
DASCertificate for 206392



-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------
Reply | Threaded
Open this post in threaded view
|

Re: New release of control pkg.

Doug Stewart-4
In reply to this post by alexander-wilms


On Fri, Feb 16, 2018 at 6:29 PM, Alexander Wilms <[hidden email]> wrote:
I've noted you and Alexander now as the maintainers in the DESCRIPTION
file. Since Alexander has made some additions and fixes recently, we
should wait until he agrees that a new release should be made.

Sure, no objections from me.

Alexander




In the control pkg there is a folder that is named devel.
In this folder it looks like things that Lucus was working on and didn't want to forget.
Some of the files refer to specific bugs, and I check some of then and they are fixed already .

I think I should go through and delete all the the ones that are fixed. 
would you agree?



I also have fixed all the warnings so the it installs in stable with no warnings. 
There are still warnings in default octave, and we can leave these for now.
 The next release is likely stable.

I would like to see a release of control now so that it can be further tested before 
the next release of stable. I did lots of testing and there are some fails that have
 been there for a long time, and I will look at them, but they may take some time
 to figure out what is wrong.

With the fix to Impulse, it is much better than it was.

when the news file gets fixed, then we should do a release in my opinion.

Doug


--
DASCertificate for 206392



-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------
Reply | Threaded
Open this post in threaded view
|

Re: New release of control pkg.

Olaf Till-2
On Fri, Feb 23, 2018 at 02:20:29PM -0500, Doug Stewart wrote:
> In the control pkg there is a folder that is named devel.
> In this folder it looks like things that Lucus was working on and didn't
> want to forget.
> Some of the files refer to specific bugs, and I check some of then and they
> are fixed already .
>
> I think I should go through and delete all the the ones that are fixed.
> would you agree?

Sounds good. Only if there are tests for previous bugs, these should
remain or go into %test sections of corresponding files.

> I also have fixed all the warnings so the it installs in stable with no
> warnings.
> There are still warnings in default octave, and we can leave these for now.
>  The next release is likely stable.
>
> I would like to see a release of control now so that it can be further
> tested before
> the next release of stable. I did lots of testing and there are some fails
> that have
>  been there for a long time, and I will look at them, but they may take
> some time
>  to figure out what is wrong.
>
> With the fix to Impulse, it is much better than it was.
I couldn't figure out which fix to impulse you mean, and if it should
go into NEWS

> when the news file gets fixed, then we should do a release in my opinion.

The NEWS file was ok, the problem you described must have come from
somewhere else (bug in Octave? and/or further NEWS file lying around
somewhere?).

I've pushed a (maybe incomplete) preparation for the new release,
please check if I have written something stupid into NEWS.

Doug, for the future, if a commit addresses a bug report or patch, the
corresponding bug number or patch number should be mentioned in the
header of the commit message.

If you say the change to NEWS is ok (or if you have corrected it) I
can make a release for you if you like.

Olaf

--
public key id EAFE0591, e.g. on x-hkp://pool.sks-keyservers.net


-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: New release of control pkg.

Olaf Till-2
On Sun, Feb 25, 2018 at 07:19:59PM +0100, Olaf Till wrote:
> If you say the change to NEWS is ok (or if you have corrected it) I
> can make a release for you if you like.

ping...

--
public key id EAFE0591, e.g. on x-hkp://pool.sks-keyservers.net


-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: New release of control pkg.

Olaf Till-2
On Sun, Mar 04, 2018 at 01:14:10PM -0500, Doug Stewart wrote:
> On Mar 4, 2018 1:06 PM, "Olaf Till" <[hidden email]> wrote:
>
> > On Sun, Feb 25, 2018 at 07:19:59PM +0100, Olaf Till wrote:
> > > If you say the change to NEWS is ok (or if you have corrected it) I
> > > can make a release for you if you like.
>
> > ping...
>
> I have one more push to do but sf is having difficulty

All I can test seems to work, currently... what difficulties do you
still see?

Olaf

--
public key id EAFE0591, e.g. on x-hkp://pool.sks-keyservers.net


-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------

signature.asc (849 bytes) Download Attachment