Quantcast

Patch for adding features in Settings GUI

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Patch for adding features in Settings GUI

Atul  jangra
Hey maintainers attached is a patch for adding a functionality to the SettingDialog in the GUI of Octave.
It adds two buttons to the bottom of the dialog namely "Discard" and "Save Changes".
Discard : Will discard all the settings made this time and revert to the last configuration .
Save Changes: Will do the default , will save all the changes made.

Hoping for a favorable reply.
--
Atul jangra
Computer Science and Engineering
Indian Institute of Technology ,Delhi


SettingsChange.patch (8K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

Jordi Gutiérrez Hermoso-2
On 16 March 2012 10:49, Atul  jangra <[hidden email]> wrote:
> Hey maintainers attached is a patch for adding a functionality to the
> SettingDialog in the GUI of Octave.

A couple of comments.

Please don't disable code by commenting it out. Just delete it. The hg
history will show the original code if we want to look at it. Having
commented-out code clutters reading the source.

Also please provide a commit message. You can look at some examples in
the hg history:

    http://hg.savannah.gnu.org/hgweb/octave/

We haven't clearly spelled out the guidelines for writing a commit
message anywhere, but they're roughly adapted from the GNU coding
standards:

    http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html

- Jordi G. H.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

John W. Eaton
Administrator
On 16-Mar-2012, Jordi Gutiérrez Hermoso wrote:

| On 16 March 2012 10:49, Atul  jangra <[hidden email]> wrote:
| > Hey maintainers attached is a patch for adding a functionality to the
| > SettingDialog in the GUI of Octave.
|
| A couple of comments.
|
| Please don't disable code by commenting it out. Just delete it. The hg
| history will show the original code if we want to look at it. Having
| commented-out code clutters reading the source.
|
| Also please provide a commit message. You can look at some examples in
| the hg history:
|
|     http://hg.savannah.gnu.org/hgweb/octave/
|
| We haven't clearly spelled out the guidelines for writing a commit
| message anywhere, but they're roughly adapted from the GNU coding
| standards:
|
|     http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html

Also, do we care about using a consistent coding style or not?  I
thought we were (mostly) using the GNU coding conventions in all
Octave code.

jwe
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

Atul  jangra
I am sorry if I have missed out the coding style for Octave. I will update this patch soon.
Please guide me through the process.

2012/3/16 John W. Eaton <[hidden email]>
On 16-Mar-2012, Jordi Gutiérrez Hermoso wrote:

| On 16 March 2012 10:49, Atul  jangra <[hidden email]> wrote:
| > Hey maintainers attached is a patch for adding a functionality to the
| > SettingDialog in the GUI of Octave.
|
| A couple of comments.
|
| Please don't disable code by commenting it out. Just delete it. The hg
| history will show the original code if we want to look at it. Having
| commented-out code clutters reading the source.
|
| Also please provide a commit message. You can look at some examples in
| the hg history:
|
|     http://hg.savannah.gnu.org/hgweb/octave/
|
| We haven't clearly spelled out the guidelines for writing a commit
| message anywhere, but they're roughly adapted from the GNU coding
| standards:
|
|     http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html

Also, do we care about using a consistent coding style or not?  I
thought we were (mostly) using the GNU coding conventions in all
Octave code.

jwe



--
Atul jangra
Computer Science and Engineering
Indian Institute of Technology ,Delhi

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

Jordi Gutiérrez Hermoso-2
In reply to this post by John W. Eaton
2012/3/16 John W. Eaton <[hidden email]>:

> Also, do we care about using a consistent coding style or not?  I
> thought we were (mostly) using the GNU coding conventions in all
> Octave code.

Yeah, the GUI code needs some GNU cleanup. But at least Atul followed
the convention of the code he was modifying.

- Jordi G. H.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

Atul  jangra
Here is a better patch for the same functionality .
Any betterments that you all think are always welcomed :)

P.S. : Sorry for the silly mistakes , I am in learning process.



--
Atul jangra
Computer Science and Engineering
Indian Institute of Technology ,Delhi


SettingsChange.patch (8K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

jacob.dawid
In reply to this post by Jordi Gutiérrez Hermoso-2
I don't how this is a "patch". The settings window is not supposed to have any Discard- or Save-Button, please don't repeat bad UI design in new application, just because everyone else does. Also, the code as it is now should be following the GNU Coding Style, as I used a tool that converted all that code automatically.

Am 16. März 2012 18:03 schrieb Jordi Gutiérrez Hermoso <[hidden email]>:
2012/3/16 John W. Eaton <[hidden email]>:

> Also, do we care about using a consistent coding style or not?  I
> thought we were (mostly) using the GNU coding conventions in all
> Octave code.

Yeah, the GUI code needs some GNU cleanup. But at least Atul followed
the convention of the code he was modifying.

- Jordi G. H.



--
„Alle sagten: Das geht nicht. Da kam einer, der wusste das nicht und hat's gemacht.“ - Unbekannt
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

Jordi Gutiérrez Hermoso-2
2012/3/16 Jacob Dawid <[hidden email]>:
> I don't how this is a "patch". The settings window is not supposed to have
> any Discard- or Save-Button, please don't repeat bad UI design in new
> application, just because everyone else does. Also, the code as it is now
> should be following the GNU Coding Style, as I used a tool that converted
> all that code automatically.

I seem to have missed this message back when I was looking this over.
I'm sorry it's taken me so long to review it.

Atul, I will defer to Jacob's opinion here. I won't apply your patch.
However, it is good that you have demonstrated that you can create Qt
patches. It seems we will need to spend some time thinking about
designing the interface before we jump in with code. I will now review
the other things you've asked me to think about.

- Jordi G. H.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for adding features in Settings GUI

Atul  jangra
Okay :). I wanted to demonstrate my QT experience through this patch. :) I agree that Design guidelines should be strictly followed. 
Thanks a lot for considering this :)
P.S. Jacob also told me the same reason, but I still submitted this patch as a pre-GSoC task.
Warm Regards
--
Atul jangra
Computer Science and Engineering
Indian Institute of Technology ,Delhi

Loading...