Patch to improve GUI editor on HiDPI displays

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch to improve GUI editor on HiDPI displays

Mike Miller-4
Hi,

Is there anyone who regularly builds the development version of Octave
for Windows or for macOS with a HiDPI / Retina display that can test the
attached patch for me?

I have seen some reports that the Octave GUI editor looks pixelated on
HiDPI displays. The attached patch is supposed to fix this. I have no
such hardware to test on (donations welcome), but the patch doesn't make
things any worse for me.

Can anyone test and confirm whether the patch improves the appearance of
the editor? Worse? No change?

Thanks,

--
mike

octave-qscintilla-set-buffered-draw.patch (615 bytes) Download Attachment
signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

bpabbott
Administrator
> On Apr 25, 2018, at 11:16 PM, Mike Miller <[hidden email]> wrote:
>
> Hi,
>
> Is there anyone who regularly builds the development version of Octave
> for Windows or for macOS with a HiDPI / Retina display that can test the
> attached patch for me?
>
> I have seen some reports that the Octave GUI editor looks pixelated on
> HiDPI displays. The attached patch is supposed to fix this. I have no
> such hardware to test on (donations welcome), but the patch doesn't make
> things any worse for me.
>
> Can anyone test and confirm whether the patch improves the appearance of
> the editor? Worse? No change?
>
> Thanks,
>
> --
> mike
> <octave-qscintilla-set-buffered-draw.patch>

Mike,

I regularly build the development branch on macOS on my MacBook Pro with a HiDPI / Retina display.

However, I don’t see\notice pixelated problems. fwiw, building with your patch looks fine to me as well.

Ben
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

John Swensen-3
In reply to this post by Mike Miller-4


> On Apr 25, 2018, at 11:16 PM, Mike Miller <[hidden email]> wrote:
>
> Hi,
>
> Is there anyone who regularly builds the development version of Octave
> for Windows or for macOS with a HiDPI / Retina display that can test the
> attached patch for me?
>
> I have seen some reports that the Octave GUI editor looks pixelated on
> HiDPI displays. The attached patch is supposed to fix this. I have no
> such hardware to test on (donations welcome), but the patch doesn't make
> things any worse for me.
>
> Can anyone test and confirm whether the patch improves the appearance of
> the editor? Worse? No change?
>
> Thanks,
>
> --
> mike
> <octave-qscintilla-set-buffered-draw.patch>

I don’t see a problem either on my MacOS with Homebrew. In fact, I don’t see any difference with and without the patch.

John S.
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

avlas-2
El divendres, 27 d’abril de 2018, a les 0:49:33 EDT, John Swensen va escriure:

 
  > On Apr 25, 2018, at 11:16 PM, Mike Miller <[hidden email]> wrote:
  >
  > Hi,
  >
  > Is there anyone who regularly builds the development version of Octave
  > for Windows or for macOS with a HiDPI / Retina display that can test the
  > attached patch for me?
  >
  > I have seen some reports that the Octave GUI editor looks pixelated on
  > HiDPI displays. The attached patch is supposed to fix this. I have no
  > such hardware to test on (donations welcome), but the patch doesn't make
  > things any worse for me.
  >
  > Can anyone test and confirm whether the patch improves the appearance of
  > the editor? Worse? No change?
  >
  > Thanks,
  >
 
  I don’t see a problem either on my MacOS with Homebrew. In fact, I don’t see any difference with and without the patch.
 
  John S.

It does make a difference in Linux, solving pixelated text in Octave's editor (at least) in KDE with hidpi screen scaled to a non-integer number.

[We've already talked about this, but thought that it may be useful for giving some context to others...]

....
a.



Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

John Swensen-3

> On Apr 27, 2018, at 3:51 AM, avlas <[hidden email]> wrote:
>
> El divendres, 27 d’abril de 2018, a les 0:49:33 EDT, John Swensen va escriure:
>
>
>> On Apr 25, 2018, at 11:16 PM, Mike Miller <[hidden email]> wrote:
>>
>> Hi,
>>
>> Is there anyone who regularly builds the development version of Octave
>> for Windows or for macOS with a HiDPI / Retina display that can test the
>> attached patch for me?
>>
>> I have seen some reports that the Octave GUI editor looks pixelated on
>> HiDPI displays. The attached patch is supposed to fix this. I have no
>> such hardware to test on (donations welcome), but the patch doesn't make
>> things any worse for me.
>>
>> Can anyone test and confirm whether the patch improves the appearance of
>> the editor? Worse? No change?
>>
>> Thanks,
>>
>
>  I don’t see a problem either on my MacOS with Homebrew. In fact, I don’t see any difference with and without the patch.
>
>  John S.
>
> It does make a difference in Linux, solving pixelated text in Octave's editor (at least) in KDE with hidpi screen scaled to a non-integer number.
>
> [We've already talked about this, but thought that it may be useful for giving some context to others...]
>
> ....
> a.
>

I think the non/integer pixel ratio must be the deal. I did.a quick test and on all three of my displays, the pixel ratio is always 2.0 or 1.0 regardless of which screen and how I set up the scaling. Maybe there is something with MacOS where not integer pixel ratios are handled under the hood and it fakes exactly 2.0 or 1.0?

John S
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Sebastian Schöps
In reply to this post by Mike Miller-4
Mike Miller-4 wrote
> Can anyone test and confirm whether the patch improves the appearance of
> the editor? Worse? No change?

No pixel problems here before or after the patch.

Seb.



--
Sent from: http://octave.1599824.n4.nabble.com/Octave-Maintainers-f1638794.html

Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Mike Miller-4
In reply to this post by John Swensen-3
On Thu, Apr 26, 2018 at 21:49:33 -0700, John Swensen wrote:
> I don’t see a problem either on my MacOS with Homebrew. In fact, I
> don’t see any difference with and without the patch.

Thanks for testing.

Any Windows testers?

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

nrjank
In reply to this post by Mike Miller-4
On Fri, Apr 27, 2018 at 12:03 PM, Mike Miller <[hidden email]> wrote:
On Thu, Apr 26, 2018 at 21:49:33 -0700, John Swensen wrote:
> I don’t see a problem either on my MacOS with Homebrew. In fact, I
> don’t see any difference with and without the patch.

Thanks for testing.

Any Windows testers?

this is a HiDPI problem?  what sort of screen setup would be needed to test/verify?  and of course it would need someone able to compile and test on windows. one of these days I'll get set up to do that, but today is not that day...
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Mike Miller-4
On Fri, Apr 27, 2018 at 13:25:53 -0400, Nicholas Jankowski wrote:
> this is a HiDPI problem?  what sort of screen setup would be needed to
> test/verify?  and of course it would need someone able to compile and test
> on windows. one of these days I'll get set up to do that, but today is not
> that day...

At the very least, I would like someone to verify that the patch does
not make things any worse, even on a normal 96 DPI screen.

But yes I would like a test from someone who has a version of Windows
that supports DPI scaling and a high-resolution screen to test Octave
with and without the patch applied.

This patch has already been proven to be beneficial on GNU/Linux systems
with HiDPI scaling enabled. If no one volunteers to test on Windows, I
will probably just apply it on the default branch for Octave 5 and we'll
see if anyone notices later. I would really like to apply it on the
stable branch with some testing.

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

mmuetzel
I cross-compiled with and without your patch, set the screen scaling to 125%,
re-booted and opened Octave showing the editor. I  didn't notice any
difference (see attached screen shots).

Same with my usual 100% screen scaling. So I guess it is save to apply your
patch if it helps on Linux.

<http://octave.1599824.n4.nabble.com/file/t371856/without_hidpi_patch.png>
<http://octave.1599824.n4.nabble.com/file/t371856/with_hidpi_patch.png>



--
Sent from: http://octave.1599824.n4.nabble.com/Octave-Maintainers-f1638794.html

Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Mike Miller-4
On Thu, May 03, 2018 at 10:21:12 -0700, mmuetzel wrote:
> I cross-compiled with and without your patch, set the screen scaling to 125%,
> re-booted and opened Octave showing the editor. I  didn't notice any
> difference (see attached screen shots).

Thank you, very much appreciated.

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

avlas-2
El divendres, 4 de maig de 2018, a les 13:10:40 EDT, Mike Miller va escriure:

  On Thu, May 03, 2018 at 10:21:12 -0700, mmuetzel wrote:
  > I cross-compiled with and without your patch, set the screen scaling to 125%,
  > re-booted and opened Octave showing the editor. I  didn't notice any
  > difference (see attached screen shots).
 
  Thank you, very much appreciated.
 
 
Hey Mike,

Can we hope this patch to be part of an eventual Octave 4.4.1?

Thanks and best

...
a.



Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Rik-4
In reply to this post by Mike Miller-4
On 05/04/2018 03:25 PM, [hidden email] wrote:
Subject:
Re: Patch to improve GUI editor on HiDPI displays
From:
avlas [hidden email]
Date:
05/04/2018 03:25 PM
To:
[hidden email]
CC:
Mike Miller [hidden email]
List-Post:
[hidden email]
Content-Transfer-Encoding:
7Bit
Precedence:
list
MIME-Version:
1.0
References:
[hidden email] [hidden email] [hidden email]
In-Reply-To:
[hidden email]
Message-ID:
<12019784.tQQboNL1sj@kerna>
Content-Type:
text/plain; charset="us-ascii"
Message:
4

El divendres, 4 de maig de 2018, a les 13:10:40 EDT, Mike Miller va escriure:

  On Thu, May 03, 2018 at 10:21:12 -0700, mmuetzel wrote:
  > I cross-compiled with and without your patch, set the screen scaling to 125%,
  > re-booted and opened Octave showing the editor. I  didn't notice any
  > difference (see attached screen shots).
  
  Thank you, very much appreciated.
  
  
Hey Mike,

Can we hope this patch to be part of an eventual Octave 4.4.1?

The minor releases are typically only for bug fixes, and this is very much a feature addition.  That doesn't mean we can't make an exception, but it should be debated first.

--Rik
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Mike Miller-4
On Fri, May 04, 2018 at 17:07:58 -0700, Rik wrote:
> The minor releases are typically only for bug fixes, and this is very much
> a feature addition.  That doesn't mean we can't make an exception, but it
> should be debated first.

I would call this a bug fix, I think it is entirely appropriate to make
on the stable branch for 4.4.1, and I was planning on doing so.

This patch changes the default value of a Scintilla internal setting,
that the Scintilla docs themselves say should be a reasonable default on
any modern graphics system.

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

avlas-2
El divendres, 4 de maig de 2018, a les 20:52:01 EDT, Mike Miller va escriure:

  On Fri, May 04, 2018 at 17:07:58 -0700, Rik wrote:
  > The minor releases are typically only for bug fixes, and this is very much
  > a feature addition.  That doesn't mean we can't make an exception, but it
  > should be debated first.
 
  I would call this a bug fix, I think it is entirely appropriate to make
  on the stable branch for 4.4.1, and I was planning on doing so.
 
  This patch changes the default value of a Scintilla internal setting,
  that the Scintilla docs themselves say should be a reasonable default on
  any modern graphics system.
 

Hi Rik and Mike,

I understand the risk and hesitation. Any final decision is fine to me, although my hope is for a fix being released relatively soon as it's quite uncomfortable working with the editor at this point.

Thanks!

...
a.



Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Rik-4
In reply to this post by Mike Miller-4
On 05/05/2018 02:10 AM, [hidden email] wrote:
> Subject: > Re: Patch to improve GUI editor on HiDPI displays > From: > Mike Miller [hidden email] > Date: > 05/04/2018 05:52 PM > To: > [hidden email] > List-Post: > [hidden email] > Precedence: > list > MIME-Version: > 1.0 > References: > [hidden email] <MTAwMDAzNi5ub21hZA.1525478884@quikprotect> > In-Reply-To: > <MTAwMDAzNi5ub21hZA.1525478884@quikprotect> > Message-ID: > [hidden email] > Content-Type: > multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" > Message: > 2 > > On Fri, May 04, 2018 at 17:07:58 -0700, Rik wrote: >> The minor releases are typically only for bug fixes, and this is very much >> a feature addition. That doesn't mean we can't make an exception, but it >> should be debated first. > I would call this a bug fix, I think it is entirely appropriate to make > on the stable branch for 4.4.1, and I was planning on doing so. > > This patch changes the default value of a Scintilla internal setting, > that the Scintilla docs themselves say should be a reasonable default on > any modern graphics system.
Is this a patch for bug #49053 or something different?  My comments are directed towards that bug.

--Rik
Reply | Threaded
Open this post in threaded view
|

Re: Patch to improve GUI editor on HiDPI displays

Sebastian Schöps
Rik-4 wrote
> Is this a patch for bug #49053 or something different?  My comments are
> directed towards that bug.

It's something different. Mike's patch is about a Linux-specific issue of
the editor on HiDPI systems. The patch does not affect the other systems.
Bug #49053 is about plotting (and is fixed for me by the recent patch of
John Swensen; sadly a bit too late for 4.4).

Bye
Sebastian



--
Sent from: http://octave.1599824.n4.nabble.com/Octave-Maintainers-f1638794.html