Question about copyright headers of JIT-related files

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Question about copyright headers of JIT-related files

jbect
Hi all,

JIT-related source file have the line "Copyright (C) 2012-2019 Max Brister".

I was wondering about the reason this, since Max Brister contributions
were all done in 2012, 2013.

Other people have made changes in the following years.  For instance, I
have extracted below the list of commits that have changed pt-jit.cc.

Should we do something about this ?

@++
Julien

---------------

6657213145e5 | 2019-01-14 07:11 +0100 | Julien Bect
<[hidden email]> | libinterp/parse-tree/pt-jit.cc: comment:
Fix a typo
e590d8ad9ed0 | 2019-01-04 11:02 +0100 | Julien Bect
<[hidden email]> | jit: Remove jit::PassManager and
jit::FunctionPassManager from public API
df230bb22ba6 | 2019-01-03 21:54 +0100 | Julien Bect
<[hidden email]> | jit: configure: Check if
llvm::IRBuilder::CreateConstInBoundsGEP1_32 API
ed1dad5e71c3 | 2019-01-02 16:37 +0100 | Julien Bect
<[hidden email]> | jit: configure: Check if
llvm/Bitcode/ReaderWriter.h exists
ea25fc64c275 | 2019-01-02 16:08 +0100 | Julien Bect
<[hidden email]> | jit: configure: Check if
llvm::createAlwaysInlinerPass exists
7a77eb39c7f0 | 2019-01-01 14:34 +0100 | Julien Bect
<[hidden email]> | jit: configure: Check if
llvm/Transforms/Scalar/GVN.h exists
d68381feb6cb | 2019-01-01 07:15 +0100 | Julien Bect
<[hidden email]> | jit: Avoid the use of
llvm::getGlobalContext, removed in LLVM 3.9
6c65dafb72ca | 2019-01-03 10:19 -0800 | Rik <[hidden email]> |
pt-jit.cc: Fix static analyzer detected issues (bug #55347).
00f796120a6d | 2019-01-02 16:32 -0500 | John W. Eaton <[hidden email]> |
maint: Update copyright dates in all source files.

0e207a5cc212 | 2018-11-16 14:56 -0500 | John W. Eaton <[hidden email]> |
eliminate useless function
c60a5493688a | 2018-11-01 14:37 -0400 | John W. Eaton <[hidden email]> |
avoid std::cout in JIT compiler code
cb1606f78f6b | 2018-06-07 10:11 -0400 | John W. Eaton <[hidden email]> |
prefer <istream>, <ostream>, or <iosfwd> to <iostream> where possible
4d7790d9793f | 2018-05-03 01:13 -0400 | John W. Eaton <[hidden email]> |
use cbegin, crbegin, cend, and crend and auto decls where possible
416856765a55 | 2018-05-03 00:39 -0400 | John W. Eaton <[hidden email]> |
be more careful with using auto in place of explicit const iterator decls
3ff9192b676e | 2018-05-02 01:36 -0400 | John W. Eaton <[hidden email]> |
use auto keyword to declare iterator variables where possible
389757b7b6af | 2018-05-02 00:30 -0400 | John W. Eaton <[hidden email]> |
eliminate redundant octave:: namespace tags
98596e4522bc | 2018-04-04 08:51 -0400 | John W. Eaton <[hidden email]> |
* pt-jit.cc: Fix typo from cset 078b795c5219.
e512eaba5206 | 2018-04-04 08:29 -0400 | John W. Eaton <[hidden email]> |
maint: Strip trailing whitespace from source files.
078b795c5219 | 2018-04-03 13:52 -0700 | Rik <[hidden email]> | maint:
style check C++ ahead of 4.4 release.
6652d3823428 | 2018-03-30 09:19 -0400 | John W. Eaton <[hidden email]> |
maint: Update copyright dates in all source files.
fa4e852dae1e | 2018-03-07 16:42 -0500 | John W. Eaton <[hidden email]> |
use m_ prefix consistently in jit compiler classes in the parser
7620f1f5290d | 2018-03-07 14:56 -0500 | John W. Eaton <[hidden email]> |
use m_ prefix for member variables in parse tree classes
3695c2cd69b8 | 2018-02-12 00:58 -0500 | John W. Eaton <[hidden email]> |
don't use singleton pattern for bp_table
194eb4bd202b | 2018-01-06 07:57 -0800 | Rik <[hidden email]> | maint:
Update punctuation for GPL v3 license text.

8bcfddad15ec | 2017-11-27 01:12 -0500 | John W. Eaton <[hidden email]> |
use shared_ptr to manage symbol_scope objects
8b14ba8296af | 2017-12-04 12:30 -0500 | John W. Eaton <[hidden email]> |
refactor symbol_record object
bc3819b7cca1 | 2017-11-16 21:43 -0500 | John W. Eaton <[hidden email]> |
don't use symbol_table:: nesting for symbol_record, symbol_scope, or
fcn_info
790b4389cfb4 | 2017-07-23 08:35 +0200 | Julien Bect
<[hidden email]> | jit: Use MJCIT instead of the old JIT
b3b7677334f6 | 2017-07-24 13:49 +0200 | Julien Bect
<[hidden email]> | jit: pt-jit.cc: Use
createBasicAAWrapperPass instead of createBasicAliasAnalysisPass
9eef7983b9bc | 2017-07-24 13:54 +0200 | Julien Bect
<[hidden email]> | jit: pt-jit.cc: Fix llvm::raw_fd_ostream
syntax
735ebdfdb7d4 | 2017-07-23 18:56 +0200 | Julien Bect
<[hidden email]> | jit: pt-jit.cc: Add type argument to
CreateConstInBoundsGEP1_32 (LLVM >= 3.7)
ca25f6e48ca5 | 2017-07-21 07:32 +0200 | Julien Bect
<[hidden email]> | jit: Convert
llvm::Function::arg_iterator to pointer explicitely
51e408a7d38f | 2017-10-15 21:08 +0200 | Julien Bect
<[hidden email]> | jit: Move everything inside the octave
namespace
8d8e4d8e6fdc | 2017-10-17 07:13 +0200 | Julien Bect
<[hidden email]> | pt-jit.cc: Fix visit_*_command methods
in jit_convert class
ec837ef7ee3b | 2017-10-17 21:35 +0200 | Julien Bect
<[hidden email]> | pt-jit.cc: Fix syntax error introduced
by cset 5cb3a2bb5e1e
980f39c3ab90 | 2017-07-25 14:54 -0700 | Rik <[hidden email]> | Use C++11
nullptr rather than 0 in code (bug #51565).
b9378eff6d13 | 2017-06-25 09:50 -0400 | John W. Eaton <[hidden email]> |
move symbol_table class inside octave namespace
91c8f006ed8b | 2017-06-15 19:15 -0400 | John W. Eaton <[hidden email]> |
remove additional functions from symbol_table class
214cb58ccc1c | 2017-06-14 11:53 -0400 | John W. Eaton <[hidden email]> |
use pointer to scope instead of scope id
5cb3a2bb5e1e | 2017-06-09 02:21 -0400 | John W. Eaton <[hidden email]> |
don't use singleton for symbol_table
21baad6b35c4 | 2017-04-28 13:19 -0700 | Rik <[hidden email]> | maint:
Use C++11 nullptr rather than 0 or NULL when possible.
855122b993da | 2017-04-27 17:33 -0700 | Rik <[hidden email]> | maint:
Wrap tertiary operator in parentheses "(COND ? x : y)".
c763214a8260 | 2017-04-27 15:18 -0700 | Rik <[hidden email]> | maint:
Use convention 'int *x' for naming pointers.
c452180ab672 | 2017-04-21 18:07 -0400 | John W. Eaton <[hidden email]> |
begin refactoring parse tree evaluator
c9fab0bc983e | 2017-04-24 17:20 -0700 | Rik <[hidden email]> | maint:
Use convention 'int& x' for naming references.
7dfa3bc8e3d5 | 2017-04-20 12:34 -0400 | John W. Eaton <[hidden email]> |
handle boolean expressions separately in JIT compiler
092078913d54 | 2017-02-22 12:58 -0500 | John W. Eaton <[hidden email]> |
maint: Merge stable to default.
b3f2645803fe | 2017-02-04 14:34 -0500 | Mike Miller
<[hidden email]> | Add headers needed on MacOS to avoid "implicit
instantiation of undefined
334119c390b3 | 2017-02-02 16:16 -0500 | John W. Eaton <[hidden email]> |
move bp_table class to separate file
2eb7d330eb7f | 2017-01-31 17:43 -0500 | John W. Eaton <[hidden email]> |
move JIT compiler files from corefcn to parse-tree directory
3ac9f9ecfae5 | 2017-02-22 12:39 -0500 | John W. Eaton <[hidden email]> |
maint: Update copyright dates.
ef4d915df748 | 2017-01-23 14:27 -0500 | John W. Eaton <[hidden email]> |
maint: Merge stable to default.
e9a0469dedd9 | 2017-01-20 12:19 -0500 | John W. Eaton <[hidden email]> |
maint: strip extra trailing newlines from files.

3a2b891d0b33 | 2016-11-13 20:33 -0800 | Rik <[hidden email]> | maint:
Standardize Copyright formatting.
48c00363dc74 | 2016-09-01 09:33 -0700 | Rik <[hidden email]> | maint:
Use '{ }' for empty function bodies in C++.
34ce5be04942 | 2016-08-30 21:46 -0700 | Rik <[hidden email]> | maint:
Style check C++ code in libinterp/.
bac0d6f07a3e | 2016-08-17 01:05 -0400 | John W. Eaton <[hidden email]> |
maint: Update copyright notices for 2016.
dd992fd74fce | 2016-07-12 14:28 -0400 | John W. Eaton <[hidden email]> |
put parser, lexer, and evaluator in namespace; interpreter now owns
evaluator
8de49f15e182 | 2016-07-24 12:17 +0200 | Andreas Weber
<[hidden email]> | doc: Fix "doubled words" typos (\b(\w+)\s+\1\b)
6db928d06b07 | 2016-07-06 18:31 -0400 | John W. Eaton <[hidden email]> |
move signal functions into octave namespace
278fc29b69ca | 2016-07-01 19:48 -0700 | Rik <[hidden email]> | maint:
Eliminate unnecessary double newline blocks (only whitespace changes).
112b20240c87 | 2016-06-21 16:07 -0400 | John W. Eaton <[hidden email]> |
move docstrings in C++ files out of C strings and into comments
b571fc85953f | 2016-05-19 18:48 -0700 | Rik <[hidden email]> | maint:
Use two spaces after period to indicate sentence break.
f4d7d0eb5b0c | 2016-05-19 12:56 -0400 | John W. Eaton <[hidden email]> |
use namespace for unwind_protect class
aba2e6293dd8 | 2016-05-17 12:09 -0400 | John W. Eaton <[hidden email]> |
use "#if ..." consistently instead of "#ifdef" and "#ifndef"
683a1beee538 | 2016-04-01 14:55 -0700 | Rik <[hidden email]> | maint:
Use "FIXME:" for all code blocks needing further attention.
40de9f8f23a6 | 2016-02-18 13:34 -0800 | Rik <[hidden email]> | Use
'#include "config.h"' rather than <config.h>.
fcac5dbbf9ed | 2016-02-05 16:29 -0800 | Rik <[hidden email]> | maint:
Indent #ifdef blocks in libinterp.
bd1752782e56 | 2016-01-19 12:44 -0800 | Rik <[hidden email]> | Use
err_disabled_feature, warn_disabled_feature throughout code base.
3e7cfee5f786 | 2016-01-05 14:16 -0800 | Rik <[hidden email]> | maint:
Rename attributes GCC_ATTR_XXX to OCTAVE_XXX.

77f5591878bf | 2015-12-20 10:15 -0800 | Rik <[hidden email]> | maint:
Use '! expr' rather than '!expr' to conform to coding guidelines.
1142cf6abc0d | 2015-12-12 07:40 -0800 | Rik <[hidden email]> | 2015 Code
Sprint: remove class of function from docstring for all C++ files.
d35201e5ce5d | 2015-10-12 16:08 -0700 | Rik <[hidden email]> | Fix
compilation of jit broken by dd6345fd8a97 (bug #46191).
4f45eaf83908 | 2015-05-09 17:19 -0700 | Rik <[hidden email]> | doc:
Update more docstrings to have one sentence summary as first line.
9cf91ecdc6f7 | 2015-02-23 17:01 -0800 | Rik <[hidden email]> | Rename
jit_failure_count() to jit_failcnt().
4197fc428c7d | 2015-02-11 14:19 -0500 | John W. Eaton <[hidden email]> |
maint: Update copyright notices for 2015.
db92e7e28e1f | 2015-01-20 10:29 -0500 | John W. Eaton <[hidden email]> |
strip trailing whitespace from most source files

885d38747cd5 | 2014-01-27 15:52 +0100 | Stefan Mahr <[hidden email]> |
Fix failing JIT tests (bug #41312).
770c0d79341b | 2014-07-17 11:48 -0400 | John W. Eaton <[hidden email]> |
avoid some unused variable warnings if LLVM is not available
4a4edf0f2077 | 2014-05-11 02:28 +0200 | Stefan Mahr <[hidden email]> |
fix LLVM 3.4 build (bug #41061)
fe0e34be5576 | 2014-04-27 18:02 -0700 | Rik <[hidden email]> | maint:
untabify recently added code files.
cd7e09b0abf8 | 2014-01-06 14:00 +0100 | Stefan Mahr <[hidden email]> |
jit compiler: Delete unused variable
421bed6994f0 | 2014-01-05 17:51 +0100 | Stefan Mahr <[hidden email]> |
jit compiler: Add support for switch statement

2a8243d8327a | 2013-12-27 13:01 +0100 | LYH <[hidden email]> | jit
compiler: Add support for the do_until statement
7e425ca58e9c | 2013-08-23 11:33 +0800 | LYH <[hidden email]> | jit
compiler: Add fail reason to jit_fail_exceptions
8b22a9215ec2 | 2013-11-02 23:09 +0100 | Stefan Mahr <[hidden email]> |
jit compiler: Fix uninitialized variable warning
efa4572997ba | 2013-11-04 11:30 +0100 | Stefan Mahr <[hidden email]> |
jit compiler: Add counter of jit_fail_exceptions to check if jit
compilation fails
97e49b588f5d | 2013-11-05 12:27 -0500 | John W. Eaton <[hidden email]> |
maint: periodic merge of default to classdef
26e9312e6928 | 2013-10-29 11:09 -0700 | Rik <[hidden email]> | Build JIT
compiler by default, but do not enable it by default.
175b392e91fe | 2013-10-28 19:51 -0700 | Rik <[hidden email]> | Use GNU
style coding conventions for code in libinterp/
93b3d03b05e7 | 2013-10-23 22:29 -0400 | John W. Eaton <[hidden email]> |
maint: periodic merge of default to classdef
d63878346099 | 2013-10-23 22:09 -0400 | John W. Eaton <[hidden email]> |
maint: Update copyright notices for release.
c702371ff6df | 2013-10-05 11:22 -0400 | John W. Eaton <[hidden email]> |
maint: periodic merge of default to classdef
bc924baa2c4e | 2013-08-19 20:46 -0700 | Rik <[hidden email]> | doc: Add
new @qcode macro for code samples which are quoted.
36fd98b9ce48 | 2013-08-03 16:53 -0600 | Max Brister <[hidden email]> |
Add support for llvm 3.3
38bcfd413db0 | 2013-05-01 17:54 +0800 | LYH <[hidden email]> |
Handle LLVM API incoherence. Octave now works with LLVM 3.0, 3.1, and 3.2
e6ddaa65a777 | 2013-07-09 17:37 -0700 | Rik <[hidden email]> | Add new
function jit_startcnt to control JIT acceleration.
c2a57f9c6a2e | 2013-07-09 12:19 -0700 | Rik <[hidden email]> | maint:
Move tests for JIT compiler into separate .tst file.
498b2dd1bd56 | 2013-07-04 10:09 -0400 | John W. Eaton <[hidden email]> |
periodic merge of default to classdef
68fc671a9339 | 2013-07-03 17:43 -0700 | Rik <[hidden email]> | maint:
Collapse interpfcn and interpfcn-core directories into corefcn directory.
5482cd26311a | 2013-06-30 15:16 -0700 | Rik <[hidden email]> | Rename
enable_jit_compiler to jit_enable, enable_jit_debugging to debug_jit.
e2de3c8882be | 2013-06-18 06:39 -0400 | John W. Eaton <[hidden email]> |
copyright notice fixes
2ed5bc680c71 | 2013-04-22 16:37 -0400 | John W. Eaton <[hidden email]> |
maint: periodic merge of default to classdef
302157614308 | 2013-04-06 11:51 -0400 | John W. Eaton <[hidden email]> |
deprecate symbol_table::varref functions
0259254a3ccc | 2013-02-28 02:04 -0500 | John W. Eaton <[hidden email]> |
maint: periodic merge of default to classdef
e125db98263f | 2013-02-26 15:22 -0800 | Rik <[hidden email]> | build:
Eliminate 2 unused variable warnings when not compiling with JIT.
0cbac4d3a81c | 2013-01-12 13:36 -0500 | Michael Goffioul
<[hidden email]> | periodic merge of default to classdef
1f076c40c133 | 2013-01-03 12:35 -0700 | Max Brister <[hidden email]> | Do
not use vectorized llvm commands for complex numbers

896cf5769537 | 2012-12-23 19:02 -0500 | Michael Goffioul
<[hidden email]> | Add visit_funcall method to JIT tree walker.
44272909d926 | 2012-11-04 21:11 -0700 | Max Brister <[hidden email]> |
Stop JIT on interrupt
f3e339aee38f | 2012-11-04 20:09 -0700 | Max Brister <[hidden email]> |
Fix block labeling in JIT debug output
6e780fb15c14 | 2012-11-04 16:28 -0700 | Max Brister <[hidden email]> |
Make Vdebug_on_interrupt not be static
24bbd2efea12 | 2012-11-04 16:04 -0700 | Max Brister <[hidden email]> |
pt-jit.cc (tree_jit::enabled): Do not jit if Vdebug_on_interrupt or
Vdebug_on_error
6fc163b59746 | 2012-11-04 15:38 -0700 | Max Brister <[hidden email]> |
Correctly handle break/continue for some corner cases in JIT
0754bdfbc8fe | 2012-11-02 16:52 -0600 | Max Brister <[hidden email]> |
Correct multiplication complex multiplication with NaN in JIT
52df2e7baabe | 2012-11-02 14:32 -0600 | Max Brister <[hidden email]> |
Disable JIT when breakpoints are present
4d6e5fa37899 | 2012-10-17 08:57 -0700 | Rik <[hidden email]> | doc:
Update docstrings for enable_jit_debugging and enable_jit_compiler.
29382eb90285 | 2012-10-05 10:49 -0700 | Rik <[hidden email]> | Fix
compilation when JIT is enabled.
05aee5a1ff37 | 2012-10-05 12:27 -0400 | Jordi Gutiérrez Hermoso
<[hidden email]> | silence some compilation warnings
3f447bcc8488 | 2012-10-03 03:07 -0400 | John W. Eaton <[hidden email]> |
set Venable_jit_debugging and Venable_jit_compiler variables directly
from command line options
8ccb187b24e9 | 2012-09-14 06:09 -0600 | Max Brister <[hidden email]> |
Erase partially created functions on JIT compilation failure (bug #37308)
8355fddce815 | 2012-09-12 19:18 -0600 | Max Brister <[hidden email]> |
Use sret and do not use save/restore stack (bug #37308)
6bdf379592d9 | 2012-09-10 17:02 -0500 | Max Brister <[hidden email]> |
Remove --enable-jit-debug configure option
b49d707fe9d7 | 2012-09-10 00:49 -0600 | Max Brister <[hidden email]> |
pt-jit.cc (jit_function_info::jit_function_info): Verify llvm IR when
debugging
3f43e9d6d86e | 2012-09-09 00:29 -0600 | Max Brister <[hidden email]> |
JIT compile anonymous functions
8125773322d4 | 2012-09-08 17:20 -0600 | Max Brister <[hidden email]> |
Error on undefined an unused variables in JIT
de9bfcf637df | 2012-09-06 02:19 -0600 | Max Brister <[hidden email]> |
Fix error when compiling with complex matrix (bug #37247)
b055fc077224 | 2012-09-06 01:33 -0400 | John W. Eaton <[hidden email]> |
allow jit compiler to be enabled at run-time
4c0cef65c55f | 2012-08-28 17:12 -0600 | Max Brister <[hidden email]> |
pt-jit.cc (jit_infer::do_construct_ir): Correct extraious phi removal
ffa0b85a87f4 | 2012-08-25 15:52 -0600 | Max Brister <[hidden email]> |
pt-jit.cc (jit_info::compile): Fix compile error with OCTAVE_JIT_DEBUG
defined
c27a1e131b16 | 2012-08-25 15:43 -0600 | Max Brister <[hidden email]> |
pt-jit.cc (jit_convert::visit_simple_for_command): Fix block order
b0c08e995950 | 2012-08-25 13:36 -0600 | Max Brister <[hidden email]> |
pt-jit.cc (jit_convert::get_variable): Add type bound
2fc554ffbc28 | 2012-08-18 16:23 -0400 | John W. Eaton <[hidden email]> |
split libinterp from src


Reply | Threaded
Open this post in threaded view
|

Re: Question about copyright headers of JIT-related files

Jordi Gutiérrez Hermoso-2
On Thu, 2019-01-17 at 22:03 +0100, Julien Bect wrote:
> JIT-related source file have the line "Copyright (C) 2012-2019 Max Brister".
>
> I was wondering about the reason this, since Max Brister contributions
> were all done in 2012, 2013.

Unless a great tragedy has happened, I believe Max is still alive.
Since we are still publishing (reprinting?) his work, his years of
copyright are still getting updated.

Admittedly, we've never been too careful about not updating copyright
years for those who are no longer alive.

> Other people have made changes in the following years.  For instance, I
> have extracted below the list of commits that have changed pt-jit.cc.

People who have made nontrivial contributions (I don't think anyone
has, we haven't really touched Max's code in a significant way) can
add their copyright lines to this file.


Reply | Threaded
Open this post in threaded view
|

Re: Question about copyright headers of JIT-related files

jbect
Le 01/02/2019 à 04:44, Jordi Gutiérrez Hermoso a écrit :

> On Thu, 2019-01-17 at 22:03 +0100, Julien Bect wrote:
>> JIT-related source file have the line "Copyright (C) 2012-2019 Max Brister".
>>
>> I was wondering about the reason this, since Max Brister contributions
>> were all done in 2012, 2013.
> Unless a great tragedy has happened, I believe Max is still alive.
> Since we are still publishing (reprinting?) his work, his years of
> copyright are still getting updated.
>
> Admittedly, we've never been too careful about not updating copyright
> years for those who are no longer alive.


You are certainly very funny, but it was an honest question...

My understanding was that we should indicate as copyright years, for a
given contributor on a given file, the actual years where "significant"
contributions where made.

Apparently not ?


Reply | Threaded
Open this post in threaded view
|

Re: Question about copyright headers of JIT-related files

siko1056
On Fri, Feb 1, 2019 at 8:50 AM Julien Bect <[hidden email]> wrote:
Le 01/02/2019 à 04:44, Jordi Gutiérrez Hermoso a écrit :
>
> Admittedly, we've never been too careful about not updating copyright
> years for those who are no longer alive.


You are certainly very funny, but it was an honest question...

My understanding was that we should indicate as copyright years, for a
given contributor on a given file, the actual years where "significant"
contributions where made.

Apparently not ?


Apparently not.  Like Jordi explained, Octave code base is huge and updating the copyrights is not trivial.  In general once in each year, jwe pushes a huge cset like


and the task is done without caring too much about "significant" years contributions where made.  At least the topmost author gets the updated year.  For details Octave has version control, like you used to identify the case for Max Brister.  So if you think your contributions are significant, credit your work and put yourself as top author of the file and receive updated years for the sake of copyright laws.  Some examples of different scenarios:


Best,
Kai
Reply | Threaded
Open this post in threaded view
|

Re: Question about copyright headers of JIT-related files

Jordi Gutiérrez Hermoso-2
In reply to this post by jbect
On Fri, 2019-02-01 at 08:49 +0100, Julien Bect wrote:

> Le 01/02/2019 à 04:44, Jordi Gutiérrez Hermoso a écrit :
> > On Thu, 2019-01-17 at 22:03 +0100, Julien Bect wrote:
> > > JIT-related source file have the line "Copyright (C) 2012-2019 Max Brister".
> > >
> > > I was wondering about the reason this, since Max Brister contributions
> > > were all done in 2012, 2013.
> >
> > Unless a great tragedy has happened, I believe Max is still alive.
> > Since we are still publishing (reprinting?) his work, his years of
> > copyright are still getting updated.
> >
> > Admittedly, we've never been too careful about not updating copyright
> > years for those who are no longer alive.
>
>
> You are certainly very funny, but it was an honest question...

It was an honest answer. I wasn't trying to be funny. We certainly do
have some dead contributors in the codebase (I mean, Octave has been
around for close to three decades now), and we've never been too
careful to make sure we don't update their copyrights again.

Copyrights for living people are updated if their works are
republished. That's what we're doing for Max. We're continuously
publishing his work, every year.


Reply | Threaded
Open this post in threaded view
|

Re: Question about copyright headers of JIT-related files

jbect
Le 03/02/2019 à 17:23, Jordi Gutiérrez Hermoso a écrit :

> On Fri, 2019-02-01 at 08:49 +0100, Julien Bect wrote:
>> Le 01/02/2019 à 04:44, Jordi Gutiérrez Hermoso a écrit :
>>> On Thu, 2019-01-17 at 22:03 +0100, Julien Bect wrote:
>>>> JIT-related source file have the line "Copyright (C) 2012-2019 Max Brister".
>>>>
>>>> I was wondering about the reason this, since Max Brister contributions
>>>> were all done in 2012, 2013.
>>> Unless a great tragedy has happened, I believe Max is still alive.
>>> Since we are still publishing (reprinting?) his work, his years of
>>> copyright are still getting updated.
>>>
>>> Admittedly, we've never been too careful about not updating copyright
>>> years for those who are no longer alive.
>>
>> You are certainly very funny, but it was an honest question...
> It was an honest answer. I wasn't trying to be funny. We certainly do
> have some dead contributors in the codebase (I mean, Octave has been
> around for close to three decades now), and we've never been too
> careful to make sure we don't update their copyrights again.
>
> Copyrights for living people are updated if their works are
> republished. That's what we're doing for Max. We're continuously
> publishing his work, every year.


Ok, thank you for explaining.  (But then, according to your argument,
copyright notices should be updated for every living author ?)

My own understanding of copyright notices is that "Copyright XXXX-YYYY
SomeOne" is supposed to mean that SomeOne has produced versions of the
work in each year of the range XXXX-YYYY.

Which is why (again, in my understanding) you sometimes see complicated
copyright notices such as:

./libinterp/parse-tree/oct-parse.cc:5:   Copyright (C) 1984, 1989-1990,
2000-2015 Free Software Foundation, Inc.

So, I just don't understand the point of "updating a copyright"
(extending the range) after SomeOne has stopped contributing (whether
he/she is alive or not, by the way): if the file is re-published with no
significant changes, then the copyright notice could stay the same.  If
there have been significant changes by other people, then copyright
notices can be added for these people.

But obviously, IANAL and now I can see (cf Kai's email) that this is the
way things are done in the entire Octave code base, not just in
JIT-related files.  Fine.

@++