Re: 4.4 Release Checklist - Item #8 - 'make check'

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: 4.4 Release Checklist - Item #8 - 'make check'

Rik-4
Starting Item #8 on the Release Checklist

8. Verify 'make check' is passing
  • Start discussion on octave-maintainers list about which failing tests must be fixed
  • Identify and fix any tests determined critical in step above

The buildbots seem to be having a problem with uicontextmenu recently.  A number of operating system / compiler combinations are failing this test:

>>>>> processing /scratch/buildbot/slaves/jwe-debian-x86_64-1/gcc-7-debian/build/libinterp/corefcn/graphics.cc-tst
***** test
 hf = figure ("visible", "off");
 hax = axes ("parent", hf);
 unwind_protect
   hctx1 = uicontextmenu ("parent", hf);
   hctx2 = uicontextmenu ("parent", hf);
   set (hf, "uicontextmenu", hctx2);
   set (hax, "uicontextmenu", hctx2);
   assert (get (hf, "uicontextmenu"), hctx2);
   assert (get (hax, "uicontextmenu"), hctx2);
   assert (get (hf, "children"), [hctx2; hctx1; hax]);
   delete (hctx2);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hax, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
   set (hf, "uicontextmenu", hctx1);
   assert (get (hf, "uicontextmenu"), hctx1);
   set (hf, "uicontextmenu", []);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
 unwind_protect_cleanup
   close (hf);
 end_unwind_protect;
!!!!! test failed
ASSERT errors for:  assert (get (hf, "uicontextmenu"),[])

  Location  |  Observed  |  Expected  |  Reason
     .          O(1x1)       E(0x0)      Dimensions don't match

--Rik





Reply | Threaded
Open this post in threaded view
|

Re: 4.4 Release Checklist - Item #8 - 'make check'

Dmitri A. Sergatskov


On Thu, Mar 29, 2018 at 12:01 PM, Rik <[hidden email]> wrote:
Starting Item #8 on the Release Checklist

8. Verify 'make check' is passing
  • Start discussion on octave-maintainers list about which failing tests must be fixed
  • Identify and fix any tests determined critical in step above

The buildbots seem to be having a problem with uicontextmenu recently.  A number of operating system / compiler combinations are failing this test:

>>>>> processing /scratch/buildbot/slaves/jwe-debian-x86_64-1/gcc-7-debian/build/libinterp/corefcn/graphics.cc-tst
***** test
 hf = figure ("visible", "off");
 hax = axes ("parent", hf);
 unwind_protect
   hctx1 = uicontextmenu ("parent", hf);
   hctx2 = uicontextmenu ("parent", hf);
   set (hf, "uicontextmenu", hctx2);
   set (hax, "uicontextmenu", hctx2);
   assert (get (hf, "uicontextmenu"), hctx2);
   assert (get (hax, "uicontextmenu"), hctx2);
   assert (get (hf, "children"), [hctx2; hctx1; hax]);
   delete (hctx2);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hax, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
   set (hf, "uicontextmenu", hctx1);
   assert (get (hf, "uicontextmenu"), hctx1);
   set (hf, "uicontextmenu", []);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
 unwind_protect_cleanup
   close (hf);
 end_unwind_protect;
!!!!! test failed
ASSERT errors for:  assert (get (hf, "uicontextmenu"),[])

  Location  |  Observed  |  Expected  |  Reason
     .          O(1x1)       E(0x0)      Dimensions don't match

--Rik


​See also:

 https://savannah.gnu.org/bugs/index.php?53513

​Dmitri.
--


Reply | Threaded
Open this post in threaded view
|

Re: 4.4 Release Checklist - Item #8 - 'make check'

Marco Caliari-4
In reply to this post by Rik-4
On Thu, 29 Mar 2018 10:01:10 -0700
Rik <[hidden email]> wrote:

> Starting Item #8 on the Release Checklist
>
> 8. Verify 'make check' is passing
>
>   * Start discussion on octave-maintainers list about which failing tests
>     must be fixed

In ilu.m there is a xtest. Matlab is claimed to pass, which is true, but its
result has L singular. Incomplete lu is used for preconditioners, and the
L, U, factors need to be non-singular. I think that Octave is right when it
says that a pivot is 0. I would change the %!xtest into a %!error and the
comment to % Matlab R2017b returns a singular L.

Thanks,

Marco

Reply | Threaded
Open this post in threaded view
|

Re: 4.4 Release Checklist - Item #8 - 'make check'

Rik-4
On 03/29/2018 02:20 PM, Marco Caliari wrote:

> On Thu, 29 Mar 2018 10:01:10 -0700
> Rik <[hidden email]> wrote:
>
>> Starting Item #8 on the Release Checklist
>>
>> 8. Verify 'make check' is passing
>>
>>   * Start discussion on octave-maintainers list about which failing tests
>>     must be fixed
> In ilu.m there is a xtest. Matlab is claimed to pass, which is true, but its
> result has L singular. Incomplete lu is used for preconditioners, and the
> L, U, factors need to be non-singular. I think that Octave is right when it
> says that a pivot is 0. I would change the %!xtest into a %!error and the
> comment to % Matlab R2017b returns a singular L.

Done.  See this cset
(http://hg.savannah.gnu.org/hgweb/octave/rev/ef8c6852a53d).

--Rik