Re: Octave-maintainers Digest, Vol 154, Issue 3

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Octave-maintainers Digest, Vol 154, Issue 3

John Donoghue-3

> Message: 1
> Date: Tue, 1 Jan 2019 18:46:45 -0800
> From: Rik <[hidden email]>
> To: [hidden email]
> Subject: Re: Lint checking annotation.cc
> Message-ID: <MTAwMDAyMi5ub21hZA.1546397212@quikprotect>
> Content-Type: text/plain; charset="windows-1252"
>
> On 01/01/2019 06:15 PM, [hidden email] wrote:
>> Subject:
>> Re: Lint checking Octave
>> From:
>> Andreas Weber <[hidden email]>
>> Date:
>> 01/01/2019 09:54 AM
>>
>> To:
>> [hidden email]
>>
>>
>> Am 31.12.18 um 21:10 schrieb Rik:
>>> dismissed.? I have created a page to track the status of this at
>>> https://wiki.octave.org/PVS_static_analyzer_-_5.0_Release.
>> How should we proceed if someone who checks the point can confirm, that
>> there is a problem but is not able to solve it?
>>
>> For example this
>> https://hg.savannah.gnu.org/hgweb/octave/rev/c164cfc24bdd#l2.171
>>
>> looks like a copy and paste error but I don't know what was intended here.
> If you can't figure it out, see if you can contact the original author.? In
> this case it is John Donoghue and he is definitely still around in the
> Octave sphere.
>
> --Rik
>

looks to me like the else statement shouldnt be there


Reply | Threaded
Open this post in threaded view
|

Re: Lint checking Octave

John Donoghue-3
On 1/2/19 6:25 AM, John Donoghue wrote:

>
>> Message: 1
>> Date: Tue, 1 Jan 2019 18:46:45 -0800
>> From: Rik <[hidden email]>
>> To: [hidden email]
>> Subject: Re: Lint checking annotation.cc
>> Message-ID: <MTAwMDAyMi5ub21hZA.1546397212@quikprotect>
>> Content-Type: text/plain; charset="windows-1252"
>>
>> On 01/01/2019 06:15 PM, [hidden email] wrote:
>>> Subject:
>>> Re: Lint checking Octave
>>> From:
>>> Andreas Weber <[hidden email]>
>>> Date:
>>> 01/01/2019 09:54 AM
>>>
>>> To:
>>> [hidden email]
>>>
>>>
>>> Am 31.12.18 um 21:10 schrieb Rik:
>>>> dismissed.? I have created a page to track the status of this at
>>>> https://wiki.octave.org/PVS_static_analyzer_-_5.0_Release.
>>> How should we proceed if someone who checks the point can confirm, that
>>> there is a problem but is not able to solve it?
>>>
>>> For example this
>>> https://hg.savannah.gnu.org/hgweb/octave/rev/c164cfc24bdd#l2.171
>>>
>>> looks like a copy and paste error but I don't know what was intended
>>> here.
>> If you can't figure it out, see if you can contact the original
>> author.? In
>> this case it is John Donoghue and he is definitely still around in the
>> Octave sphere.
>>
>> --Rik
>>
>
> looks to me like the else statement shouldnt be there
>
That is, only set the width/height if there are the values to do so