On 11/14/2017 09:00 AM, [hidden email] wrote:
Some of it may be less accurate, but some of it is philosophical. Apple chose to re-write their libraries to get away from any "Open Source" dependence, but they also made some different decisions on gray areas of the C and C++ specification from other libraries. See this conversation from 2010 (http://octave.1599824.n4.nabble.com/Re-Apple-atan2f-td3037234.html). I don't want to be bothered re-hashing that. The easiest thing to do is to widen the tolerances which allows the tests to pass on both Windows and Mac systems. Annoying that Linux users are being punished by the Windows and Mac operating systems into changing our tests.
We should do this anyways, and I think the approach of canonicalize_file_name is probably a good one.
Calculating values to 1 eps is important for values that will be used in further calculations, but there is no way the human eye is going to detect a 2*eps difference in angle. I think we can widen the tolerance on this test without repercussions.
No idea about this one, I haven't looked at it.
|Free forum by Nabble||Edit this page|