default branch build failure on macOS

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

default branch build failure on macOS

bpabbott
Administrator
jwe,

After the recent changes I’m unable to build.

hg tip
changeset:   25873:75f7e8728e17
bookmark:    @
tag:         tip
user:        Rik <[hidden email]>
date:        Mon Sep 10 11:06:43 2018 -0700
summary:     importdata.m: Correct import of NA in files with CRLF endings (bug #54622).

If you don’t think this is due to the OpenGL wrapper changes, I’ll bisect.

Ben

g++ -v
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 9.1.0 (clang-902.0.39.2)
Target: x86_64-apple-darwin17.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin


libtool: compile:  g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/Cellar/fontconfig/2.13.0/include -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/opt/hdf5/include -I/usr/local/Cellar/qt/5.10.1/include/QtNetwork -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtOpenGL -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtPrintSupport -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtHelp -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtWidgets -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtGui -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtSql -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtCore -I/usr/local/Cellar/qt/5.10.1/include -Ilibgui/graphics -I./libgui/graphics -Isrc -I./libgui/src -Iliboctave -I./liboctave/array -Iliboctave/numeric -I./liboctave/numeric -Iliboctave/operators -I./liboctave/operators -I./liboctave/system -I./liboctave/util -Ilibinterp -I./libinterp -Ilibinterp/parse-tree -I./libinterp/parse-tree -Ilibinterp/corefcn -I./libinterp/corefcn -I./libinterp/octave-value -I/usr/local/opt/readline/include -I/usr/local/opt/sqlite/include -I/usr/local/opt/openssl/include -I/usr/local/opt/gettext/include -I/usr/local/opt/icu4c/include -fPIC -D_THREAD_SAFE -pthread -Wall -W -Wshadow -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -MT libgui/graphics/libgui_graphics_la-GLCanvas.lo -MD -MP -MF libgui/graphics/.deps/libgui_graphics_la-GLCanvas.Tpo -c libgui/graphics/GLCanvas.cc  -fno-common -DPIC -o libgui/graphics/.libs/libgui_graphics_la-GLCanvas.o
libgui/graphics/GLCanvas.cc:50:13: error: constructor for 'QtHandles::GLCanvas' must explicitly initialize the member 'm_renderer' which does not have
      a default constructor
  GLCanvas::GLCanvas (QWidget *xparent, const graphics_handle& gh)
            ^
libgui/graphics/GLCanvas.h:89:29: note: member is declared here
    octave::opengl_renderer m_renderer;
                            ^
libinterp/corefcn/gl-render.h:36:3: note: 'octave::opengl_renderer' declared here
  opengl_renderer
  ^
libgui/graphics/GLCanvas.cc:69:33: error: no matching constructor for initialization of 'octave::opengl_renderer'
        octave::opengl_renderer r;
                                ^
libinterp/corefcn/gl-render.h:40:5: note: candidate constructor not viable: requires single argument 'glfcns', but no arguments were provided
    opengl_renderer (opengl_functions& glfcns);
    ^
libinterp/corefcn/gl-render.h:44:5: note: candidate constructor not viable: requires 1 argument, but 0 were provided
    opengl_renderer (const opengl_renderer&) = delete;
    ^
libgui/graphics/GLCanvas.cc:104:37: error: no matching constructor for initialization of 'octave::opengl_renderer'
            octave::opengl_renderer r;
                                    ^
libinterp/corefcn/gl-render.h:40:5: note: candidate constructor not viable: requires single argument 'glfcns', but no arguments were provided
    opengl_renderer (opengl_functions& glfcns);
    ^
libinterp/corefcn/gl-render.h:44:5: note: candidate constructor not viable: requires 1 argument, but 0 were provided
    opengl_renderer (const opengl_renderer&) = delete;
    ^
libgui/graphics/GLCanvas.cc:113:37: error: no matching constructor for initialization of 'octave::opengl_renderer'
            octave::opengl_renderer r;
                                    ^
libinterp/corefcn/gl-render.h:40:5: note: candidate constructor not viable: requires single argument 'glfcns', but no arguments were provided
    opengl_renderer (opengl_functions& glfcns);
    ^
libinterp/corefcn/gl-render.h:44:5: note: candidate constructor not viable: requires 1 argument, but 0 were provided
    opengl_renderer (const opengl_renderer&) = delete;
    ^
libgui/graphics/GLCanvas.cc:142:53: error: too few arguments to function call, expected 4, have 3
                                 term.toStdString ());
                                                    ^
libinterp/corefcn/gl2ps-print.h:35:3: note: 'gl2ps_print' declared here
  extern OCTINTERP_API void
  ^
libgui/graphics/GLCanvas.cc:177:33: error: no matching constructor for initialization of 'octave::opengl_selector'
        octave::opengl_selector s;
                                ^
libgui/graphics/gl-select.h:43:5: note: candidate constructor not viable: requires single argument 'glfcns', but no arguments were provided
    opengl_selector (opengl_functions& glfcns)
    ^
libgui/graphics/gl-select.h:40:9: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 0 were provided
  class opengl_selector : public opengl_renderer
        ^
6 errors generated.
make[2]: *** [libgui/graphics/libgui_graphics_la-GLCanvas.lo] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2


Reply | Threaded
Open this post in threaded view
|

Re: default branch build failure on macOS

John W. Eaton
Administrator
On 09/11/2018 10:39 AM, Ben Abbott wrote:

> jwe,
>
> After the recent changes I’m unable to build.
>
> hg tip
> changeset:   25873:75f7e8728e17
> bookmark:    @
> tag:         tip
> user:        Rik <[hidden email]>
> date:        Mon Sep 10 11:06:43 2018 -0700
> summary:     importdata.m: Correct import of NA in files with CRLF endings (bug #54622).
>
> If you don’t think this is due to the OpenGL wrapper changes, I’ll bisect.

> libtool: compile:  g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/Cellar/fontconfig/2.13.0/include -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/opt/hdf5/include -I/usr/local/Cellar/qt/5.10.1/include/QtNetwork -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtOpenGL -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtPrintSupport -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtHelp -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtWidgets -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtGui -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtSql -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtCore -I/usr/local/Cellar/qt/5.10.1/include -Ilibgui/graphics -I./libgui/graphics -Isrc -I./libgui/src -Iliboctave -I./liboctave/array -Iliboctave/numeric -I./liboctave/numeric -Iliboctave/operators -I./liboctave/operators -I./liboctave/system -I./liboctave/util -Ilibinterp -I./libinterp -Ilibinterp/parse-tree -I./libinterp/parse-tree -Ilibinterp/corefcn -I./libinterp/corefcn -I./libinterp/octave-value -I/usr/local/opt/readline/include -I/usr/local/opt/sqlite/include -I/usr/local/opt/openssl/include -I/usr/local/opt/gettext/include -I/usr/local/opt/icu4c/include -fPIC -D_THREAD_SAFE -pthread -Wall -W -Wshadow -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -MT libgui/graphics/libgui_graphics_la-GLCanvas.lo -MD -MP -MF libgui/graphics/.deps/libgui_graphics_la-GLCanvas.Tpo -c libgui/graphics/GLCanvas.cc  -fno-common -DPIC -o libgui/graphics/.libs/libgui_graphics_la-GLCanvas.o
> libgui/graphics/GLCanvas.cc:50:13: error: constructor for 'QtHandles::GLCanvas' must explicitly initialize the member 'm_renderer' which does not have
>        a default constructor
>    GLCanvas::GLCanvas (QWidget *xparent, const graphics_handle& gh)

The GLCanvas constructor does initialize m_renderer with an argument:

http://hg.savannah.gnu.org/hgweb/octave/file/75f7e8728e17/libgui/graphics/GLCanvas.cc#l50

> libgui/graphics/GLCanvas.cc:69:33: error: no matching constructor for initialization of 'octave::opengl_renderer'
>          octave::opengl_renderer r;
>                                  ^

In the current sources, line 69 of GLCanvas.cc is not as shown above.

Do you have local changes?  Your output form "hg tip" shows that you
have the latest changeset, but that is not necessarily where your
working directory is.  You may be at some other revision.  Use "hg id"
to see where.

Also, tip isn't necessarily even on the current branch.  It's just the
most recent changeset in the hg archive.

jwe
Reply | Threaded
Open this post in threaded view
|

Re: default branch build failure on macOS

bpabbott
Administrator
On Sep 11, 2018, at 8:32 AM, Ben Abbott <[hidden email]> wrote:

On Sep 11, 2018, at 07:51, John W. Eaton <[hidden email]> wrote:

On 09/11/2018 10:39 AM, Ben Abbott wrote:
jwe,
After the recent changes I’m unable to build.
hg tip
changeset:   25873:75f7e8728e17
bookmark:    @
tag:         tip
user:        Rik <[hidden email]>
date:        Mon Sep 10 11:06:43 2018 -0700
summary:     importdata.m: Correct import of NA in files with CRLF endings (bug #54622).
If you don’t think this is due to the OpenGL wrapper changes, I’ll bisect.

libtool: compile:  g++ -std=gnu++11 -DHAVE_CONFIG_H -I. -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/Cellar/fontconfig/2.13.0/include -I/usr/local/opt/freetype/include/freetype2 -I/usr/local/opt/hdf5/include -I/usr/local/Cellar/qt/5.10.1/include/QtNetwork -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtOpenGL -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtPrintSupport -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtHelp -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtWidgets -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtGui -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtSql -I/usr/local/Cellar/qt/5.10.1/include -I/usr/local/Cellar/qt/5.10.1/include/QtCore -I/usr/local/Cellar/qt/5.10.1/include -Ilibgui/graphics -I./libgui/graphics -Isrc -I./libgui/src -Iliboctave -I./liboctave/array -Iliboctave/numeric -I./liboctave/numeric -Iliboctave/operators -I./liboctave/operators -I./liboctave/system -I./liboctave/util -Ilibinterp -I./libinterp -Ilibinterp/parse-tree -I./libinterp/parse-tree -Ilibinterp/corefcn -I./libinterp/corefcn -I./libinterp/octave-value -I/usr/local/opt/readline/include -I/usr/local/opt/sqlite/include -I/usr/local/opt/openssl/include -I/usr/local/opt/gettext/include -I/usr/local/opt/icu4c/include -fPIC -D_THREAD_SAFE -pthread -Wall -W -Wshadow -Wold-style-cast -Wformat -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -MT libgui/graphics/libgui_graphics_la-GLCanvas.lo -MD -MP -MF libgui/graphics/.deps/libgui_graphics_la-GLCanvas.Tpo -c libgui/graphics/GLCanvas.cc  -fno-common -DPIC -o libgui/graphics/.libs/libgui_graphics_la-GLCanvas.o
libgui/graphics/GLCanvas.cc:50:13: error: constructor for 'QtHandles::GLCanvas' must explicitly initialize the member 'm_renderer' which does not have
     a default constructor
 GLCanvas::GLCanvas (QWidget *xparent, const graphics_handle& gh)

The GLCanvas constructor does initialize m_renderer with an argument:

http://hg.savannah.gnu.org/hgweb/octave/file/75f7e8728e17/libgui/graphics/GLCanvas.cc#l50

libgui/graphics/GLCanvas.cc:69:33: error: no matching constructor for initialization of 'octave::opengl_renderer'
       octave::opengl_renderer r;
                               ^

In the current sources, line 69 of GLCanvas.cc is not as shown above.

Do you have local changes?  Your output form "hg tip" shows that you have the latest changeset, but that is not necessarily where your working directory is.  You may be at some other revision.  Use "hg id" to see where.

Also, tip isn't necessarily even on the current branch.  It's just the most recent changeset in the hg archive.

jwe

Ahh. I may have some changes in place. I’ll check when I’m back in front of my Mac.

Thanks,
Ben

I’ve modified the patch associated with bug 49053


The default branch builds for me on macOS and figures display correctly on my mac with a retina/HiDPI display.

Ben