deprecate-props.tst failures on buildbot systems

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

deprecate-props.tst failures on buildbot systems

John W. Eaton
Administrator
I'm seeing the following failures on the buildbot systems.  What is the
reason for these tests failing?  Should they be xtest instead?  Or is
this something that should be fixed some other way?  I'd prefer to not
have these always failing.

jwe


 >>>>> processing deprecate-props.tst
***** test
  hf = figure ("visible", "off");
  unwind_protect
    hp = patch ();
    testprop (hp, "normalmode", "4.4");
  unwind_protect_cleanup
    close (hf);
  end_unwind_protect
  hf = figure ("visible", "off");
  unwind_protect
    hs = surface ();
    testprop (hs, "normalmode", "4.4");
  unwind_protect_cleanup
    close (hf);
  end_unwind_protect
!!!!! test failed
Please remove patch property normalmode
***** test
  hf = figure ("visible", "off");
  unwind_protect
    ha = axes ();
    testprop (ha, "xaxislocation", "4.4", "zero");
    testprop (ha, "yaxislocation", "4.4", "zero");
  unwind_protect_cleanup
    close (hf);
  end_unwind_protect
!!!!! test failed
Please remove 'zero' from allowed values for axes property xaxislocation

Reply | Threaded
Open this post in threaded view
|

Re: deprecate-props.tst failures on buildbot systems

Pantxo
John W. Eaton wrote

> I'm seeing the following failures on the buildbot systems.  What is the
> reason for these tests failing?  Should they be xtest instead?  Or is
> this something that should be fixed some other way?  I'd prefer to not
> have these always failing.
>
> jwe
>
>
>  >>>>> processing deprecate-props.tst
> ***** test
>   hf = figure ("visible", "off");
>   unwind_protect
>     hp = patch ();
>     testprop (hp, "normalmode", "4.4");
>   unwind_protect_cleanup
>     close (hf);
>   end_unwind_protect
>   hf = figure ("visible", "off");
>   unwind_protect
>     hs = surface ();
>     testprop (hs, "normalmode", "4.4");
>   unwind_protect_cleanup
>     close (hf);
>   end_unwind_protect
> !!!!! test failed
> Please remove patch property normalmode
> ***** test
>   hf = figure ("visible", "off");
>   unwind_protect
>     ha = axes ();
>     testprop (ha, "xaxislocation", "4.4", "zero");
>     testprop (ha, "yaxislocation", "4.4", "zero");
>   unwind_protect_cleanup
>     close (hf);
>   end_unwind_protect
> !!!!! test failed
> Please remove 'zero' from allowed values for axes property xaxislocation

This is the mechanism we have found to take care of deprecated properties
(or values for specific properties). So yes we should do what the test tells
us to do, i.e. removing some properties or values (and the corresponding
test). I'll take care of it tonight.

Pantxo



--
Sent from: http://octave.1599824.n4.nabble.com/Octave-Maintainers-f1638794.html

Reply | Threaded
Open this post in threaded view
|

Re: deprecate-props.tst failures on buildbot systems

Pantxo
Reply | Threaded
Open this post in threaded view
|

Re: deprecate-props.tst failures on buildbot systems

John W. Eaton
Administrator
On 03/22/2018 06:05 PM, Pantxo wrote:
>
> I pushed this cset:
>
> http://hg.savannah.gnu.org/hgweb/octave/rev/47f25e164ab1

Thanks.

jwe