f77_exception_encountered

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

f77_exception_encountered

Doug Stewart-4
While installing the control pkg I get lots of these warnings:
Is this something that is wrong with the control pkg or is it in Octave?



In file included from __control_slicot_functions__.cc:48:0:
sl_mb05nd.cc: In function ‘octave_value_list F__sl_mb05nd__(const octave_value_list&, int)’:
sl_mb05nd.cc:96:13: warning: ‘f77_exception_encountered’ is deprecated: [4.4]: this variable is obsolete and should not be needed [-Wdeprecated-declarations]
         if (f77_exception_encountered)
             ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from common.h:31:0,
                 from sl_ab08nd.cc:31,
                 from __control_slicot_functions__.cc:1:
/usr/local/include/octave-4.4.1/octave/../octave/f77-fcn.h:49:18: note: declaredhere
 static const int f77_exception_encountered = 0;



--
DASCertificate for 206392

Reply | Threaded
Open this post in threaded view
|

Re: f77_exception_encountered

John W. Eaton
Administrator
On 1/3/19 9:29 AM, Doug Stewart wrote:

> While installing the control pkg I get lots of these warnings:
> Is this something that is wrong with the control pkg or is it in Octave?
>
>
>
> In file included from __control_slicot_functions__.cc:48:0:
> sl_mb05nd.cc: In function ‘octave_value_list F__sl_mb05nd__(const
> octave_value_list&, int)’:
> sl_mb05nd.cc:96:13: warning: ‘f77_exception_encountered’ is deprecated:
> [4.4]: this variable is obsolete and should not be needed
> [-Wdeprecated-declarations]
>           if (f77_exception_encountered)
>               ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from common.h:31:0,
>                   from sl_ab08nd.cc:31,
>                   from __control_slicot_functions__.cc:1:
> /usr/local/include/octave-4.4.1/octave/../octave/f77-fcn.h:49:18: note:
> declaredhere
>   static const int f77_exception_encountered = 0;

The f77_exception_encountered variable is no longer used by Octave.  We
left it in the header file so that older code that used it would
continue to compile.  The value will always be zero now.  So it is safe
to remove any blocks of code like

   if (f77_exception_encountered) { ... }

as they will never be executed now.  This has been true since Octave
version 4.4.0.

jwe


Reply | Threaded
Open this post in threaded view
|

Re: f77_exception_encountered

Doug Stewart-4


On Thu, Jan 3, 2019 at 9:53 AM John W. Eaton <[hidden email]> wrote:
On 1/3/19 9:29 AM, Doug Stewart wrote:
> While installing the control pkg I get lots of these warnings:
> Is this something that is wrong with the control pkg or is it in Octave?
>
>
>
> In file included from __control_slicot_functions__.cc:48:0:
> sl_mb05nd.cc: In function ‘octave_value_list F__sl_mb05nd__(const
> octave_value_list&, int)’:
> sl_mb05nd.cc:96:13: warning: ‘f77_exception_encountered’ is deprecated:
> [4.4]: this variable is obsolete and should not be needed
> [-Wdeprecated-declarations]
>           if (f77_exception_encountered)
>               ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from common.h:31:0,
>                   from sl_ab08nd.cc:31,
>                   from __control_slicot_functions__.cc:1:
> /usr/local/include/octave-4.4.1/octave/../octave/f77-fcn.h:49:18: note:
> declaredhere
>   static const int f77_exception_encountered = 0;

The f77_exception_encountered variable is no longer used by Octave.  We
left it in the header file so that older code that used it would
continue to compile.  The value will always be zero now.  So it is safe
to remove any blocks of code like

   if (f77_exception_encountered) { ... }

as they will never be executed now.  This has been true since Octave
version 4.4.0.

jwe



Thanks
I will remove It from the control pkg.


--
DASCertificate for 206392

Reply | Threaded
Open this post in threaded view
|

Re: f77_exception_encountered

Mike Miller-4
On Thu, Jan 03, 2019 at 10:27:39 -0500, Doug Stewart wrote:
> Thanks
> I will remove It from the control pkg.

Just be aware that by doing so you are dropping support for Octave 4.2
and earlier versions.

In your other thread you had expressed an interest in supporting 4.x,
which to me includes 4.0 and 4.2.

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: f77_exception_encountered

Doug Stewart-4


On Thu, Jan 3, 2019 at 2:16 PM Mike Miller <[hidden email]> wrote:
On Thu, Jan 03, 2019 at 10:27:39 -0500, Doug Stewart wrote:
> Thanks
> I will remove It from the control pkg.

Just be aware that by doing so you are dropping support for Octave 4.2
and earlier versions.

In your other thread you had expressed an interest in supporting 4.x,
which to me includes 4.0 and 4.2.

--
mike

Thanks for the info.
There are 51 warnings which I thing is too many to have.
Is there a way to turn off just these warnings?

--
DASCertificate for 206392

Reply | Threaded
Open this post in threaded view
|

Re: f77_exception_encountered

Mike Miller-4
On Thu, Jan 03, 2019 at 14:34:52 -0500, Doug Stewart wrote:
> Thanks for the info.
> There are 51 warnings which I thing is too many to have.
> Is there a way to turn off just these warnings?

You can look at the signal package Makefile. I disable the warnings by
default and leave in a way to re-enable them for testing as needed.

Excerpt:

    CXXFLAGS_PKG := -Wall -Wno-deprecated-declarations $(CXXFLAGS_PKG_APPEND)
    …
    $(MKOCTFILE) $(CXXFLAGS_PKG) …

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: f77_exception_encountered

Doug Stewart-4


On Thu, Jan 3, 2019 at 2:48 PM Mike Miller <[hidden email]> wrote:
On Thu, Jan 03, 2019 at 14:34:52 -0500, Doug Stewart wrote:
> Thanks for the info.
> There are 51 warnings which I thing is too many to have.
> Is there a way to turn off just these warnings?

You can look at the signal package Makefile. I disable the warnings by
default and leave in a way to re-enable them for testing as needed.

Excerpt:

    CXXFLAGS_PKG := -Wall -Wno-deprecated-declarations $(CXXFLAGS_PKG_APPEND)
    …
    $(MKOCTFILE) $(CXXFLAGS_PKG) …

--
mike
I must be too old for this :-)

I first looked at the installed signal pkg and did not find a makefile.

I then went here :
and did not find what you said.

--
DASCertificate for 206392

Reply | Threaded
Open this post in threaded view
|

Re: f77_exception_encountered

Mike Miller-4
On Thu, Jan 03, 2019 at 20:14:47 -0500, Doug Stewart wrote:
> I then went here :
> https://sourceforge.net/p/octave/signal/ci/default/tree/Makefile
> and did not find what you said.

The makefile at the top level is for you, the maintainer, only. Look for
the makefile in the src directory, that is the one used when the package
is installed.

  https://hg.mtmxr.com/octave-signal/file/tip/src/Makefile

--
mike

signature.asc (849 bytes) Download Attachment