gnulib issue, help...

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

gnulib issue, help...

jbect
Hi all,

My build of default fails like that:

  CXX      libgui/src/m-editor/libgui_src_libgui_src_la-file-editor-tab.lo
libgui/src/m-editor/file-editor-tab.cc: In member function ‘QTextCodec* octave::file_editor_tab::check_valid_codec()’:
libgui/src/m-editor/file-editor-tab.cc:2333:46: error: ‘class QString’ has no member named ‘toStdU32String’; did you mean ‘toStdString’?
         std::u32string u32_str = editor_text.toStdU32String ();

I assume that this is related to cs 4150560153922797 and ee5ecb1bc257.

I have tried to remove all generated files, bootstrap / configure / make again, without success.

Is there something particular that I need to do with gnulib?

@++
Julien
Reply | Threaded
Open this post in threaded view
|

Re: gnulib issue, help...

siko1056
On Tue, Jan 1, 2019 at 10:50 PM Julien Bect <[hidden email]> wrote:
Hi all,

My build of default fails like that:

  CXX      libgui/src/m-editor/libgui_src_libgui_src_la-file-editor-tab.lo
libgui/src/m-editor/file-editor-tab.cc: In member function ‘QTextCodec* octave::file_editor_tab::check_valid_codec()’:
libgui/src/m-editor/file-editor-tab.cc:2333:46: error: ‘class QString’ has no member named ‘toStdU32String’; did you mean ‘toStdString’?
         std::u32string u32_str = editor_text.toStdU32String ();

I assume that this is related to cs 4150560153922797 and ee5ecb1bc257.

I have tried to remove all generated files, bootstrap / configure / make again, without success.

Is there something particular that I need to do with gnulib?

@++
Julien

Just an idea.  The cset ee5ecb1bc257  "Add missing gnulib module" was applied to stable and later merged to default with cset 661fe14264c6.  Do you you pulled cset 661fe14264c6 for default already?

Kai
Reply | Threaded
Open this post in threaded view
|

Aw: gnulib issue, help...

mmuetzel
In reply to this post by jbect
Gesendet: Dienstag, 01. Januar 2019 um 22:49 Uhr
Von: "Julien Bect" <[hidden email]>
An: octave-maintainers <[hidden email]>
Betreff: gnulib issue, help...

> Hi all,
>
> My build of default fails like that:
>
>  CXX      libgui/src/m-editor/libgui_src_libgui_src_la-file-editor-tab.lo
> libgui/src/m-editor/file-editor-tab.cc: In member function ‘QTextCodec* octave::file_editor_tab::check_valid_codec()’:
> libgui/src/m-editor/file-editor-tab.cc:2333:46: error: ‘class QString’ has no member named ‘toStdU32String’; did you mean ‘toStdString’?
>         std::u32string u32_str = editor_text.toStdU32String ();
>
> I assume that this is related to cs 4150560153922797 and ee5ecb1bc257.
>
> I have tried to remove all generated files, bootstrap / configure / make again, without success.
>
> Is there something particular that I need to do with gnulib?
>
> @++
> Julien

It looks like this function was introduced in Qt 5.5. I'll try and find something that works with older Qt versions as well.
Sorry for this.

Markus
 

Reply | Threaded
Open this post in threaded view
|

Aw: gnulib issue, help...

mmuetzel
> It looks like this function was introduced in Qt 5.5. I'll try and find something that works with older Qt versions as well.
> Sorry for this.
>

Should be fixed with this changeset:
http://hg.savannah.gnu.org/hgweb/octave/rev/fd890481c408

Reply | Threaded
Open this post in threaded view
|

Re: Aw: gnulib issue, help...

jbect
Le 02/01/2019 à 03:55, "Markus Mützel" a écrit :
>> It looks like this function was introduced in Qt 5.5. I'll try and find something that works with older Qt versions as well.
>> Sorry for this.
>>
> Should be fixed with this changeset:
> http://hg.savannah.gnu.org/hgweb/octave/rev/fd890481c408


Now I get this one :

   CXX libgui/src/m-editor/libgui_src_libgui_src_la-file-editor-tab.lo
libgui/src/m-editor/file-editor-tab.cc: In member function ‘QTextCodec*
octave::file_editor_tab::check_valid_codec()’:
libgui/src/m-editor/file-editor-tab.cc:2340:60: error: ‘class
QVector<unsigned int>’ has no member named ‘length’
                                                src, u32_str.length (),
&length);

@++
Julien

Reply | Threaded
Open this post in threaded view
|

Re: gnulib issue, help...

mmuetzel
> Gesendet: Mittwoch, 02. Januar 2019 um 08:15 Uhr
> Von: "Julien Bect" <[hidden email]>
> An: [hidden email]
> Betreff: Re: Aw: gnulib issue, help...
>
> Now I get this one :
>
>    CXX libgui/src/m-editor/libgui_src_libgui_src_la-file-editor-tab.lo
> libgui/src/m-editor/file-editor-tab.cc: In member function ‘QTextCodec*
> octave::file_editor_tab::check_valid_codec()’:
> libgui/src/m-editor/file-editor-tab.cc:2340:60: error: ‘class
> QVector<unsigned int>’ has no member named ‘length’
>                                                 src, u32_str.length (),
> &length);
>


It's impressive how many incompatibilities I managed to squeeze into just a few lines of code...

Jokes aside: I set up a built tree for qt4 and hope that building with older qt versions finally works again with:
http://hg.savannah.gnu.org/hgweb/octave/rev/69cbbd2711ed

Markus

Reply | Threaded
Open this post in threaded view
|

Re: gnulib issue, help...

jbect
Le 02/01/2019 à 13:26, "Markus Mützel" a écrit :

>> Gesendet: Mittwoch, 02. Januar 2019 um 08:15 Uhr
>> Von: "Julien Bect" <[hidden email]>
>> An: [hidden email]
>> Betreff: Re: Aw: gnulib issue, help...
>>
>> Now I get this one :
>>
>>     CXX libgui/src/m-editor/libgui_src_libgui_src_la-file-editor-tab.lo
>> libgui/src/m-editor/file-editor-tab.cc: In member function ‘QTextCodec*
>> octave::file_editor_tab::check_valid_codec()’:
>> libgui/src/m-editor/file-editor-tab.cc:2340:60: error: ‘class
>> QVector<unsigned int>’ has no member named ‘length’
>>                                                  src, u32_str.length (),
>> &length);
>>
>
> It's impressive how many incompatibilities I managed to squeeze into just a few lines of code...
>
> Jokes aside: I set up a built tree for qt4 and hope that building with older qt versions finally works again with:
> http://hg.savannah.gnu.org/hgweb/octave/rev/69cbbd2711ed


Yes, now it's ok.  Thank you.

(And sorry for the irrelevant thread title, it was not a gnulib issue
after all... ;-)


Reply | Threaded
Open this post in threaded view
|

Re: gnulib issue, help...

jbect
Le 02/01/2019 à 14:45, Julien Bect a écrit :
Le 02/01/2019 à 13:26, "Markus Mützel" a écrit :
Gesendet: Mittwoch, 02. Januar 2019 um 08:15 Uhr
Von: "Julien Bect" [hidden email]
An: [hidden email]
Betreff: Re: Aw: gnulib issue, help...

Now I get this one :

    CXX libgui/src/m-editor/libgui_src_libgui_src_la-file-editor-tab.lo
libgui/src/m-editor/file-editor-tab.cc: In member function ‘QTextCodec*
octave::file_editor_tab::check_valid_codec()’:
libgui/src/m-editor/file-editor-tab.cc:2340:60: error: ‘class
QVector<unsigned int>’ has no member named ‘length’
                                                 src, u32_str.length (),
&length);


It's impressive how many incompatibilities I managed to squeeze into just a few lines of code...

Jokes aside: I set up a built tree for qt4 and hope that building with older qt versions finally works again with:
http://hg.savannah.gnu.org/hgweb/octave/rev/69cbbd2711ed


Yes, now it's ok.  Thank you.

(And sorry for the irrelevant thread title, it was not a gnulib issue after all... ;-)

Ooops, you did it again... (see cs 1e3c42fbf4d3)

Reply | Threaded
Open this post in threaded view
|

Re: gnulib issue, help...

mmuetzel
Gesendet: Freitag, 04. Januar 2019 um 14:41 Uhr
Von: "Julien Bect" <[hidden email]>
An: [hidden email]
Betreff: Re: gnulib issue, help...
>
> oops, you did it again... (see cs 1e3c42fbf4d3)

Fixed it baby one more time:
http://hg.savannah.gnu.org/hgweb/octave/rev/ba8493779dc8

Sorry for this. That must have sneaked in from a different tree.

Markus