signal 1.4.0 package update fails

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

signal 1.4.0 package update fails

nrjank
trying to update or install signal on new octave install (windows zip-package):

>> pkg install -forge signal
medfilt1.cc: In member function 'void sorted_window::init(const double*, octave_idx_type, octave_
idx_type, octave_idx_type)':
medfilt1.cc:91:7: error: 'bzero' was not declared in this scope
       bzero (buf, zeros * sizeof (double));
       ^~~~~
medfilt1.cc:91:7: note: suggested alternative: 'zeros'
       bzero (buf, zeros * sizeof (double));
       ^~~~~
       zeros
make: *** [medfilt1.oct] Error 1
make: Entering directory `/tmp/oct-nmhkqO/signal-1.4.0/src'
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  __fwht__.cc -o
 __fwht__.oct
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  __ultrwin__.cc
 -o __ultrwin__.oct
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  -c cl2bp.cc -o
 cl2bp.o
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  -c cl2bp_lib.c
c -o cl2bp_lib.o
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  cl2bp.o cl2bp_
lib.o -o cl2bp.oct
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  medfilt1.cc -o
 medfilt1.oct
make: Leaving directory `/tmp/oct-nmhkqO/signal-1.4.0/src'

pkg: error running `make' for the signal package.
error: called from
    configure_make at line 95 column 9
    install at line 184 column 7
    pkg at line 437 column 9
Reply | Threaded
Open this post in threaded view
|

Re: signal 1.4.0 package update fails

Mike Miller-4
On Mon, May 07, 2018 at 14:58:12 -0400, Nicholas Jankowski wrote:

> trying to update or install signal on new octave install (windows
> zip-package):
>
> >> pkg install -forge signal
> medfilt1.cc: In member function 'void sorted_window::init(const double*,
> octave_idx_type, octave_
> idx_type, octave_idx_type)':
> medfilt1.cc:91:7: error: 'bzero' was not declared in this scope
>        bzero (buf, zeros * sizeof (double));
>        ^~~~~
> medfilt1.cc:91:7: note: suggested alternative: 'zeros'
>        bzero (buf, zeros * sizeof (double));
>        ^~~~~
>        zeros
Thanks, but this is already reported.

  https://savannah.gnu.org/bugs/?53849

As I mentioned on the bug report, it would be helpful to have people
testing the package in development so these things can be caught before
a release is made. The medfilt1 function was updated four months ago.

--
mike

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: signal 1.4.0 package update fails

Montgomery-Smith, Stephen
In reply to this post by nrjank
FYI: with FreeBSD I get the following error:

/usr/local/bin/mkoctfile -Wno-deprecated-declarations  medfilt1.cc -o medfilt1.oct
medfilt1.cc:40:27: error: redefinition of 'truncate'
enum pad_type { zero_pad, truncate };
                          ^
/usr/include/sys/types.h:385:6: note: previous definition is here
int      truncate(const char *, off_t);
         ^
medfilt1.cc:326:19: error: assigning to 'pad_type' from incompatible type 'int
      (const char *, off_t)' (aka 'int (const char *, long)')
        padding = truncate;
                  ^~~~~~~~


I was able to fix it by renaming truncate to truncate2 (or I could have called it do_truncate).


________________________________________
From: Octave-maintainers [octave-maintainers-bounces+stephen=[hidden email]] on behalf of Nicholas Jankowski [[hidden email]]
Sent: Monday, May 7, 2018 1:58 PM
To: octave-maintainers
Subject: signal 1.4.0 package update fails

trying to update or install signal on new octave install (windows zip-package):

>> pkg install -forge signal
medfilt1.cc: In member function 'void sorted_window::init(const double*, octave_idx_type, octave_
idx_type, octave_idx_type)':
medfilt1.cc:91:7: error: 'bzero' was not declared in this scope
       bzero (buf, zeros * sizeof (double));
       ^~~~~
medfilt1.cc:91:7: note: suggested alternative: 'zeros'
       bzero (buf, zeros * sizeof (double));
       ^~~~~
       zeros
make: *** [medfilt1.oct] Error 1
make: Entering directory `/tmp/oct-nmhkqO/signal-1.4.0/src'
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  __fwht__.cc -o
 __fwht__.oct
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  __ultrwin__.cc
 -o __ultrwin__.oct
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  -c cl2bp.cc -o
 cl2bp.o
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  -c cl2bp_lib.c
c -o cl2bp_lib.o
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  cl2bp.o cl2bp_
lib.o -o cl2bp.oct
C:/Octave/OCTAVE~1.0-W/bin/mkoctfile-4.4.0.exe -Wall -Wno-deprecated-declarations  medfilt1.cc -o
 medfilt1.oct
make: Leaving directory `/tmp/oct-nmhkqO/signal-1.4.0/src'

pkg: error running `make' for the signal package.
error: called from
    configure_make at line 95 column 9
    install at line 184 column 7
    pkg at line 437 column 9

Reply | Threaded
Open this post in threaded view
|

Re: signal 1.4.0 package update fails

nrjank
In reply to this post by Mike Miller-4
On Mon, May 7, 2018 at 3:09 PM, Mike Miller <[hidden email]> wrote:
On Mon, May 07, 2018 at 14:58:12 -0400, Nicholas Jankowski wrote:
As I mentioned on the bug report, it would be helpful to have people
testing the package in development so these things can be caught before
a release is made. The medfilt1 function was updated four months ago.

 
happy to do pre-release package install testing when one is ready to go. any easy way to make a windoze-testerz distribution list or similar? many of us are typically hamstrung in the normal build/test process.

nickj