Error building logos

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Error building logos

PhilipNienhuis
Magei-4 Linux,
$ hg -v summary
parent: 19748:3fc946d5e91f tip
  make ginput work for all toolkits again (bug #41977)

Last part of build log:

:
make[2]: Entering directory '/home/philip/devel/octdev/oct391+/etc/icons'
w 512 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-512.png-t
w 256 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-256.png-t
w 128 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-128.png-t
w 64 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-64.png-t
w 48 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-48.png-t
w 32 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-32.png-t
w 24 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-24.png-t
w 22 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-22.png-t
making octave.desktop from ../../../3.9.1+/etc/icons/octave.desktop.in
/usr/bin/sed < ../../../3.9.1+/etc/icons/octave.desktop.in >
octave.desktop-t \
   -e "s|%OCTAVE_IMAGEDIR%|/usr/local/share/octave/3.9.1+/imagelib|" \
   -e "s|%OCTAVE_PREFIX%|/usr/local|"
mv octave-logo-64.png-t octave-logo-64.png
mv octave-logo-128.png-t octave-logo-128.png
mv octave-logo-512.png-t octave-logo-512.png
w 16 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-16.png-t
mv octave-logo-24.png-t octave-logo-24.png
mv octave-logo-48.png-t octave-logo-48.png
mv octave-logo-22.png-t octave-logo-22.png
mv octave.desktop-t octave.desktop
mv octave-logo-256.png-t octave-logo-256.png
mv octave-logo-16.png-t octave-logo-16.png
mv octave-logo-32.png-t octave-logo-32.png
icotool --create --raw octave-logo-256.png octave-logo-48.png
octave-logo-32.png octave-logo-16.png > octave-logo.ico-t
octave-logo-48.png: not a png file
Makefile:2370: recipe for target 'octave-logo.ico' failed
make[2]: *** [octave-logo.ico] Error 1
make[2]: Leaving directory '/home/philip/devel/octdev/oct391+/etc/icons'
Makefile:2122: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/philip/devel/octdev/oct391+'
Makefile:1985: recipe for target 'all' failed
make: *** [all] Error 2


Checking things out, I find that all .png logos in the
<build_dir>/etc/icons subdir have the same contents:

[philip@deskprn icons]$ ls -l
total 112
-rw-rw-r-- 1 philip philip 71251 Feb 18 21:45 Makefile
-rw-rw-r-- 1 philip philip   282 Feb 18 21:55 octave.desktop
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-128.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-16.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-22.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-24.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-256.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-32.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-48.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-512.png
-rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-64.png
-rw-rw-r-- 1 philip philip     0 Feb 18 21:59 octave-logo.ico-t
[philip@deskprn icons]$ cat octave-logo-16.png
  21:55:47 up 15 min,  3 users,  load average: 5.12, 7.38, 4.56
USER     TTY        LOGIN@   IDLE   JCPU   PCPU WHAT
[philip@deskprn icons]$


Octave itself is built fine; ./run-octave works.

Philip

Reply | Threaded
Open this post in threaded view
|

RE: Error building logos

John Donoghue-3

>
> Message: 5
> Date: Wed, 18 Feb 2015 22:11:13 +0100
> From: Philip Nienhuis <[hidden email]>
> To: [hidden email]
> Subject: Error building logos
> Message-ID: <[hidden email]>
> Content-Type: text/plain; charset=UTF-8; format=flowed
>
> Magei-4 Linux,
> $ hg -v summary
> parent: 19748:3fc946d5e91f tip
>   make ginput work for all toolkits again (bug #41977)
>
> Last part of build log:
>
> :
> make[2]: Entering directory '/home/philip/devel/octdev/oct391+/etc/icons'
> w 512 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-512.png-t w
256
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-256.png-t w 128
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-128.png-t w 64
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-64.png-t w 48
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-48.png-t w 32
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-32.png-t w 24
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-24.png-t w 22
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-22.png-t making
> octave.desktop from ../../../3.9.1+/etc/icons/octave.desktop.in
> /usr/bin/sed < ../../../3.9.1+/etc/icons/octave.desktop.in >
octave.desktop-t \
>    -e "s|%OCTAVE_IMAGEDIR%|/usr/local/share/octave/3.9.1+/imagelib|" \
>    -e "s|%OCTAVE_PREFIX%|/usr/local|"
> mv octave-logo-64.png-t octave-logo-64.png mv octave-logo-128.png-t
octave-
> logo-128.png mv octave-logo-512.png-t octave-logo-512.png w 16
> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-16.png-t mv
octave-
> logo-24.png-t octave-logo-24.png mv octave-logo-48.png-t
octave-logo-48.png
> mv octave-logo-22.png-t octave-logo-22.png mv octave.desktop-t
> octave.desktop mv octave-logo-256.png-t octave-logo-256.png mv octave-
> logo-16.png-t octave-logo-16.png mv octave-logo-32.png-t
octave-logo-32.png

> icotool --create --raw octave-logo-256.png octave-logo-48.png octave-logo-
> 32.png octave-logo-16.png > octave-logo.ico-t
> octave-logo-48.png: not a png file
> Makefile:2370: recipe for target 'octave-logo.ico' failed
> make[2]: *** [octave-logo.ico] Error 1
> make[2]: Leaving directory '/home/philip/devel/octdev/oct391+/etc/icons'
> Makefile:2122: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory '/home/philip/devel/octdev/oct391+'
> Makefile:1985: recipe for target 'all' failed
> make: *** [all] Error 2
>
>
> Checking things out, I find that all .png logos in the
<build_dir>/etc/icons subdir

> have the same contents:
>
> [philip@deskprn icons]$ ls -l
> total 112
> -rw-rw-r-- 1 philip philip 71251 Feb 18 21:45 Makefile
> -rw-rw-r-- 1 philip philip   282 Feb 18 21:55 octave.desktop
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-128.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-16.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-22.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-24.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-256.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-32.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-48.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-512.png
> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-64.png
> -rw-rw-r-- 1 philip philip     0 Feb 18 21:59 octave-logo.ico-t
> [philip@deskprn icons]$ cat octave-logo-16.png
>   21:55:47 up 15 min,  3 users,  load average: 5.12, 7.38, 4.56
> USER     TTY        LOGIN@   IDLE   JCPU   PCPU WHAT
> [philip@deskprn icons]$
>
>
> Octave itself is built fine; ./run-octave works.
>
> Philip
>
>

I saw the same thing on my fedora box - it was missing rsvg-convert -
installing libsvg2-tools fixed the problem, but even though configure had
detected I didn't have that tool, it was still trying to generate the .png
files.
Perhaps related - I already the icotool installed.




Reply | Threaded
Open this post in threaded view
|

Re: Error building logos

Mike Miller
On Wed, Feb 18, 2015 at 4:19 PM, JohnD wrote:

>
>>
>> Message: 5
>> Date: Wed, 18 Feb 2015 22:11:13 +0100
>> From: Philip Nienhuis <[hidden email]>
>> To: [hidden email]
>> Subject: Error building logos
>> Message-ID: <[hidden email]>
>> Content-Type: text/plain; charset=UTF-8; format=flowed
>>
>> Magei-4 Linux,
>> $ hg -v summary
>> parent: 19748:3fc946d5e91f tip
>>   make ginput work for all toolkits again (bug #41977)
>>
>> Last part of build log:
>>
>> :
>> make[2]: Entering directory '/home/philip/devel/octdev/oct391+/etc/icons'
>> w 512 ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-512.png-t w
> 256
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-256.png-t w 128
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-128.png-t w 64
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-64.png-t w 48
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-48.png-t w 32
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-32.png-t w 24
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-24.png-t w 22
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-22.png-t making
>> octave.desktop from ../../../3.9.1+/etc/icons/octave.desktop.in
>> /usr/bin/sed < ../../../3.9.1+/etc/icons/octave.desktop.in >
> octave.desktop-t \
>>    -e "s|%OCTAVE_IMAGEDIR%|/usr/local/share/octave/3.9.1+/imagelib|" \
>>    -e "s|%OCTAVE_PREFIX%|/usr/local|"
>> mv octave-logo-64.png-t octave-logo-64.png mv octave-logo-128.png-t
> octave-
>> logo-128.png mv octave-logo-512.png-t octave-logo-512.png w 16
>> ../../../3.9.1+/etc/icons/octave-logo.svg > octave-logo-16.png-t mv
> octave-
>> logo-24.png-t octave-logo-24.png mv octave-logo-48.png-t
> octave-logo-48.png
>> mv octave-logo-22.png-t octave-logo-22.png mv octave.desktop-t
>> octave.desktop mv octave-logo-256.png-t octave-logo-256.png mv octave-
>> logo-16.png-t octave-logo-16.png mv octave-logo-32.png-t
> octave-logo-32.png
>> icotool --create --raw octave-logo-256.png octave-logo-48.png octave-logo-
>> 32.png octave-logo-16.png > octave-logo.ico-t
>> octave-logo-48.png: not a png file
>> Makefile:2370: recipe for target 'octave-logo.ico' failed
>> make[2]: *** [octave-logo.ico] Error 1
>> make[2]: Leaving directory '/home/philip/devel/octdev/oct391+/etc/icons'
>> Makefile:2122: recipe for target 'all-recursive' failed
>> make[1]: *** [all-recursive] Error 1
>> make[1]: Leaving directory '/home/philip/devel/octdev/oct391+'
>> Makefile:1985: recipe for target 'all' failed
>> make: *** [all] Error 2
>>
>>
>> Checking things out, I find that all .png logos in the
> <build_dir>/etc/icons subdir
>> have the same contents:
>>
>> [philip@deskprn icons]$ ls -l
>> total 112
>> -rw-rw-r-- 1 philip philip 71251 Feb 18 21:45 Makefile
>> -rw-rw-r-- 1 philip philip   282 Feb 18 21:55 octave.desktop
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-128.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-16.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-22.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-24.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-256.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-32.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-48.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-512.png
>> -rw-rw-r-- 1 philip philip   116 Feb 18 21:55 octave-logo-64.png
>> -rw-rw-r-- 1 philip philip     0 Feb 18 21:59 octave-logo.ico-t
>> [philip@deskprn icons]$ cat octave-logo-16.png
>>   21:55:47 up 15 min,  3 users,  load average: 5.12, 7.38, 4.56
>> USER     TTY        LOGIN@   IDLE   JCPU   PCPU WHAT
>> [philip@deskprn icons]$
>>
>>
>> Octave itself is built fine; ./run-octave works.
>>
>> Philip
>>
>>
>
> I saw the same thing on my fedora box - it was missing rsvg-convert -
> installing libsvg2-tools fixed the problem, but even though configure had
> detected I didn't have that tool, it was still trying to generate the .png
> files.
> Perhaps related - I already the icotool installed.

Yeah, could use some work in the case where you are building from hg
and don't have the tools installed. I'll take a look at that. But
install the rsvg-convert program as John says and you should be fine.

--
mike

Reply | Threaded
Open this post in threaded view
|

Re: Error building logos

John W. Eaton
Administrator
On 02/18/2015 05:35 PM, Mike Miller wrote:

>> I saw the same thing on my fedora box - it was missing rsvg-convert -
>> installing libsvg2-tools fixed the problem, but even though configure had
>> detected I didn't have that tool, it was still trying to generate the .png
>> files.
>> Perhaps related - I already the icotool installed.
>
> Yeah, could use some work in the case where you are building from hg
> and don't have the tools installed. I'll take a look at that. But
> install the rsvg-convert program as John says and you should be fine.

I ended up with a zero sized octave-logo.ico file because $(ICOTOOL)
wasn't defined, so it tried to run the command "create" and ignored the
error about that command not being available, and then it went ahead and
did the "mv file-t file" command.  I was confused at first, but then
realized that if $(ICOTOLL) is undefined, the command $(ICOTOOL)
--create ... becomes --create ... and the leading -- is just telling
make to ignore any errors from the command.

We could use the "missing" function for these commands.  Something like:

   ICOTOOL = $(SHELL) $(top_srcdir)/build-aux/missing @ICOTOOL@

in build-aux/common.mk should do it?

Also, I don't see a substitution target for ICOTOOL (i.e., @ICOTOOL@)
anywhere in the sources.  Am I missing something?

Similarly, the .png files were all the output of the "w" command for me,
because I didn't have the rsvg convert tool.

jwe


Reply | Threaded
Open this post in threaded view
|

Re: Error building logos

Mike Miller
On Wed, Feb 18, 2015 at 18:00:05 -0500, John W. Eaton wrote:
> I ended up with a zero sized octave-logo.ico file because $(ICOTOOL) wasn't
> defined, so it tried to run the command "create" and ignored the error about
> that command not being available, and then it went ahead and did the "mv
> file-t file" command.  I was confused at first, but then realized that if
> $(ICOTOLL) is undefined, the command $(ICOTOOL) --create ... becomes
> --create ... and the leading -- is just telling make to ignore any errors
> from the command.

Yes, those commands shouldn't be empty.

> We could use the "missing" function for these commands.  Something like:
>
>   ICOTOOL = $(SHELL) $(top_srcdir)/build-aux/missing @ICOTOOL@
>
> in build-aux/common.mk should do it?

Done, slightly differently,

  http://hg.savannah.gnu.org/hgweb/octave/rev/bc2a8db22831

> Also, I don't see a substitution target for ICOTOOL (i.e., @ICOTOOL@)
> anywhere in the sources.  Am I missing something?

I don't know that it needs to be stated, my understanding is that all
AC_SUBST names show up in every Makefile automatically (no need to
declare "FOO = @FOO@" for example).

> Similarly, the .png files were all the output of the "w" command for me,
> because I didn't have the rsvg convert tool.

So now make reports the missing tools and errors appropriately when it
hits etc/icons. If this becomes annoying, we can change it so make just
skips building the icons if the tools aren't found (like doc is skipped
if you don't have makeinfo).

--
mike