Fwd: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++

Carlo de Falco-2
Hi,

Begin forwarded message:

> From: Simon Josefsson <[hidden email]>
> Date: 2 August 2012 23:22:26 GMT+02:00
> To: Carlo de Falco <[hidden email]>
> Cc: [hidden email]
> Subject: Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++
>
> Carlo de Falco <[hidden email]> writes:
>
>> Hi,
>>
>> In order to use base64.h in GNU Octave we had to wrap the #include
>> <"base64.h"> in extern "C" scope. We believe it would have been better
>> if this had been done upstream. Would it be possible to apply the
>> patch below to lib/base64.h ?
>
> Hi.  I agree.  Fixed in gnulib git master.
>
> Thanks,
> /Simon

Is it OK if I update the gnulib subrepo to get the new base64.h and push the change to mercurial?
c.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++

Jordi Gutiérrez Hermoso-2
On 2 August 2012 23:40, Carlo de Falco <[hidden email]> wrote:


>> From: Simon Josefsson <[hidden email]>
>> Date: 2 August 2012 23:22:26 GMT+02:00
>> To: Carlo de Falco <[hidden email]>
>> Cc: [hidden email]
>> Subject: Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++
>>
>> Carlo de Falco <[hidden email]> writes:
>>
>>> Hi,
>>>
>>> In order to use base64.h in GNU Octave we had to wrap the #include
>>> <"base64.h"> in extern "C" scope. We believe it would have been better
>>> if this had been done upstream. Would it be possible to apply the
>>> patch below to lib/base64.h ?
>>
>> Hi.  I agree.  Fixed in gnulib git master.
>>
>> Thanks,
>> /Simon
>
> Is it OK if I update the gnulib subrepo to get the new base64.h and push the change to mercurial?

Sure, it's ok to be fairly cavalier about updating the gnulib subrepo,
but just don't do it for no reason. Since there is reason to do so, I
think it should be upated.

- Jordi G. H.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++

John W. Eaton
Administrator
On  3-Aug-2012, Jordi Gutiérrez Hermoso wrote:

| Sure, it's ok to be fairly cavalier about updating the gnulib subrepo,
| but just don't do it for no reason. Since there is reason to do so, I
| think it should be upated.

I agree it should be OK now to update gnulib.

jwe
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] lib/base64.h: wrap declarations in extern "C" scope when included from C++

Carlo de Falco-2

On 3 Aug 2012, at 16:42, John W. Eaton wrote:

> On  3-Aug-2012, Jordi Gutiérrez Hermoso wrote:
>
> | Sure, it's ok to be fairly cavalier about updating the gnulib subrepo,
> | but just don't do it for no reason. Since there is reason to do so, I
> | think it should be upated.
>
> I agree it should be OK now to update gnulib.
>
> jwe

I had to push the update twice as I was too fast to pull the first time
and got a version not including the patch to base64, sorry for the duplicate
changeset.

c.