Griddata compatibility patch with bugfix?

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Griddata compatibility patch with bugfix?

nrjank
quick question - over the weekend I ran into a matlab compatibility issue with griddata and in making a patch saw a bug in griddata3. The patch I submitted addresses both. 

Would it be preferred if I separated them? One doesn't exactly depend on the other. The bug fix is simple and independent. The compat patch calls  griddata3, so if it were pushed without the bugfix, griddata would then exhibit the same bug as griddata3. Given that, I lumped them into the single patch attached to the tracker.

If separate is preferred, i can update it and submit two.

Reply | Threaded
Open this post in threaded view
|

Re: Griddata compatibility patch with bugfix?

Rik-4
On 12/02/2019 09:00 AM, [hidden email] wrote:
Subject:
Griddata compatibility patch with bugfix?
From:
Nicholas Jankowski [hidden email]
Date:
12/01/2019 04:18 PM
To:
octave-maintainers [hidden email]
List-Post:
[hidden email]
Precedence:
list
MIME-Version:
1.0
Message-ID:
[hidden email]
Content-Type:
multipart/alternative; boundary="0000000000007e361d0598ad85ad"
Message:
2

quick question - over the weekend I ran into a matlab compatibility issue with griddata and in making a patch saw a bug in griddata3. The patch I submitted addresses both. 

Would it be preferred if I separated them? One doesn't exactly depend on the other. The bug fix is simple and independent. The compat patch calls  griddata3, so if it were pushed without the bugfix, griddata would then exhibit the same bug as griddata3. Given that, I lumped them into the single patch attached to the tracker.

If separate is preferred, i can update it and submit two.


Generally it is best to have one bug per problem, so if you could separate them that would be good.

Regarding griddata, griddata3 and griddatan, Matlab originally had 2-D, 3-D, and N-D implementations of several functions such as delaunay (delaunay, delaunay3, delaunayn).  They have have been moving towards a combined 2-D/3-D function and an N-D implementation and deprecating the 3-D specific version.  Matlab is a moving target, but we can probably follow this and deprecate griddata3 and move the functionality in to griddata.m for the next release.

--Rik