Image package, cp2tform documentation

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Image package, cp2tform documentation

vrozos
The documentation of cp2tform
(https://octave.sourceforge.io/image/function/cp2tform.html) has some
errors.

In the affine transformation the following lines

in_cp = [out_cp ones(rows (out_cp,1))] * Tinv

out_cp = [in_cp ones(rows (in_cp,1))] * T

have two errors: i) 'rows' function takes only one argument, and ii)
'ones' function takes two arguments. Furthermore, it would be more clear
to replace Tinv and T with the full path. That is:

in_cp =  [out_cp ones(rows (out_cp) ,1)] * T.tdata.Tinv

out_cp=  [in_cp ones(rows (in_cp) ,1)] * T.tdata.T

The same problems exist in the projective transformation.

Also, Tinv should be replaced with the full path (i.e. T.tdata.Tinv) in
the polynomial transformation too.

Regards

Evangelos Rozos


Reply | Threaded
Open this post in threaded view
|

Re: Image package, cp2tform documentation

Andreas Weber-6
Am 24.05.19 um 08:37 schrieb Evangelos Rozos:
> The documentation of cp2tform
> (https://octave.sourceforge.io/image/function/cp2tform.html) has some
> errors.

Thank you very much. Can you create a patch and add it to the patch
tracker on savannah? Or file a bug and attach the patch so it doesn't
get lost.

Thank you very much, Andy


Reply | Threaded
Open this post in threaded view
|

Re: Image package, cp2tform documentation

Hartmut