Make Check Failures

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Make Check Failures

Thomas D. Dean-2
Just updated source, make, and make check shows 10 Failures.

Tom Dean

 > grep '!!!!! test failed' test/fntests.log -B5 -A5

 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/lookup.cc-tst
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/lsode.cc-tst
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/lu.cc-tst
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/mappers.cc-tst
***** assert (isalnum(["??8Aa?"; "(U?? ;"]), logical ([1 1 1 1 1 0; 0 1
1 1 0 0]));
!!!!! test failed
ASSERT errors for:  assert (isalnum (["??8Aa?"; "(U?? ;"]),logical ([1,
1, 1, 1, 1, 0; 0, 1, 1, 1, 0, 0]))

   Location  |  Observed  |  Expected  |  Reason
    (1,1)          0            1         Abs err 1 exceeds tol 0 by 1
    (1,2)          0            1         Abs err 1 exceeds tol 0 by 1
--
shared variables   scalar structure containing the fields:

     rt2 = 1.4142
     rt3 = 1.7321
***** assert (isalpha("??8Aa(U?? ;"), logical ([1 1 0 1 1 0 1 1 1 0 0]));
!!!!! test failed
ASSERT errors for:  assert (isalpha ("??8Aa(U?? ;"),logical ([1, 1, 0,
1, 1, 0, 1, 1, 1, 0, 0]))

   Location  |  Observed  |  Expected  |  Reason
     (1)           0            1         Abs err 1 exceeds tol 0 by 1
     (2)           0            1         Abs err 1 exceeds tol 0 by 1
--
shared variables   scalar structure containing the fields:

     rt2 = 1.4142
     rt3 = 1.7321
***** assert (islower("??8Aa(U?? ;"), logical ([0 0 0 0 1 0 0 1 1 0 0]));
!!!!! test failed
ASSERT errors for:  assert (islower ("??8Aa(U?? ;"),logical ([0, 0, 0,
0, 1, 0, 0, 1, 1, 0, 0]))

   Location  |  Observed  |  Expected  |  Reason
     (8)           0            1         Abs err 1 exceeds tol 0 by 1
     (9)           0            1         Abs err 1 exceeds tol 0 by 1
shared variables   scalar structure containing the fields:

     rt2 = 1.4142
     rt3 = 1.7321
***** assert (ispunct("??8Aa(U?? ;"), logical ([0 0 0 0 0 1 0 0 0 0 1]));
!!!!! test failed
ASSERT errors for:  assert (ispunct ("??8Aa(U?? ;"),logical ([0, 0, 0,
0, 0, 1, 0, 0, 0, 0, 1]))

   Location  |  Observed  |  Expected  |  Reason
     (1)           1            0         Abs err 1 exceeds tol 0 by 1
     (2)           1            0         Abs err 1 exceeds tol 0 by 1
--
shared variables   scalar structure containing the fields:

     rt2 = 1.4142
     rt3 = 1.7321
***** assert (isupper("??8Aa(U?? ;"), logical ([1 1 0 1 0 0 1 0 0 0 0]));
!!!!! test failed
ASSERT errors for:  assert (isupper ("??8Aa(U?? ;"),logical ([1, 1, 0,
1, 0, 0, 1, 0, 0, 0, 0]))

   Location  |  Observed  |  Expected  |  Reason
     (1)           0            1         Abs err 1 exceeds tol 0 by 1
     (2)           0            1         Abs err 1 exceeds tol 0 by 1
shared variables   scalar structure containing the fields:

     rt2 = 1.4142
     rt3 = 1.7321
***** assert (toupper (["ABC??????SS"; "abc????????"]), ["ABC??????SS";
"ABC??????SS"])
!!!!! test failed
ASSERT errors for:  assert (toupper (["ABC??????SS";
"abc????????"]),["ABC??????SS"; "ABC??????SS"])

   Location  |  Observed  |  Expected  |  Reason
      []      AABBCC????????????S?S?  AABBCC????????????SSSS    Strings
don't match
shared variables   scalar structure containing the fields:
--
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/spparms.cc-tst
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/sqrtm.cc-tst
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/strfind.cc-tst
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/build/libinterp/corefcn/strfns.cc-tst
***** assert (unicode_idx (["a??ou"; "?????"]), [1 2 2 3 4; 5 5 6 6 6]);
!!!!! test failed
ASSERT errors for:  assert (unicode_idx (["a??ou"; "?????"]),[1, 2, 2,
3, 4; 5, 5, 6, 6, 6])

   Location  |  Observed  |  Expected  |  Reason
    (2,1)          6            5         Abs err 1 exceeds tol 0 by 1
    (2,2)          7            5         Abs err 2 exceeds tol 0 by 2
--
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/scripts/strings/strtrunc.m
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/scripts/strings/substr.m
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/scripts/strings/unicode2native.m
***** testif HAVE_ICONV
  assert (unicode2native ("??????????????", "ISO-8859-5"), uint8 (164:170));
!!!!! test failed
ASSERT errors for:  assert (unicode2native ("??????????????",
"ISO-8859-5"),uint8 (164:170))

   Location  |  Observed  |  Expected  |  Reason
      .         O(1x14)       E(1x7)      Dimensions don't match
***** testif HAVE_ICONV
  assert (unicode2native (["??????" 0 "????????"], "ISO-8859-5"),
          uint8 ([164:166 0 167:170]));
!!!!! test failed
ASSERT errors for:  assert (unicode2native (["??????", 0, "????????"],
"ISO-8859-5"),uint8 ([164:166, 0, 167:170]))

   Location  |  Observed  |  Expected  |  Reason
      .         O(1x15)       E(1x8)      Dimensions don't match
 >>>>> processing
/home/tomdean/Math/Octave/octave-code/scripts/strings/untabify.m
--
    fclose (fid3);
    assert (read_text, "a??uA??U");
  unwind_protect_cleanup
    unlink (temp_file);
  end_unwind_protect
!!!!! test failed
ASSERT errors for:  assert (codepage,"utf-8")

   Location  |  Observed  |  Expected  |  Reason
      []      ansi_x3.4-1968    utf-8       Strings don't match
 >>>>> processing /home/tomdean/Math/Octave/octave-code/test/jit.tst


Reply | Threaded
Open this post in threaded view
|

Re: Make Check Failures

Mike Miller-4
On Thu, Feb 20, 2020 at 12:40:35 -0800, Thomas D. Dean wrote:
> Just updated source, make, and make check shows 10 Failures.

It looks like you are running in a non-Unicode locale, try fixing that.

--
mike



signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Make Check Failures

John W. Eaton
Administrator
In reply to this post by Thomas D. Dean-2
On 2/20/20 3:40 PM, Thomas D. Dean wrote:
> Just updated source, make, and make check shows 10 Failures.

I see the same failures if I run make check with LANG=C in the
environment but no failures if I use LANG=en_US.UTF-8.  I don't think
tests should fail based on locale settings, but I'm not sure what the
right solution is either.  Maybe it would be better to discuss this on
the maintainers list or file a bug report about it?

jwe


Reply | Threaded
Open this post in threaded view
|

Re: Make Check Failures

mmuetzel
Am 20. Februar 2020 um 22:36 Uhr schrieb "John W. Eaton":
> On 2/20/20 3:40 PM, Thomas D. Dean wrote:
> > Just updated source, make, and make check shows 10 Failures.
>
> I see the same failures if I run make check with LANG=C in the
> environment but no failures if I use LANG=en_US.UTF-8.  I don't think
> tests should fail based on locale settings, but I'm not sure what the
> right solution is either.  Maybe it would be better to discuss this on
> the maintainers list or file a bug report about it?

This is probably due to this change:
https://hg.savannah.gnu.org/hgweb/octave/rev/118606de9359

I'll work on a fix for this.

Markus


Reply | Threaded
Open this post in threaded view
|

Re: Make Check Failures

mmuetzel
Am 21. Februar 2020 um 07:38 Uhr schrieb "Markus M├╝tzel":

> Am 20. Februar 2020 um 22:36 Uhr schrieb "John W. Eaton":
> > On 2/20/20 3:40 PM, Thomas D. Dean wrote:
> > > Just updated source, make, and make check shows 10 Failures.
> >
> > I see the same failures if I run make check with LANG=C in the
> > environment but no failures if I use LANG=en_US.UTF-8.  I don't think
> > tests should fail based on locale settings, but I'm not sure what the
> > right solution is either.  Maybe it would be better to discuss this on
> > the maintainers list or file a bug report about it?
>
> This is probably due to this change:
> https://hg.savannah.gnu.org/hgweb/octave/rev/118606de9359
>
> I'll work on a fix for this.

The following changeset should fix the issue by overwriting the locale for the test suite:
http://hg.savannah.gnu.org/hgweb/octave/rev/818bd5b42651

There seems to be an additional issue:
If LANG=C, __locale_charset__ returns "ANSI_X3.4-1968". Conversely, Qt's QTextCodec::codecForLocale returns "UTF-8". I didn't expect to see different results.
This is probably because we override CodecForLocale in octave-qobject.cc (base_qobject) on non-Windows systems. I'm not sure why this is done, or why it is OS specific.
But since this is the case, we cannot rely on QTextCodec::codecForLocale to return the codec for the locale charset.
I'll try and find the places where QTextCodec::codecForLocale should be replaced by octave_locale_charset_wrapper.

If you don't work with non-ASCII characters, everything is fine already. If you do, there are a few possible solutions: Set a UTF-8 locale for your system. Add '__mfile_encoding__ ("UTF-8")' to your .octaverc. Or if you are using the GUI, select "UTF-8" in the "Text encoding used for loading and saving" drop down list in the editor preferences.