OCTAVE_DEPRECATED and cset 27594

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

OCTAVE_DEPRECATED and cset 27594

Rik-4
jwe,

I was reviewing this changeset

changeset:   27594:e091e09d26f0
user:        John W. Eaton <[hidden email]>
date:        Thu Oct 31 00:51:45 2019 -0400
summary:     restore some symbol table functions for backward compatibility

which introduces many lines in symtab.h like this one

    // OCTAVE_DEPRECATED (V, "use 'interpreter::at_top_level' instead")
    bool at_top_level (void);

Should the deprecation warning be removed since it is not used?  Or, if it
is going to be used in the future, should we put in an Arabic numeral for
the version number rather than a Roman one?  The rest of the
OCTAVE_DEPRECATED instances use 5, 6, or 7 rather than "V".

--Rik

Reply | Threaded
Open this post in threaded view
|

Re: OCTAVE_DEPRECATED and cset 27594

John W. Eaton
Administrator
On 12/13/19 8:51 PM, Rik wrote:

> jwe,
>
> I was reviewing this changeset
>
> changeset:   27594:e091e09d26f0
> user:        John W. Eaton <[hidden email]>
> date:        Thu Oct 31 00:51:45 2019 -0400
> summary:     restore some symbol table functions for backward compatibility
>
> which introduces many lines in symtab.h like this one
>
>      // OCTAVE_DEPRECATED (V, "use 'interpreter::at_top_level' instead")
>      bool at_top_level (void);
>
> Should the deprecation warning be removed since it is not used?  Or, if it
> is going to be used in the future, should we put in an Arabic numeral for
> the version number rather than a Roman one?  The rest of the
> OCTAVE_DEPRECATED instances use 5, 6, or 7 rather than "V".

Thanks for letting me know.  I pushed a change to fix it:

   http://hg.savannah.gnu.org/hgweb/octave/rev/0948ba09abbd

jwe