[OctDev] proposed addpath patch

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[OctDev] proposed addpath patch

HALL, BENJAMIN            PW
In octave-2.9.3, the addpath command generates warning messages when used
with double-quoted strings as input, e.g., addpath("/home/me/mydir")

The following proposed patch disables the warnings during the execution of
the addpath function.  I don't think this should cause any problems
(unexpected results) for end users based on the earlier discussions
(http://www.octave.org/octave-lists/archive/octave-maintainers.2005/msg00280
.html)

Does this seem reasonable?


*** addpath_old.m 2005-09-08 09:13:14.000000000 -0400
--- addpath_new.m 2005-09-08 09:27:18.000000000 -0400
***************
*** 49,54 ****
--- 49,59 ----
      path = LOADPATH;
    end
 
+   try   wrn_state = warn_string_concat;
+   catch wrn_state = 0;
+   end
+   warn_string_concat = 0;
+
    dir = '';
    if length(varargin) > 0
      append = 0;
***************
*** 106,111 ****
--- 111,118 ----
      LOADPATH = path;
    end
 
+   warn_string_concat = wrn_state;
+
  %!assert(addpath('','hello'),'hello');
  %!assert(addpath('','hello','world'),'hello:world')
  %!assert(addpath(':','hello'),'hello:');


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Octave-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/octave-dev
Reply | Threaded
Open this post in threaded view
|

Re: [OctDev] proposed addpath patch

Stéfan van der Walt
Arn't the string concatenation warnings disabled by default in CVS?

Regards
Stéfan

On Thu, Sep 08, 2005 at 10:31:27AM -0400, Hall, Benjamin wrote:
> In octave-2.9.3, the addpath command generates warning messages when used
> with double-quoted strings as input, e.g., addpath("/home/me/mydir")


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Octave-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/octave-dev