[Patch] Create scripts/ directory for profiler files

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] Create scripts/ directory for profiler files

Daniel Kraft
Hi!

I've created a patch to move the profiler files to their own scripts/
directory.  This cleans up scripts/general, and is meant in preparation
for more files to support profiler export as HTML.

The patch is also in Savannah:

  https://savannah.gnu.org/patch/index.php?8991

Yours,
Daniel

--
http://www.domob.eu/
OpenPGP: 1142 850E 6DFF 65BA 63D6  88A8 B249 2AC4 A733 0737
Namecoin: id/domob -> https://nameid.org/?name=domob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri

patch-move.diff (31K) Download Attachment
signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Create scripts/ directory for profiler files

Daniel Kraft
Hi!

On 2016-05-05 11:38, Daniel Kraft wrote:
> I've created a patch to move the profiler files to their own scripts/
> directory.  This cleans up scripts/general, and is meant in preparation
> for more files to support profiler export as HTML.

Here's the second part, which actually implements profexport.

This is mainly the file from
https://lists.gnu.org/archive/html/octave-maintainers/2015-11/msg00052.html,
but I've split out the HTML templates and added a (mostly empty) CSS file.

The patch is also at Savannah:

https://savannah.gnu.org/patch/index.php?8997

Yours,
Daniel

--
http://www.domob.eu/
OpenPGP: 1142 850E 6DFF 65BA 63D6  88A8 B249 2AC4 A733 0737
Namecoin: id/domob -> https://nameid.org/?name=domob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri

patch-profexport.diff (15K) Download Attachment
signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

PING: [Patch] Create scripts/ directory for profiler files

Daniel Kraft
See below -- friendly ping on the two related patches:

  https://savannah.gnu.org/patch/index.php?8991
  https://savannah.gnu.org/patch/index.php?8997

Thanks!

Daniel

On 2016-05-09 20:31, Daniel Kraft wrote:

> Hi!
>
> On 2016-05-05 11:38, Daniel Kraft wrote:
>> I've created a patch to move the profiler files to their own scripts/
>> directory.  This cleans up scripts/general, and is meant in preparation
>> for more files to support profiler export as HTML.
>
> Here's the second part, which actually implements profexport.
>
> This is mainly the file from
> https://lists.gnu.org/archive/html/octave-maintainers/2015-11/msg00052.html,
> but I've split out the HTML templates and added a (mostly empty) CSS file.
>
> The patch is also at Savannah:
>
> https://savannah.gnu.org/patch/index.php?8997
>
> Yours,
> Daniel
>

--
http://www.domob.eu/
OpenPGP: 1142 850E 6DFF 65BA 63D6  88A8 B249 2AC4 A733 0737
Namecoin: id/domob -> https://nameid.org/?name=domob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri


signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: PING: [Patch] Create scripts/ directory for profiler files

Jordi Gutiérrez Hermoso-2
On Mon, 2016-05-16 at 10:52 +0200, Daniel Kraft wrote:
> See below -- friendly ping on the two related patches:
>
>   https://savannah.gnu.org/patch/index.php?8991
>   https://savannah.gnu.org/patch/index.php?8997
>
> Thanks!

You were our first GSoC student, and quite a successful one at that.
Except for minor stylistic issues (e.g. Python-like __foo__ not C-like
__foo for private names), your patches look good.

Is there a reason why you don't have push access to Savannah? Do you
want it?

- Jordi G. H.



Reply | Threaded
Open this post in threaded view
|

Re: PING: [Patch] Create scripts/ directory for profiler files

Daniel Kraft
Hi!

On 2016-05-17 01:18, Jordi Gutiérrez Hermoso wrote:
> You were our first GSoC student, and quite a successful one at that.
> Except for minor stylistic issues (e.g. Python-like __foo__ not C-like
> __foo for private names), your patches look good.
>
> Is there a reason why you don't have push access to Savannah? Do you
> want it?

I'm not aware of any particular reason, we just never did it.  I'm
totally happy to get it, if you trust me enough. ;)

Is there then no further code review involved?

Yours,
Daniel

--
http://www.domob.eu/
OpenPGP: 1142 850E 6DFF 65BA 63D6  88A8 B249 2AC4 A733 0737
Namecoin: id/domob -> https://nameid.org/?name=domob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri


signature.asc (836 bytes) Download Attachment