Plans for Octave 6.1 release

classic Classic list List threaded Threaded
50 messages Options
123
Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

John W. Eaton
Administrator
On 1/14/20 8:31 AM, Kai Torben Ohlhus wrote:

> On 12/12/19 11:43 PM, John W. Eaton wrote:
>> On 12/12/19 8:38 AM, Kai Torben Ohlhus wrote:
>>
>>> By "release candidate" you mean 5.1.90 before 5.2.0?
>>
>> Yes, I think it makes sense to do that even for a stable bug-fixing
>> release as a final check that "make dist" and the Windows builds work as
>> expected.
>>
>> jwe
>>
>
>
> jwe and all,
>
> currently I am uploading fresh builds of the stable branch 5.1.90,
> including all 3x3 flavors of MXE and build logs to
>
>     https://octave.space/stable_56dd7419d7aa/
>
> This might take some time, but the most important ones
>
>     octave-5.1.90-w64-*
>
> are already there.  Was it possible to publish that release on
>
>     https://alpha.gnu.org/gnu/octave/  ?
>
> I would be happy to announce a final regression test period from January
> 15 to 31 followed by a minor Octave 5.2.0 release, if no bad regressions
> were discovered in that time.  Then all focus goes back to Octave 6.
>
> A final note about the year 2020 change:  Basically, on Octave 5.2.0
> there was no development in 2020.  Thus we might skip touching all
> headers and just adapt the date in the most important places indicating
> the year of the 5.2.0 release.

It looks like in the past we only uploaded the w64 build to
alpha.gnu.org, not the w32 or w64-64 builds.  Do you think all are
needed there?

For 5.1.0 on ftp.gnu.org we did upload all w32, w64,
and w64-64 in installer exe, zip, and 7z formats.

jwe



Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/15/20 12:01 AM, John W. Eaton wrote:

> On 1/14/20 8:31 AM, Kai Torben Ohlhus wrote:
>> On 12/12/19 11:43 PM, John W. Eaton wrote:
>>> On 12/12/19 8:38 AM, Kai Torben Ohlhus wrote:
>>>
>>>> By "release candidate" you mean 5.1.90 before 5.2.0?
>>>
>>> Yes, I think it makes sense to do that even for a stable bug-fixing
>>> release as a final check that "make dist" and the Windows builds work as
>>> expected.
>>>
>>> jwe
>>>
>>
>>
>> jwe and all,
>>
>> currently I am uploading fresh builds of the stable branch 5.1.90,
>> including all 3x3 flavors of MXE and build logs to
>>
>>     https://octave.space/stable_56dd7419d7aa/
>>
>> This might take some time, but the most important ones
>>
>>     octave-5.1.90-w64-*
>>
>> are already there.  Was it possible to publish that release on
>>
>>     https://alpha.gnu.org/gnu/octave/  ?
>>
>> I would be happy to announce a final regression test period from January
>> 15 to 31 followed by a minor Octave 5.2.0 release, if no bad regressions
>> were discovered in that time.  Then all focus goes back to Octave 6.
>>
>> A final note about the year 2020 change:  Basically, on Octave 5.2.0
>> there was no development in 2020.  Thus we might skip touching all
>> headers and just adapt the date in the most important places indicating
>> the year of the 5.2.0 release.
>
> It looks like in the past we only uploaded the w64 build to
> alpha.gnu.org, not the w32 or w64-64 builds.  Do you think all are
> needed there?
>
> For 5.1.0 on ftp.gnu.org we did upload all w32, w64,
> and w64-64 in installer exe, zip, and 7z formats.
>
> jwe
>
>


Maybe for alpha the w64 version is enough.  For the remaining versions,
one can consult https://octave.space/stable_56dd7419d7aa/.

I think especially the source tarball should be located at this more
official location.

Kai

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

mmuetzel
Am 14. Januar 2020 um 16:22 Uhr schrieb "Kai Torben Ohlhus":

> An: "John W. Eaton" <[hidden email]>
> Cc: Octave-Maintainers <[hidden email]>
> Betreff: Re: Octave 5.2.0 release
>
> On 1/15/20 12:01 AM, John W. Eaton wrote:
> > On 1/14/20 8:31 AM, Kai Torben Ohlhus wrote:
> >> On 12/12/19 11:43 PM, John W. Eaton wrote:
> >>> On 12/12/19 8:38 AM, Kai Torben Ohlhus wrote:
> >>>
> >>>> By "release candidate" you mean 5.1.90 before 5.2.0?
> >>>
> >>> Yes, I think it makes sense to do that even for a stable bug-fixing
> >>> release as a final check that "make dist" and the Windows builds work as
> >>> expected.
> >>>
> >>> jwe
> >>>
> >>
> >>
> >> jwe and all,
> >>
> >> currently I am uploading fresh builds of the stable branch 5.1.90,
> >> including all 3x3 flavors of MXE and build logs to
> >>
> >>     https://octave.space/stable_56dd7419d7aa/
> >>
> >> This might take some time, but the most important ones
> >>
> >>     octave-5.1.90-w64-*
> >>
> >> are already there.  Was it possible to publish that release on
> >>
> >>     https://alpha.gnu.org/gnu/octave/  ?
> >>
> >> I would be happy to announce a final regression test period from January
> >> 15 to 31 followed by a minor Octave 5.2.0 release, if no bad regressions
> >> were discovered in that time.  Then all focus goes back to Octave 6.
> >>
> >> A final note about the year 2020 change:  Basically, on Octave 5.2.0
> >> there was no development in 2020.  Thus we might skip touching all
> >> headers and just adapt the date in the most important places indicating
> >> the year of the 5.2.0 release.
> >
> > It looks like in the past we only uploaded the w64 build to
> > alpha.gnu.org, not the w32 or w64-64 builds.  Do you think all are
> > needed there?
> >
> > For 5.1.0 on ftp.gnu.org we did upload all w32, w64,
> > and w64-64 in installer exe, zip, and 7z formats.
> >
> > jwe
> >
> >
>
>
> Maybe for alpha the w64 version is enough.  For the remaining versions,
> one can consult https://octave.space/stable_56dd7419d7aa/.
>
> I think especially the source tarball should be located at this more
> official location.
Thanks for providing the release candidates. Very much appreciated.

I installed with the w64 installer on Windows 10 and tried to run the test suite. Octave closed unexpectedly with the following at the tail of fntests.log:
>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\single-index.tst
>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\slice.tst
>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\sparse.tst

This might be something we already fixed on default (hg id 1a75fca6ad5d, mlock for the SuiteSparse functions). That change should maybe be grafted to stable if possible.

Also, the installer appears blurry on a HiDPI screen (see attachment). Compare the text in the title bar and the text inside the window.
I don't know if there is something we can do about this or if this has to be fixed upstream in NSIS.

Markus

Installer_blurry.PNG (58K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

chris_frick
Dear all

I very appreciate your efforts to release 5.2.0 soon. Thanks a lot

I'm unfortunately not very familiar with Octave nor other open source
developments, that's probably why I'm a bit confused:
The bug reported under http://savannah.gnu.org/bugs/?45351 is marked to be
closed but its fix doesn't seem to be part of the RC which you provided
under
https://octave.space/stable_56dd7419d7aa/octave-5.1.90-w64-installer.exe.

I built afair an intermediate version a few months ago on Linux and there
the bug seemed to be fixed.

Is this possible? If yes, why? Would it be somehow possible to get it in the
5.2.0 release anyway?

Best regards and thanks a lot again
Christian



--
Sent from: https://octave.1599824.n4.nabble.com/Octave-Maintainers-f1638794.html

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/15/20 2:41 AM, chris_frick wrote:

> Dear all
>
> I very appreciate your efforts to release 5.2.0 soon. Thanks a lot
>
> I'm unfortunately not very familiar with Octave nor other open source
> developments, that's probably why I'm a bit confused:
> The bug reported under http://savannah.gnu.org/bugs/?45351 is marked to be
> closed but its fix doesn't seem to be part of the RC which you provided
> under
> https://octave.space/stable_56dd7419d7aa/octave-5.1.90-w64-installer.exe.
>
> I built afair an intermediate version a few months ago on Linux and there
> the bug seemed to be fixed.
>
> Is this possible? If yes, why? Would it be somehow possible to get it in the
> 5.2.0 release anyway?
>
> Best regards and thanks a lot again
> Christian
>


Dear Christian,

In the Octave development repository [1], there are two major branches
"stable" and "default".  "stable" was 5.1.0 and is currently 5.1.90,
whereas "default" will become 6.1.0.

The patches mentioned in bug #45351 [2] went into "default", even it was
long time ago, see [1].

If you build Octave from the repository, you build "default" by default.
 This is why you saw these changes included.

In general into "default" there go Octave patches that change the
current behavior or just might break things in the "stable" release.  I
cannot judge, why "default" was decided, but it is very unsafe to graft
those patches into the "stable" branch.  The effort of getting the
changes right might not be justified.

But no worries, Octave 6 will come this year soon [3].  Many
hard-working volunteers are on this project.  Please use your custom
build for a while and keep watching out for your changes to work with
Octave 6.

With best wishes,
Kai


[1] https://hg.savannah.gnu.org/hgweb/octave/graph/392b14b0c085
[2] https://savannah.gnu.org/bugs/?45351
[3] https://wiki.octave.org/6.1_Release_Checklist

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
In reply to this post by mmuetzel
On 1/15/20 2:07 AM, "Markus Mützel" wrote:
>
> I installed with the w64 installer on Windows 10 and tried to run the test suite. Octave closed unexpectedly with the following at the tail of fntests.log:
>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\single-index.tst
>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\slice.tst
>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\sparse.tst
>
> This might be something we already fixed on default (hg id 1a75fca6ad5d, mlock for the SuiteSparse functions). That change should maybe be grafted to stable if possible.

Markus, thank you for testing.  This is indeed serious
(https://savannah.gnu.org/bugs/?57435) and I confirmed today myself at
work with my MS Windows machine.

Now I create a quick & dirty build with the grafted cset and publish it on

   https://octave.space

soon.  If this helps, I create "official" 5.1.91 builds and then let the
final testing continue.

> Also, the installer appears blurry on a HiDPI screen (see attachment). Compare the text in the title bar and the text inside the window.
> I don't know if there is something we can do about this or if this has to be fixed upstream in NSIS.
>
> Markus
>

Reported at https://savannah.gnu.org/bugs/?57600.  Additionally, I build
the quick & dirty build with the following patch:


diff -r 92b6fce85f02 tools/makeinst-script.sh.in
--- a/tools/makeinst-script.sh.in Mon Jan 13 09:54:00 2020 -0500
+++ b/tools/makeinst-script.sh.in Wed Jan 15 12:11:56 2020 +0900
@@ -92,6 +92,7 @@
 XPStyle on
 InstallDir "C:\\Octave\\Octave-\${OCTAVE_VERSION}"
 Icon "\${INSTALLER_FILES}/octave-logo.ico"
+ManifestDPIAware true

 ######################################################################
 ; StrFunc usage

See if it helps or disturbs other DPI settings.

Kai

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/15/20 12:17 PM, Kai Torben Ohlhus wrote:

> On 1/15/20 2:07 AM, "Markus Mützel" wrote:
>>
>> I installed with the w64 installer on Windows 10 and tried to run the test suite. Octave closed unexpectedly with the following at the tail of fntests.log:
>>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\single-index.tst
>>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\slice.tst
>>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\sparse.tst
>>
>> This might be something we already fixed on default (hg id 1a75fca6ad5d, mlock for the SuiteSparse functions). That change should maybe be grafted to stable if possible.
>
> Markus, thank you for testing.  This is indeed serious
> (https://savannah.gnu.org/bugs/?57435) and I confirmed today myself at
> work with my MS Windows machine.
>
> Now I create a quick & dirty build with the grafted cset and publish it on
>
>    https://octave.space
>
> soon.  If this helps, I create "official" 5.1.91 builds and then let the
> final testing continue.
>
>> Also, the installer appears blurry on a HiDPI screen (see attachment). Compare the text in the title bar and the text inside the window.
>> I don't know if there is something we can do about this or if this has to be fixed upstream in NSIS.
>>
>> Markus
>>
>
> Reported at https://savannah.gnu.org/bugs/?57600.  Additionally, I build
> the quick & dirty build with the following patch:
>
>
> diff -r 92b6fce85f02 tools/makeinst-script.sh.in
> --- a/tools/makeinst-script.sh.in Mon Jan 13 09:54:00 2020 -0500
> +++ b/tools/makeinst-script.sh.in Wed Jan 15 12:11:56 2020 +0900
> @@ -92,6 +92,7 @@
>  XPStyle on
>  InstallDir "C:\\Octave\\Octave-\${OCTAVE_VERSION}"
>  Icon "\${INSTALLER_FILES}/octave-logo.ico"
> +ManifestDPIAware true
>
>  ######################################################################
>  ; StrFunc usage
>
> See if it helps or disturbs other DPI settings.
>
> Kai
>

Good news, Markus, grafting your fix for bug #57600 works perfect for
stable, at least on my MS Win10 machine.  Thus I make it official in the
repo.  Thanks for the pointer.

[...]

  fixed\sparse.tst ........................ PASS 1204/1204

[...]

Summary:

  PASS                            15496
  FAIL                                0
  XFAIL (reported bug)               28
  SKIP (missing feature)             52
  SKIP (run-time condition)          39

Can you check if the HiDPI problem was solved with the new installer as
well?  All available on:

   https://octave.space

Best,
Kai

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

mmuetzel
Am 15. Januar 2020 um 06:54 Uhr schrieb "Kai Torben Ohlhus":

> On 1/15/20 12:17 PM, Kai Torben Ohlhus wrote:
> > On 1/15/20 2:07 AM, "Markus Mützel" wrote:
> >>
> >> I installed with the w64 installer on Windows 10 and tried to run the test suite. Octave closed unexpectedly with the following at the tail of fntests.log:
> >>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\single-index.tst
> >>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\slice.tst
> >>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\sparse.tst
> >>
> >> This might be something we already fixed on default (hg id 1a75fca6ad5d, mlock for the SuiteSparse functions). That change should maybe be grafted to stable if possible.
> >
> > Markus, thank you for testing.  This is indeed serious
> > (https://savannah.gnu.org/bugs/?57435) and I confirmed today myself at
> > work with my MS Windows machine.
> >
> > Now I create a quick & dirty build with the grafted cset and publish it on
> >
> >    https://octave.space
> >
> > soon.  If this helps, I create "official" 5.1.91 builds and then let the
> > final testing continue.
> >
> >> Also, the installer appears blurry on a HiDPI screen (see attachment). Compare the text in the title bar and the text inside the window.
> >> I don't know if there is something we can do about this or if this has to be fixed upstream in NSIS.
> >>
> >> Markus
> >>
> >
> > Reported at https://savannah.gnu.org/bugs/?57600.  Additionally, I build
> > the quick & dirty build with the following patch:
> >
> >
> > diff -r 92b6fce85f02 tools/makeinst-script.sh.in
> > --- a/tools/makeinst-script.sh.in Mon Jan 13 09:54:00 2020 -0500
> > +++ b/tools/makeinst-script.sh.in Wed Jan 15 12:11:56 2020 +0900
> > @@ -92,6 +92,7 @@
> >  XPStyle on
> >  InstallDir "C:\\Octave\\Octave-\${OCTAVE_VERSION}"
> >  Icon "\${INSTALLER_FILES}/octave-logo.ico"
> > +ManifestDPIAware true
> >
> >  ######################################################################
> >  ; StrFunc usage
> >
> > See if it helps or disturbs other DPI settings.
> >
> > Kai
> >
>
> Good news, Markus, grafting your fix for bug #57600 works perfect for
> stable, at least on my MS Win10 machine.  Thus I make it official in the
> repo.  Thanks for the pointer.
>
> [...]
>
>   fixed\sparse.tst ........................ PASS 1204/1204
>
> [...]
>
> Summary:
>
>   PASS                            15496
>   FAIL                                0
>   XFAIL (reported bug)               28
>   SKIP (missing feature)             52
>   SKIP (run-time condition)          39
>
> Can you check if the HiDPI problem was solved with the new installer as
> well?  All available on:
>
>    https://octave.space
Thanks for providing an updated build.

Unfortunately, the text in the installer still appears blurry on a HiDPI monitor (see attachment).

The test suite now no longer crashes Octave. So that's good. :-)
I have one failing test:
>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\libinterp\corefcn\graphics.cc-tst
***** test
 hf = figure ("visible", "off");
 hax = axes ("parent", hf);
 unwind_protect
   hctx1 = uicontextmenu ("parent", hf);
   hctx2 = uicontextmenu ("parent", hf);
   set (hf, "uicontextmenu", hctx2);
   set (hax, "uicontextmenu", hctx2);
   assert (get (hf, "uicontextmenu"), hctx2);
   assert (get (hax, "uicontextmenu"), hctx2);
   assert (get (hf, "children"), [hctx2; hctx1; hax]);
   delete (hctx2);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hax, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
   set (hf, "uicontextmenu", hctx1);
   assert (get (hf, "uicontextmenu"), hctx1);
   set (hf, "uicontextmenu", []);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
 unwind_protect_cleanup
   close (hf);
 end_unwind_protect;
!!!!! test failed
ASSERT errors for:  assert (get (hf, "uicontextmenu"),[])

  Location  |  Observed  |  Expected  |  Reason
     .          O(1x1)       E(0x0)      Dimensions don't match

But if I remember correctly, that one is due to a timing issue and failed intermittently before. So not a regression.

Markus

Installer_blurry_2020-01-15.PNG (57K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

mmuetzel
Am 15. Januar 2020 um 11:29 Uhr schrieb "Markus Mützel":

> Am 15. Januar 2020 um 06:54 Uhr schrieb "Kai Torben Ohlhus":
> > On 1/15/20 12:17 PM, Kai Torben Ohlhus wrote:
> > > On 1/15/20 2:07 AM, "Markus Mützel" wrote:
> > >>
> > >> I installed with the w64 installer on Windows 10 and tried to run the test suite. Octave closed unexpectedly with the following at the tail of fntests.log:
> > >>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\single-index.tst
> > >>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\slice.tst
> > >>>>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\sparse.tst
> > >>
> > >> This might be something we already fixed on default (hg id 1a75fca6ad5d, mlock for the SuiteSparse functions). That change should maybe be grafted to stable if possible.
> > >
> > > Markus, thank you for testing.  This is indeed serious
> > > (https://savannah.gnu.org/bugs/?57435) and I confirmed today myself at
> > > work with my MS Windows machine.
> > >
> > > Now I create a quick & dirty build with the grafted cset and publish it on
> > >
> > >    https://octave.space
> > >
> > > soon.  If this helps, I create "official" 5.1.91 builds and then let the
> > > final testing continue.
> > >
> > >> Also, the installer appears blurry on a HiDPI screen (see attachment). Compare the text in the title bar and the text inside the window.
> > >> I don't know if there is something we can do about this or if this has to be fixed upstream in NSIS.
> > >>
> > >> Markus
> > >>
> > >
> > > Reported at https://savannah.gnu.org/bugs/?57600.  Additionally, I build
> > > the quick & dirty build with the following patch:
> > >
> > >
> > > diff -r 92b6fce85f02 tools/makeinst-script.sh.in
> > > --- a/tools/makeinst-script.sh.in Mon Jan 13 09:54:00 2020 -0500
> > > +++ b/tools/makeinst-script.sh.in Wed Jan 15 12:11:56 2020 +0900
> > > @@ -92,6 +92,7 @@
> > >  XPStyle on
> > >  InstallDir "C:\\Octave\\Octave-\${OCTAVE_VERSION}"
> > >  Icon "\${INSTALLER_FILES}/octave-logo.ico"
> > > +ManifestDPIAware true
> > >
> > >  ######################################################################
> > >  ; StrFunc usage
> > >
> > > See if it helps or disturbs other DPI settings.
> > >
> > > Kai
> > >
> >
> > Good news, Markus, grafting your fix for bug #57600 works perfect for
> > stable, at least on my MS Win10 machine.  Thus I make it official in the
> > repo.  Thanks for the pointer.
> >
> > [...]
> >
> >   fixed\sparse.tst ........................ PASS 1204/1204
> >
> > [...]
> >
> > Summary:
> >
> >   PASS                            15496
> >   FAIL                                0
> >   XFAIL (reported bug)               28
> >   SKIP (missing feature)             52
> >   SKIP (run-time condition)          39
> >
> > Can you check if the HiDPI problem was solved with the new installer as
> > well?  All available on:
> >
> >    https://octave.space
>
> Thanks for providing an updated build.
>
> Unfortunately, the text in the installer still appears blurry on a HiDPI monitor (see attachment).
>
> The test suite now no longer crashes Octave. So that's good. :-)
> I have one failing test:
> >>>>> processing C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\libinterp\corefcn\graphics.cc-tst
> ***** test
>  hf = figure ("visible", "off");
>  hax = axes ("parent", hf);
>  unwind_protect
>    hctx1 = uicontextmenu ("parent", hf);
>    hctx2 = uicontextmenu ("parent", hf);
>    set (hf, "uicontextmenu", hctx2);
>    set (hax, "uicontextmenu", hctx2);
>    assert (get (hf, "uicontextmenu"), hctx2);
>    assert (get (hax, "uicontextmenu"), hctx2);
>    assert (get (hf, "children"), [hctx2; hctx1; hax]);
>    delete (hctx2);
>    assert (get (hf, "uicontextmenu"), []);
>    assert (get (hax, "uicontextmenu"), []);
>    assert (get (hf, "children"), [hctx1; hax]);
>    set (hf, "uicontextmenu", hctx1);
>    assert (get (hf, "uicontextmenu"), hctx1);
>    set (hf, "uicontextmenu", []);
>    assert (get (hf, "uicontextmenu"), []);
>    assert (get (hf, "children"), [hctx1; hax]);
>  unwind_protect_cleanup
>    close (hf);
>  end_unwind_protect;
> !!!!! test failed
> ASSERT errors for:  assert (get (hf, "uicontextmenu"),[])
>
>   Location  |  Observed  |  Expected  |  Reason
>      .          O(1x1)       E(0x0)      Dimensions don't match
>
> But if I remember correctly, that one is due to a timing issue and failed intermittently before. So not a regression.

I ran the test suite again on the same machine and it completed without any failing tests. So this is most likely nothing new.

Another thing: Maybe we should update the readme file that opens after the installation has finished. It still refers to Octave 5 being a major update.

Markus

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/15/20 8:27 PM, "Markus Mützel" wrote:

>>>>
>>>>> Also, the installer appears blurry on a HiDPI screen (see attachment). Compare the text in the title bar and the text inside the window.
>>>>> I don't know if there is something we can do about this or if this has to be fixed upstream in NSIS.
>>>>>
>>>> Reported at https://savannah.gnu.org/bugs/?57600.  Additionally, I build
>>>> the quick & dirty build with the following patch:
>>>>
>>>>
>>>> diff -r 92b6fce85f02 tools/makeinst-script.sh.in
>>>> --- a/tools/makeinst-script.sh.in Mon Jan 13 09:54:00 2020 -0500
>>>> +++ b/tools/makeinst-script.sh.in Wed Jan 15 12:11:56 2020 +0900
>>>> @@ -92,6 +92,7 @@
>>>>  XPStyle on
>>>>  InstallDir "C:\\Octave\\Octave-\${OCTAVE_VERSION}"
>>>>  Icon "\${INSTALLER_FILES}/octave-logo.ico"
>>>> +ManifestDPIAware true
>>>>
>>>>  ######################################################################
>>>>  ; StrFunc usage
>>>>
>>>> See if it helps or disturbs other DPI settings.
>>>>
>>
>> Unfortunately, the text in the installer still appears blurry on a HiDPI monitor (see attachment).


If I may stress your time a little more, I think I did not apply my
patch correctly.  Just to be sure, I soon upload another installer
version and I would be happy if you try the DPI setting again.


> I ran the test suite again on the same machine and it completed without any failing tests. So this is most likely nothing new.


This is great for a stable version =)  Thanks for testing.


> Another thing: Maybe we should update the readme file that opens after the installation has finished. It still refers to Octave 5 being a major update.
>
> Markus
>


Is this something that has to be done in the MXE repo [1], right?  There
I have no access to.  Do you have Markus, or shall I ask John Donoghue
about this?

Kai


[1]
https://hg.octave.org/mxe-octave/file/92b6fce85f02/installer-files/README.html

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

mmuetzel
Am 15. Januar 2020 um 12:36 Uhr schrieb "Kai Torben Ohlhus" <[hidden email]>
> An: "Markus Mützel" <[hidden email]>
> >> Unfortunately, the text in the installer still appears blurry on a HiDPI monitor (see attachment).
>
> If I may stress your time a little more, I think I did not apply my
> patch correctly.  Just to be sure, I soon upload another installer
> version and I would be happy if you try the DPI setting again.

No worries. In the "worst case scenario", it might take some time before I can access the machine with that monitor again.


> > Another thing: Maybe we should update the readme file that opens after the installation has finished. It still refers to Octave 5 being a major update.
>
> Is this something that has to be done in the MXE repo [1], right?  There
> I have no access to.  Do you have Markus, or shall I ask John Donoghue
> about this?

I can push changes.
What should it be changed to? Maybe just replace the second sentence by:

  Octave 5.2 is a minor release mainly focused on fixing bugs found in Octave 5.1.

Markus

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/15/20 9:26 PM, "Markus Mützel" wrote:
> Am 15. Januar 2020 um 12:36 Uhr schrieb "Kai Torben Ohlhus" <[hidden email]>
>> An: "Markus Mützel" <[hidden email]>
>>>> Unfortunately, the text in the installer still appears blurry on a HiDPI monitor (see attachment).
>>
>> If I may stress your time a little more, I think I did not apply my
>> patch correctly.  Just to be sure, I soon upload another installer
>> version and I would be happy if you try the DPI setting again.
>
> No worries. In the "worst case scenario", it might take some time before I can access the machine with that monitor again.


Finally uploaded:  https://octave.space/


>>> Another thing: Maybe we should update the readme file that opens after the installation has finished. It still refers to Octave 5 being a major update.
>>
>> Is this something that has to be done in the MXE repo [1], right?  There
>> I have no access to.  Do you have Markus, or shall I ask John Donoghue
>> about this?
>
> I can push changes.
> What should it be changed to? Maybe just replace the second sentence by:
>
>   Octave 5.2 is a minor release mainly focused on fixing bugs found in Octave 5.1.
>
> Markus


Sure, as replacement for


https://hg.octave.org/mxe-octave/file/92b6fce85f02/installer-files/README.html#l20

this sounds good.  Also for native English speakers? ^^  The rest of
that file seems fine.

Kai

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

mmuetzel
Am 15. Januar 2020 um 13:36 Uhr schrieb "Kai Torben Ohlhus":

> On 1/15/20 9:26 PM, "Markus Mützel" wrote:
> > Am 15. Januar 2020 um 12:36 Uhr schrieb "Kai Torben Ohlhus" <[hidden email]>
> >> An: "Markus Mützel" <[hidden email]>
> >>>> Unfortunately, the text in the installer still appears blurry on a HiDPI monitor (see attachment).
> >>
> >> If I may stress your time a little more, I think I did not apply my
> >> patch correctly.  Just to be sure, I soon upload another installer
> >> version and I would be happy if you try the DPI setting again.
> >
> > No worries. In the "worst case scenario", it might take some time before I can access the machine with that monitor again.
>
>
> Finally uploaded:  https://octave.space/
That was fast!

The machine in question has two monitors connected to it. One with HiDPI, the other one with default DPI settings.
With the latest installer, the text is perfectly rendered on the HiDPI monitor. But it is slightly blurry when I move the installer window to the monitor with default DPI setting (see the attachments).
The text doesn't look as bad on screen as it does in the attached screenshot though. (I wonder why that is.) So overall, I'd say that this is an improvement on that system.

Could you please share your changes on bug #57600?
https://savannah.gnu.org/bugs/?57600

Markus

Installer_blurry_2020-01-15-20-02_HiDPI.PNG (25K) Download Attachment
Installer_blurry_2020-01-15-20-02_StandardDPI.PNG (40K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/15/20 9:51 PM, "Markus Mützel" wrote:

> Am 15. Januar 2020 um 13:36 Uhr schrieb "Kai Torben Ohlhus":
>> On 1/15/20 9:26 PM, "Markus Mützel" wrote:
>>> Am 15. Januar 2020 um 12:36 Uhr schrieb "Kai Torben Ohlhus" <[hidden email]>
>>>> An: "Markus Mützel" <[hidden email]>
>>>>>> Unfortunately, the text in the installer still appears blurry on a HiDPI monitor (see attachment).
>>>>
>>>> If I may stress your time a little more, I think I did not apply my
>>>> patch correctly.  Just to be sure, I soon upload another installer
>>>> version and I would be happy if you try the DPI setting again.
>>>
>>> No worries. In the "worst case scenario", it might take some time before I can access the machine with that monitor again.
>>
>>
>> Finally uploaded:  https://octave.space/
>
> That was fast!
>
> The machine in question has two monitors connected to it. One with HiDPI, the other one with default DPI settings.
> With the latest installer, the text is perfectly rendered on the HiDPI monitor. But it is slightly blurry when I move the installer window to the monitor with default DPI setting (see the attachments).
> The text doesn't look as bad on screen as it does in the attached screenshot though. (I wonder why that is.) So overall, I'd say that this is an improvement on that system.
>
> Could you please share your changes on bug #57600?
> https://savannah.gnu.org/bugs/?57600
>
> Markus
>

Done.

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
In reply to this post by mmuetzel
jwe,

Now I think the most fatal regression with SuiteSparse has been wiped
out, thanks to Markus.  A fresh set of 3x3 mxe builds is ready.  Thus we
should start a final regression test period until

   Friday, January 31st 2020.

If nothing severe shows up in that time, Octave 5.2.0 can be released on
the following weekend.  jew, do you want to upload my tarballs and mxe
64-bit builds from

   https://octave.space

to

   https://alpha.gnu.org/gnu/octave/

or do we just keep everything under the first URL?  Then I can make an
announcement on the mailing-lists, wiki, website.

Kai

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

nrjank
Now I think the most fatal regression with SuiteSparse has been wiped
out, thanks to Markus.  A fresh set of 3x3 mxe builds is ready.  Thus we
should start a final regression test period until



quick question - are there any specific tests unique to the w64-64 versions? should there be?  
Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/17/20 1:02 AM, Nicholas Jankowski wrote:
>     Now I think the most fatal regression with SuiteSparse has been wiped
>     out, thanks to Markus.  A fresh set of 3x3 mxe builds is ready.  Thus we
>     should start a final regression test period until
>
>
>
> quick question - are there any specific tests unique to the w64-64
> versions? should there be?  

To my knowledge no.  I think due to the fact, that you need lots of main
memory (>32 GB) to really test 64-bit indexing with matrices, we do not
have any yet.

One thing you can try is running the commands from the wiki example
(there I recently figured out how to test 64-bit indexing with only 8 GB
main memory available):


https://wiki.octave.org/Enable_large_arrays:_Build_octave_such_that_it_can_use_arrays_larger_than_2Gb.

Kai

Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

nrjank

One thing you can try is running the commands from the wiki example
(there I recently figured out how to test 64-bit indexing with only 8 GB
main memory available):


https://wiki.octave.org/Enable_large_arrays:_Build_octave_such_that_it_can_use_arrays_larger_than_2Gb.

Kai

 thanks, I had just come across that and after the test suite finished was going to just test creating some large int arrays (since I only have 16GB here)
Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

nrjank
In reply to this post by siko1056

One thing you can try is running the commands from the wiki example
(there I recently figured out how to test 64-bit indexing with only 8 GB
main memory available):




is there any kind of 'is compiled with 64bit indexing' flag such that a test could be written where if true it runs a quick:

>> a = zeros (1024*1024*1024*3, 1, 'int8');

during the test suite?
Reply | Threaded
Open this post in threaded view
|

Re: Octave 5.2.0 release

siko1056
On 1/17/20 11:14 AM, Nicholas Jankowski wrote:

>
>     One thing you can try is running the commands from the wiki example
>     (there I recently figured out how to test 64-bit indexing with only 8 GB
>     main memory available):
>
>
>
>
> is there any kind of 'is compiled with 64bit indexing' flag such that a
> test could be written where if true it runs a quick:
>
>>> a = zeros (1024*1024*1024*3, 1, 'int8');
>
> during the test suite?

Since Octave 4.4 64-bit indexing is default.  Only the BLAS,
SuiteSparse, integer index size is not 64-bit by default.

Thus

   __octave_config_info__ ("ENABLE_64")

should always be true = "1".  In "octave-config.h" which is installed
with Octave you can read the byte size of the respective integer types.
 In case of w64-64 this should be:

   #  define OCTAVE_SIZEOF_F77_INT_TYPE 8
   #  define OCTAVE_SIZEOF_IDX_TYPE 8

But I don't know how to conveniently read those values from within Octave.

On the other hand, I do not like main memory extensive tests without
warning/cancel button before freezing my system in swapping.  Your test
requires 3 GB main memory and should be trivial for a default Octave
installation.

What kind of regressions do you expect to test with this test?

Kai

123