RE: [bug #56425] Patch for the JIT

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

RE: [bug #56425] Patch for the JIT

Gene Harvey

My fault, I left a lot of changes in that weren’t strictly necessary. I can definitely repackage it if people aren’t too far through yet.

 

With regards to the std::endl changes, it’s just premature optimization (std::endl makes flushes the buffer).

 

Gene Harvey

 

From: [hidden email]
Sent: Sunday, June 2, 2019 17:45
To: [hidden email]; [hidden email]; [hidden email]
Subject: [bug #56425] Patch for the JIT

 

Follow-up Comment #1, bug #56425 (project octave):

 

There seem to be a lot of unrelated changes here, what's the point of changing

`os << std::endl;` to `os << '\n'`?

 

This patch is also kind of mammoth which makes it difficult to review. Think

you could split it up?

 

    _______________________________________________________

 

Reply to this item at:

 

  <https://savannah.gnu.org/bugs/?56425>

 

_______________________________________________

  Message sent via Savannah

  https://savannah.gnu.org/