Re: final format() changes

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: final format() changes

Rik-4
Kai,

With jwe's suggestion, I checked in a change for format which does not make
any modifications unless all arguments are parsed successfully.  See
https://hg.savannah.gnu.org/hgweb/octave/rev/25479159213b.  This should be
the last change needed for format (fingers crossed).

--Rik

Reply | Threaded
Open this post in threaded view
|

Re: final format() changes

siko1056
On 10/17/19 6:42 AM, Rik wrote:
> Kai,
>
> With jwe's suggestion, I checked in a change for format which does not make
> any modifications unless all arguments are parsed successfully.  See
> https://hg.savannah.gnu.org/hgweb/octave/rev/25479159213b.  This should be
> the last change needed for format (fingers crossed).
>
> --Rik
>

Now I am really fully satisfied and happy!  None of my stupid inputs
caused unexpected or implausible behavior =)

I am sorry for having been such a horrible user and hope you don't feel
annoyed by my testing.  Your new feature is really appreciated and I
want to make a lot use of it ;-)

Thank you both a lot.  Maybe I can extend the NEWS [1] about multiple
format options, if you want?

Kai

[1] https://hg.savannah.gnu.org/hgweb/octave/rev/bea2823affa4

Reply | Threaded
Open this post in threaded view
|

Re: final format() changes

Rik-4
On 10/16/2019 07:25 PM, Kai Torben Ohlhus wrote:

> On 10/17/19 6:42 AM, Rik wrote:
>> Kai,
>>
>> With jwe's suggestion, I checked in a change for format which does not make
>> any modifications unless all arguments are parsed successfully.  See
>> https://hg.savannah.gnu.org/hgweb/octave/rev/25479159213b.  This should be
>> the last change needed for format (fingers crossed).
>>
>> --Rik
>>
> Now I am really fully satisfied and happy!  None of my stupid inputs
> caused unexpected or implausible behavior =)
>
> I am sorry for having been such a horrible user and hope you don't feel
> annoyed by my testing.  Your new feature is really appreciated and I
> want to make a lot use of it ;-)

No worries, Octave is better for all the testing of corner cases you did.

>
> Thank you both a lot.  Maybe I can extend the NEWS [1] about multiple
> format options, if you want?
Sure.

--Rik

Reply | Threaded
Open this post in threaded view
|

Re: final format() changes

siko1056
On 10/17/19 12:29 PM, Rik wrote:
> On 10/16/2019 07:25 PM, Kai Torben Ohlhus wrote:
>>
>> Thank you both a lot.  Maybe I can extend the NEWS [1] about multiple
>> format options, if you want?
> Sure.
>
> --Rik
>

Done https://hg.savannah.gnu.org/hgweb/octave/rev/37f9eb2c05e0

Kai

Reply | Threaded
Open this post in threaded view
|

Re: final format() changes

Rik-4
On 10/17/2019 09:28 PM, Kai Torben Ohlhus wrote:
> On 10/17/19 12:29 PM, Rik wrote:
>> On 10/16/2019 07:25 PM, Kai Torben Ohlhus wrote:
>>> Thank you both a lot.  Maybe I can extend the NEWS [1] about multiple
>>> format options, if you want?
>> Sure.
>>
>> --Rik
>>
> Done https://hg.savannah.gnu.org/hgweb/octave/rev/37f9eb2c05e0

I made a slight tweak here
https://hg.savannah.gnu.org/hgweb/octave/rev/3912e3a74e31.

It turns out that English has a specific word, "rightmost"
(https://www.thefreedictionary.com/rightmost), for the concept you were
trying to convey, "the 'most right' argument takes precedence".  At least
to a native speaker, "rightmost" sounds better to the ear.

About 1/3 of English words are cognates (similar) to German words, for
example, Apfel -> apple or Eisberg -> iceberg.  If I had to guess, I'd say
that English also borrowed the German tendency to smash two words together
into a new one, as for example Weltmarktführer to mean world (Welt) market
(markt) leader (führer).  In this case, "right" + "most" = "rightmost".

--Rik



Reply | Threaded
Open this post in threaded view
|

Re: final format() changes

siko1056
On 10/19/19 12:13 AM, Rik wrote:

> On 10/17/2019 09:28 PM, Kai Torben Ohlhus wrote:
>> On 10/17/19 12:29 PM, Rik wrote:
>>> On 10/16/2019 07:25 PM, Kai Torben Ohlhus wrote:
>>>> Thank you both a lot.  Maybe I can extend the NEWS [1] about multiple
>>>> format options, if you want?
>>> Sure.
>>>
>>> --Rik
>>>
>> Done https://hg.savannah.gnu.org/hgweb/octave/rev/37f9eb2c05e0
>
> I made a slight tweak here
> https://hg.savannah.gnu.org/hgweb/octave/rev/3912e3a74e31.
>
> It turns out that English has a specific word, "rightmost"
> (https://www.thefreedictionary.com/rightmost), for the concept you were
> trying to convey, "the 'most right' argument takes precedence".  At least
> to a native speaker, "rightmost" sounds better to the ear.
>
> About 1/3 of English words are cognates (similar) to German words, for
> example, Apfel -> apple or Eisberg -> iceberg.  If I had to guess, I'd say
> that English also borrowed the German tendency to smash two words together
> into a new one, as for example Weltmarktführer to mean world (Welt) market
> (markt) leader (führer).  In this case, "right" + "most" = "rightmost".
>
> --Rik
>

Thanks for the improvement Rik.  Of course the documentation should be
in the best possible English and you taught me another nice word that I
hope to remember in these situations to conceal I am not a native
English speaker ;-)

Kai