Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

vivek91m
Hello,
Recently Mr.Francesco Potortì reported a bug in the use of interp1.
https://savannah.gnu.org/bugs/?36732

--------------------------------------------------------------------------------------------------------------------------------

This one should give an error:

interp1([1:5 4:9], 1:11, 4)

In fact, it gives out 4. The first argument is not checked.

Also, the documentation should say "strictly monotonic" where it currently says "monotonic".

--------------------------------------------------------------------------------------------------------------------------------

I contacted Mr. Potorti and as far as we know this bug hasn't been fixed. So I would like to offer myself to fix the same. Please let me know how should i go about it.

With regards,
Vivek Dogra

_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

Juan Pablo Carbajal
On Tue, Jul 24, 2012 at 10:27 AM, vivek dogra
<[hidden email]> wrote:

> Hello,
> Recently Mr.Francesco Potortì reported a bug in the use of interp1.
> https://savannah.gnu.org/bugs/?36732
>
> --------------------------------------------------------------------------------------------------------------------------------
>
> This one should give an error:
>
> interp1([1:5 4:9], 1:11, 4)
>
> In fact, it gives out 4. The first argument is not checked.
>
> Also, the documentation should say "strictly monotonic" where it currently
> says "monotonic".
>
> --------------------------------------------------------------------------------------------------------------------------------
>
> I contacted Mr. Potorti and as far as we know this bug hasn't been fixed. So
> I would like to offer myself to fix the same. Please let me know how should
> i go about it.
>
> With regards,
> Vivek Dogra
>
> _______________________________________________
> Help-octave mailing list
> [hidden email]
> https://mailman.cae.wisc.edu/listinfo/help-octave
>

Hi,
submit your patch to the same bug tracker (add a comment to Potorti's
comment and upload your patch). If you do not know how to do patches
read here
http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet

--
M. Sc. Juan Pablo Carbajal
-----
PhD Student
University of Zürich
http://ailab.ifi.uzh.ch/carbajal/
_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

bpabbott
Administrator
In reply to this post by vivek91m
On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:

> Hello,
> Recently Mr.Francesco Potortì reported a bug in the use of interp1.
> https://savannah.gnu.org/bugs/?36732
>
> --------------------------------------------------------------------------------------------------------------------------------
> This one should give an error:
>
> interp1([1:5 4:9], 1:11, 4)
>
> In fact, it gives out 4. The first argument is not checked.
>
> Also, the documentation should say "strictly monotonic" where it currently says "monotonic".
>
> --------------------------------------------------------------------------------------------------------------------------------
>
> I contacted Mr. Potorti and as far as we know this bug hasn't been fixed. So I would like to offer myself to fix the same. Please let me know how should i go about it.
>
> With regards,
> Vivek Dogra

The status of the work on bugs should be recorded on the bug tracker.  It does not appear that any work has been done on this bug yet, so you are free to work on it.  Please enter a comment on the tracker to let others know you've begun working on it.  That will help avoid duplicate efforts.

Thanks,
Ben


_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

bpabbott
Administrator
On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:

> On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]> wrote:
> On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>
> > Hello,
> > Recently Mr.Francesco Potortì reported a bug in the use of interp1.
> > https://savannah.gnu.org/bugs/?36732
> >
> > --------------------------------------------------------------------------------------------------------------------------------
> > This one should give an error:
> >
> > interp1([1:5 4:9], 1:11, 4)
> >
> > In fact, it gives out 4. The first argument is not checked.
> >
> > Also, the documentation should say "strictly monotonic" where it currently says "monotonic".
> >
> > --------------------------------------------------------------------------------------------------------------------------------
> >
> > I contacted Mr. Potorti and as far as we know this bug hasn't been fixed. So I would like to offer myself to fix the same. Please let me know how should i go about it.
> >
> > With regards,
> > Vivek Dogra
>
> The status of the work on bugs should be recorded on the bug tracker.  It does not appear that any work has been done on this bug yet, so you are free to work on it.  Please enter a comment on the tracker to let others know you've begun working on it.  That will help avoid duplicate efforts.
>
> Thanks,
> Ben
>
> Should i just comment where the bug is reported (which i have already done). Or there is a procedure to assign the bug to me i.e. to update the status of the bug, so as to avoid duplicate efforts?
>
> Regards,
> Vivek

The comment is enough.

Ben
_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

vivek91m
Okay, i have made changes to the interp1 function to check for strictly monotonicity (which it was not doing earlier, although it is written in the documentation). So i have a patch for the bug#36732: interp1 does not check input for monotonicity.

I would like to ask how can i submit the patch. I went through the link provided above http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet
but i am not able to understand it properly.
I would appreciate proper guidance. Thank you.

Regards,
Vivek.

On Wed, Jul 25, 2012 at 2:29 PM, Ben Abbott <[hidden email]> wrote:
On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:

> On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]> wrote:
> On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>
> > Hello,
> > Recently Mr.Francesco Potortì reported a bug in the use of interp1.
> > https://savannah.gnu.org/bugs/?36732
> >
> > --------------------------------------------------------------------------------------------------------------------------------
> > This one should give an error:
> >
> > interp1([1:5 4:9], 1:11, 4)
> >
> > In fact, it gives out 4. The first argument is not checked.
> >
> > Also, the documentation should say "strictly monotonic" where it currently says "monotonic".
> >
> > --------------------------------------------------------------------------------------------------------------------------------
> >
> > I contacted Mr. Potorti and as far as we know this bug hasn't been fixed. So I would like to offer myself to fix the same. Please let me know how should i go about it.
> >
> > With regards,
> > Vivek Dogra
>
> The status of the work on bugs should be recorded on the bug tracker.  It does not appear that any work has been done on this bug yet, so you are free to work on it.  Please enter a comment on the tracker to let others know you've begun working on it.  That will help avoid duplicate efforts.
>
> Thanks,
> Ben
>
> Should i just comment where the bug is reported (which i have already done). Or there is a procedure to assign the bug to me i.e. to update the status of the bug, so as to avoid duplicate efforts?
>
> Regards,
> Vivek

The comment is enough.

Ben


_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

Juan Pablo Carbajal
On Thu, Jul 26, 2012 at 6:25 AM, vivek dogra <[hidden email]> wrote:

> Okay, i have made changes to the interp1 function to check for strictly
> monotonicity (which it was not doing earlier, although it is written in the
> documentation). So i have a patch for the bug#36732: interp1 does not check
> input for monotonicity.
>
> I would like to ask how can i submit the patch. I went through the link
> provided above
> http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet
> but i am not able to understand it properly.
> I would appreciate proper guidance. Thank you.
>
> Regards,
> Vivek.
>
>
> On Wed, Jul 25, 2012 at 2:29 PM, Ben Abbott <[hidden email]> wrote:
>>
>> On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:
>>
>> > On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]> wrote:
>> > On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>> >
>> > > Hello,
>> > > Recently Mr.Francesco Potortì reported a bug in the use of interp1.
>> > > https://savannah.gnu.org/bugs/?36732
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > > This one should give an error:
>> > >
>> > > interp1([1:5 4:9], 1:11, 4)
>> > >
>> > > In fact, it gives out 4. The first argument is not checked.
>> > >
>> > > Also, the documentation should say "strictly monotonic" where it
>> > > currently says "monotonic".
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > >
>> > > I contacted Mr. Potorti and as far as we know this bug hasn't been
>> > > fixed. So I would like to offer myself to fix the same. Please let me know
>> > > how should i go about it.
>> > >
>> > > With regards,
>> > > Vivek Dogra
>> >
>> > The status of the work on bugs should be recorded on the bug tracker.
>> > It does not appear that any work has been done on this bug yet, so you are
>> > free to work on it.  Please enter a comment on the tracker to let others
>> > know you've begun working on it.  That will help avoid duplicate efforts.
>> >
>> > Thanks,
>> > Ben
>> >
>> > Should i just comment where the bug is reported (which i have already
>> > done). Or there is a procedure to assign the bug to me i.e. to update the
>> > status of the bug, so as to avoid duplicate efforts?
>> >
>> > Regards,
>> > Vivek
>>
>> The comment is enough.
>>
>> Ben
>
>
>
> _______________________________________________
> Help-octave mailing list
> [hidden email]
> https://mailman.cae.wisc.edu/listinfo/help-octave
>

Vivek,

Please answer at the bottom of each message.

Look at this bug
http://savannah.gnu.org/bugs/?func=detailitem&item_id=33857#attached

You can see that people write a short message of the fix and then
attach their patch to their message. Do the same. The patch should be
created according to the instructions on the wiki.



--
M. Sc. Juan Pablo Carbajal
-----
PhD Student
University of Zürich
http://ailab.ifi.uzh.ch/carbajal/
_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

vivek91m

On Thu, Jul 26, 2012 at 10:51 AM, Juan Pablo Carbajal <[hidden email]> wrote:
On Thu, Jul 26, 2012 at 6:25 AM, vivek dogra <[hidden email]> wrote:
> Okay, i have made changes to the interp1 function to check for strictly
> monotonicity (which it was not doing earlier, although it is written in the
> documentation). So i have a patch for the bug#36732: interp1 does not check
> input for monotonicity.
>
> I would like to ask how can i submit the patch. I went through the link
> provided above
> http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet
> but i am not able to understand it properly.
> I would appreciate proper guidance. Thank you.
>
> Regards,
> Vivek.
>
>
> On Wed, Jul 25, 2012 at 2:29 PM, Ben Abbott <[hidden email]> wrote:
>>
>> On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:
>>
>> > On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]> wrote:
>> > On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>> >
>> > > Hello,
>> > > Recently Mr.Francesco Potortì reported a bug in the use of interp1.
>> > > https://savannah.gnu.org/bugs/?36732
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > > This one should give an error:
>> > >
>> > > interp1([1:5 4:9], 1:11, 4)
>> > >
>> > > In fact, it gives out 4. The first argument is not checked.
>> > >
>> > > Also, the documentation should say "strictly monotonic" where it
>> > > currently says "monotonic".
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > >
>> > > I contacted Mr. Potorti and as far as we know this bug hasn't been
>> > > fixed. So I would like to offer myself to fix the same. Please let me know
>> > > how should i go about it.
>> > >
>> > > With regards,
>> > > Vivek Dogra
>> >
>> > The status of the work on bugs should be recorded on the bug tracker.
>> > It does not appear that any work has been done on this bug yet, so you are
>> > free to work on it.  Please enter a comment on the tracker to let others
>> > know you've begun working on it.  That will help avoid duplicate efforts.
>> >
>> > Thanks,
>> > Ben
>> >
>> > Should i just comment where the bug is reported (which i have already
>> > done). Or there is a procedure to assign the bug to me i.e. to update the
>> > status of the bug, so as to avoid duplicate efforts?
>> >
>> > Regards,
>> > Vivek
>>
>> The comment is enough.
>>
>> Ben
>
>
>
> _______________________________________________
> Help-octave mailing list
> [hidden email]
> https://mailman.cae.wisc.edu/listinfo/help-octave
>

Vivek,

Please answer at the bottom of each message.

Look at this bug
http://savannah.gnu.org/bugs/?func=detailitem&item_id=33857#attached

You can see that people write a short message of the fix and then
attach their patch to their message. Do the same. The patch should be
created according to the instructions on the wiki.



--
M. Sc. Juan Pablo Carbajal
-----
PhD Student
University of Zürich
http://ailab.ifi.uzh.ch/carbajal/


Hello, it is in continuation with the bug in interp1. I am a newbie and have a basic question to ask. To fix the above bug, should i change the .m file or there is any source file behind it where i should make changes? As of now i have just made the copy of the interp1.m file on my machine and fixed the bug in that which is working fine.

please let me know how should i go about it.

Regards,
Vivek.




_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

bpabbott
Administrator
On Aug 8, 2012, at 1:36 AM, vivek dogra <[hidden email]> wrote:


On Thu, Jul 26, 2012 at 10:51 AM, Juan Pablo Carbajal <[hidden email]> wrote:
On Thu, Jul 26, 2012 at 6:25 AM, vivek dogra <[hidden email]> wrote:
> Okay, i have made changes to the interp1 function to check for strictly
> monotonicity (which it was not doing earlier, although it is written in the
> documentation). So i have a patch for the bug#36732: interp1 does not check
> input for monotonicity.
>
> I would like to ask how can i submit the patch. I went through the link
> provided above
> http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet
> but i am not able to understand it properly.
> I would appreciate proper guidance. Thank you.
>
> Regards,
> Vivek.
>
>
> On Wed, Jul 25, 2012 at 2:29 PM, Ben Abbott <[hidden email]> wrote:
>>
>> On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:
>>
>> > On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]> wrote:
>> > On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>> >
>> > > Hello,
>> > > Recently Mr.Francesco Potortì reported a bug in the use of interp1.
>> > > https://savannah.gnu.org/bugs/?36732
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > > This one should give an error:
>> > >
>> > > interp1([1:5 4:9], 1:11, 4)
>> > >
>> > > In fact, it gives out 4. The first argument is not checked.
>> > >
>> > > Also, the documentation should say "strictly monotonic" where it
>> > > currently says "monotonic".
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > >
>> > > I contacted Mr. Potorti and as far as we know this bug hasn't been
>> > > fixed. So I would like to offer myself to fix the same. Please let me know
>> > > how should i go about it.
>> > >
>> > > With regards,
>> > > Vivek Dogra
>> >
>> > The status of the work on bugs should be recorded on the bug tracker.
>> > It does not appear that any work has been done on this bug yet, so you are
>> > free to work on it.  Please enter a comment on the tracker to let others
>> > know you've begun working on it.  That will help avoid duplicate efforts.
>> >
>> > Thanks,
>> > Ben
>> >
>> > Should i just comment where the bug is reported (which i have already
>> > done). Or there is a procedure to assign the bug to me i.e. to update the
>> > status of the bug, so as to avoid duplicate efforts?
>> >
>> > Regards,
>> > Vivek
>>
>> The comment is enough.
>>
>> Ben
>
>
>
> _______________________________________________
> Help-octave mailing list
> [hidden email]
> https://mailman.cae.wisc.edu/listinfo/help-octave
>

Vivek,

Please answer at the bottom of each message.

Look at this bug
http://savannah.gnu.org/bugs/?func=detailitem&item_id=33857#attached

You can see that people write a short message of the fix and then
attach their patch to their message. Do the same. The patch should be
created according to the instructions on the wiki.



--
M. Sc. Juan Pablo Carbajal
-----
PhD Student
University of Zürich
http://ailab.ifi.uzh.ch/carbajal/


Hello, it is in continuation with the bug in interp1. I am a newbie and have a basic question to ask. To fix the above bug, should i change the .m file or there is any source file behind it where i should make changes? As of now i have just made the copy of the interp1.m file on my machine and fixed the bug in that which is working fine.

please let me know how should i go about it.

Regards,
Vivek.




_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

bpabbott
Administrator
In reply to this post by vivek91m
On Aug 8, 2012, at 1:36 AM, vivek dogra <[hidden email]> wrote:


On Thu, Jul 26, 2012 at 10:51 AM, Juan Pablo Carbajal <[hidden email]> wrote:
On Thu, Jul 26, 2012 at 6:25 AM, vivek dogra <[hidden email]> wrote:
> Okay, i have made changes to the interp1 function to check for strictly
> monotonicity (which it was not doing earlier, although it is written in the
> documentation). So i have a patch for the bug#36732: interp1 does not check
> input for monotonicity.
>
> I would like to ask how can i submit the patch. I went through the link
> provided above
> http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet
> but i am not able to understand it properly.
> I would appreciate proper guidance. Thank you.
>
> Regards,
> Vivek.
>
>
> On Wed, Jul 25, 2012 at 2:29 PM, Ben Abbott <[hidden email]> wrote:
>>
>> On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:
>>
>> > On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]> wrote:
>> > On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>> >
>> > > Hello,
>> > > Recently Mr.Francesco Potortì reported a bug in the use of interp1.
>> > > https://savannah.gnu.org/bugs/?36732
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > > This one should give an error:
>> > >
>> > > interp1([1:5 4:9], 1:11, 4)
>> > >
>> > > In fact, it gives out 4. The first argument is not checked.
>> > >
>> > > Also, the documentation should say "strictly monotonic" where it
>> > > currently says "monotonic".
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > >
>> > > I contacted Mr. Potorti and as far as we know this bug hasn't been
>> > > fixed. So I would like to offer myself to fix the same. Please let me know
>> > > how should i go about it.
>> > >
>> > > With regards,
>> > > Vivek Dogra
>> >
>> > The status of the work on bugs should be recorded on the bug tracker.
>> > It does not appear that any work has been done on this bug yet, so you are
>> > free to work on it.  Please enter a comment on the tracker to let others
>> > know you've begun working on it.  That will help avoid duplicate efforts.
>> >
>> > Thanks,
>> > Ben
>> >
>> > Should i just comment where the bug is reported (which i have already
>> > done). Or there is a procedure to assign the bug to me i.e. to update the
>> > status of the bug, so as to avoid duplicate efforts?
>> >
>> > Regards,
>> > Vivek
>>
>> The comment is enough.
>>
>> Ben
>
>
>
> _______________________________________________
> Help-octave mailing list
> [hidden email]
> https://mailman.cae.wisc.edu/listinfo/help-octave
>

Vivek,

Please answer at the bottom of each message.

Look at this bug
http://savannah.gnu.org/bugs/?func=detailitem&item_id=33857#attached

You can see that people write a short message of the fix and then
attach their patch to their message. Do the same. The patch should be
created according to the instructions on the wiki.



--
M. Sc. Juan Pablo Carbajal
-----
PhD Student
University of Zürich
http://ailab.ifi.uzh.ch/carbajal/


Hello, it is in continuation with the bug in interp1. I am a newbie and have a basic question to ask. To fix the above bug, should i change the .m file or there is any source file behind it where i should make changes? As of now i have just made the copy of the interp1.m file on my machine and fixed the bug in that which is working fine.

please let me know how should i go about it.

Regards,
Vivek.

Fixing the m-file is correct.

Ben

_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

vivek91m


On Wed, Aug 8, 2012 at 4:57 PM, Ben Abbott <[hidden email]> wrote:
On Aug 8, 2012, at 1:36 AM, vivek dogra <[hidden email]> wrote:


On Thu, Jul 26, 2012 at 10:51 AM, Juan Pablo Carbajal <[hidden email]> wrote:
On Thu, Jul 26, 2012 at 6:25 AM, vivek dogra <[hidden email]> wrote:
> Okay, i have made changes to the interp1 function to check for strictly
> monotonicity (which it was not doing earlier, although it is written in the
> documentation). So i have a patch for the bug#36732: interp1 does not check
> input for monotonicity.
>
> I would like to ask how can i submit the patch. I went through the link
> provided above
> http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet
> but i am not able to understand it properly.
> I would appreciate proper guidance. Thank you.
>
> Regards,
> Vivek.
>
>
> On Wed, Jul 25, 2012 at 2:29 PM, Ben Abbott <[hidden email]> wrote:
>>
>> On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:
>>
>> > On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]> wrote:
>> > On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>> >
>> > > Hello,
>> > > Recently Mr.Francesco Potortì reported a bug in the use of interp1.
>> > > https://savannah.gnu.org/bugs/?36732
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > > This one should give an error:
>> > >
>> > > interp1([1:5 4:9], 1:11, 4)
>> > >
>> > > In fact, it gives out 4. The first argument is not checked.
>> > >
>> > > Also, the documentation should say "strictly monotonic" where it
>> > > currently says "monotonic".
>> > >
>> > >
>> > > --------------------------------------------------------------------------------------------------------------------------------
>> > >
>> > > I contacted Mr. Potorti and as far as we know this bug hasn't been
>> > > fixed. So I would like to offer myself to fix the same. Please let me know
>> > > how should i go about it.
>> > >
>> > > With regards,
>> > > Vivek Dogra
>> >
>> > The status of the work on bugs should be recorded on the bug tracker.
>> > It does not appear that any work has been done on this bug yet, so you are
>> > free to work on it.  Please enter a comment on the tracker to let others
>> > know you've begun working on it.  That will help avoid duplicate efforts.
>> >
>> > Thanks,
>> > Ben
>> >
>> > Should i just comment where the bug is reported (which i have already
>> > done). Or there is a procedure to assign the bug to me i.e. to update the
>> > status of the bug, so as to avoid duplicate efforts?
>> >
>> > Regards,
>> > Vivek
>>
>> The comment is enough.
>>
>> Ben
>
>
>
> _______________________________________________
> Help-octave mailing list
> [hidden email]
> https://mailman.cae.wisc.edu/listinfo/help-octave
>

Vivek,

Please answer at the bottom of each message.

Look at this bug
http://savannah.gnu.org/bugs/?func=detailitem&item_id=33857#attached

You can see that people write a short message of the fix and then
attach their patch to their message. Do the same. The patch should be
created according to the instructions on the wiki.



--
M. Sc. Juan Pablo Carbajal
-----
PhD Student
University of Zürich
http://ailab.ifi.uzh.ch/carbajal/


Hello, it is in continuation with the bug in interp1. I am a newbie and have a basic question to ask. To fix the above bug, should i change the .m file or there is any source file behind it where i should make changes? As of now i have just made the copy of the interp1.m file on my machine and fixed the bug in that which is working fine.

please let me know how should i go about it.

Regards,
Vivek.

Fixing the m-file is correct.

Ben
Thank you, so i should just upload the corrected m-file on the bugs page?

With regards,
Vivek.

_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave
Reply | Threaded
Open this post in threaded view
|

Re: Requesting to assign the task to fix "bug #36732: interp1 does not check input for monotonicity"

Carnë Draug-2
On 10 August 2012 10:38, vivek dogra <[hidden email]> wrote:

> On Wed, Aug 8, 2012 at 4:57 PM, Ben Abbott <[hidden email]> wrote:
>> On Aug 8, 2012, at 1:36 AM, vivek dogra <[hidden email]>
>> wrote:
>> On Thu, Jul 26, 2012 at 10:51 AM, Juan Pablo Carbajal
>> <[hidden email]> wrote:
>>> On Thu, Jul 26, 2012 at 6:25 AM, vivek dogra <[hidden email]>
>>> wrote:
>>> > Okay, i have made changes to the interp1 function to check for strictly
>>> > monotonicity (which it was not doing earlier, although it is written in
>>> > the
>>> > documentation). So i have a patch for the bug#36732: interp1 does not
>>> > check
>>> > input for monotonicity.
>>> >
>>> > I would like to ask how can i submit the patch. I went through the link
>>> > provided above
>>> > http://octave.org/wiki/index.php?title=Mercurial_(hg)_cheat_sheet
>>> > but i am not able to understand it properly.
>>> > I would appreciate proper guidance. Thank you.
>>> >
>>> > On Wed, Jul 25, 2012 at 2:29 PM, Ben Abbott <[hidden email]> wrote:
>>> >> On Jul 25, 2012, at 2:59 AM, vivek dogra wrote:
>>> >>
>>> >> > On Tue, Jul 24, 2012 at 6:12 PM, Ben Abbott <[hidden email]>
>>> >> > wrote:
>>> >> > On Jul 24, 2012, at 4:27 AM, vivek dogra wrote:
>>> >> >
>>> >> > > Hello,
>>> >> > > Recently Mr.Francesco Potortì reported a bug in the use of
>>> >> > > interp1.
>>> >> > > https://savannah.gnu.org/bugs/?36732
>>> >> > >
>>> >> > >
>>> >> > >
>>> >> > > --------------------------------------------------------------------------------------------------------------------------------
>>> >> > > This one should give an error:
>>> >> > >
>>> >> > > interp1([1:5 4:9], 1:11, 4)
>>> >> > >
>>> >> > > In fact, it gives out 4. The first argument is not checked.
>>> >> > >
>>> >> > > Also, the documentation should say "strictly monotonic" where it
>>> >> > > currently says "monotonic".
>>> >> > >
>>> >> > >
>>> >> > >
>>> >> > > --------------------------------------------------------------------------------------------------------------------------------
>>> >> > >
>>> >> > > I contacted Mr. Potorti and as far as we know this bug hasn't been
>>> >> > > fixed. So I would like to offer myself to fix the same. Please let
>>> >> > > me know
>>> >> > > how should i go about it.
>>> >> > >
>>> >> > > With regards,
>>> >> > > Vivek Dogra
>>> >> >
>>> >> > The status of the work on bugs should be recorded on the bug
>>> >> > tracker.
>>> >> > It does not appear that any work has been done on this bug yet, so
>>> >> > you are
>>> >> > free to work on it.  Please enter a comment on the tracker to let
>>> >> > others
>>> >> > know you've begun working on it.  That will help avoid duplicate
>>> >> > efforts.
>>> >> >
>>> >> >
>>> >> > Should i just comment where the bug is reported (which i have
>>> >> > already
>>> >> > done). Or there is a procedure to assign the bug to me i.e. to
>>> >> > update the
>>> >> > status of the bug, so as to avoid duplicate efforts?
>>> >> >
>>> >> The comment is enough.
>>> >>
>>>
>>> Please answer at the bottom of each message.
>>>
>>> Look at this bug
>>> http://savannah.gnu.org/bugs/?func=detailitem&item_id=33857#attached
>>>
>>> You can see that people write a short message of the fix and then
>>> attach their patch to their message. Do the same. The patch should be
>>> created according to the instructions on the wiki.
>>>
>>
>>
>> Hello, it is in continuation with the bug in interp1. I am a newbie and
>> have a basic question to ask. To fix the above bug, should i change the .m
>> file or there is any source file behind it where i should make changes? As
>> of now i have just made the copy of the interp1.m file on my machine and
>> fixed the bug in that which is working fine.
>>
>> please let me know how should i go about it.
>>
>>
>>
>> Fixing the m-file is correct.
>
> Thank you, so i should just upload the corrected m-file on the bugs page?
>

No. Upload a changeset to the bug report. See the manual (
http://www.gnu.org/software/octave/doc/interpreter/Basics-of-Generating-a-Changeset.html#Basics-of-Generating-a-Changeset
) for how to prepare a changeset. Ignore the part about submitting it
to the mailing list. The next version of the manual won't say that ;)

If you can't generate a changeset that's ok, upload the .m file but a
changeset is preferred as it makes things easier.

Carnë
_______________________________________________
Help-octave mailing list
[hidden email]
https://mailman.cae.wisc.edu/listinfo/help-octave