[SIGNAL] findpeaks

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[SIGNAL] findpeaks

JuanPi
Hi,

I added this ticket
https://sourceforge.net/p/octave/feature-requests/39/

It is a first version of findpeaks. It was programmed from scratch so
any similarity to already existing functions is mere coincidence.

The function depends on the general package > 1.3.2

If there are no comments in a week I will add it to the signal package.

Thanks for reviewing!

--
JuanPi Carbajal
-----
"It is one thing not to be able to perform a certain feat, but quite
another to prove that it cannot be done." - Henry Ernest Dudeney
-----
http://ailab.ifi.uzh.ch/carbajal/

------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Octave-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/octave-dev
Reply | Threaded
Open this post in threaded view
|

Re: [SIGNAL] findpeaks

JuanPi
On Wed, Oct 3, 2012 at 2:06 PM, Johan Silen <[hidden email]> wrote:

> Thanks for a good routine. I tested most of the cases on
> my own data and the routines seem to work. I have sometimes
> used a much simpler routine to do the same kind of things which
> is not though as versatile as yours (which I attach as an example).
> When working with this kind of a routine, the context often dictates
> what you need as output. I do not know what matlab compatibility
> demands.
>
> Quite often one would need to have the fitted parabolas or other model
> functions available and therefore it would be nice to get this data
> returned from the routine. This could possibly be made through a cell
> array of the peak defining entity which would contain position, maximum,
> width, model fit errors etc. This is an issue of practicality and
> compatibility and does not necessary belong here.
>
> If possible, add the column wise operations. It complicates the output
>   but might be doable in several ways. I have sometimes used a boolean
>   matrix for this purpose and sometimes cell arrays. This is also a
> complicated issue, but think about it.
>
> Finally the testing routine not using subplot() would be nicer with two
> independent plots as zooming is then possible and the details of the fit
> are easier to look into. The subplot() routines should in principle be
> rewritten but that is a different issue. If you still use subplot then
> please issue a subplot(1,1,1) at the end of the routine to reset
> plotting.
>
>
>              Regards Johan Silen
>
>
>
>
>
>
>
> On Tue, 2012-10-02 at 16:26 +0300, JuanPi wrote:
>> Hi,
>>
>> I added this ticket
>> https://sourceforge.net/p/octave/feature-requests/39/
>>
>> It is a first version of findpeaks. It was programmed from scratch so
>> any similarity to already existing functions is mere coincidence.
>>
>> The function depends on the general package > 1.3.2
>>
>> If there are no comments in a week I will add it to the signal package.
>>
>> Thanks for reviewing!
>>
>
> --
> -----------------------------------------------------------------------
> Dr. Johan Silén
> Finnish Meteorological Institute
> Erik Palmenin aukio 1
> 00560 Helsinki, Finland
> Phone:+358505423872, ex. +358295391000
> Email:[hidden email].

Hi Johan,

Thank you for your very useful comments. I will work to implement what
you suggested.

--
JuanPi Carbajal
-----
"It is one thing not to be able to perform a certain feat, but quite
another to prove that it cannot be done." - Henry Ernest Dudeney
-----
http://ailab.ifi.uzh.ch/carbajal/

------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Octave-dev mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/octave-dev