Saving an editor file while closing the related tab is broken

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Saving an editor file while closing the related tab is broken

Torsten Lilge
Hi John,

after changeset http://hg.savannah.gnu.org/hgweb/octave/rev/27967cb3dea5
, saving a modified file while closing the related tab does not work
anymore. It seems, that now, where the sequential flow is partly
paralleled, the tab is removed before the thread crossing signal/slot
mechanism is completed (in this case: "do_save_file_signal" from
intergreter thread). Directly calling "do_save_file" from the
interpreter instead of emitting the related signal fixes the bug, but it
this safe?

Torsten



Reply | Threaded
Open this post in threaded view
|

Re: Saving an editor file while closing the related tab is broken

Torsten Lilge
On Sun, 2019-10-20 at 15:35 +0200, Torsten Lilge wrote:

> Hi John,
>
> after changeset
> http://hg.savannah.gnu.org/hgweb/octave/rev/27967cb3dea5
> , saving a modified file while closing the related tab does not work
> anymore. It seems, that now, where the sequential flow is partly
> paralleled, the tab is removed before the thread crossing signal/slot
> mechanism is completed (in this case: "do_save_file_signal" from
> intergreter thread). Directly calling "do_save_file" from the
> interpreter instead of emitting the related signal fixes the bug, but
> it
> this safe?
>
> Torsten
>

Restructuring the closing procedure of editor and/or editor tabs in
changeset http://hg.savannah.gnu.org/hgweb/octave/rev/60cecb3fed04
should fix this issue

Torsten