[forge] octclip & octproj build loop

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[forge] octclip & octproj build loop

José Luis García Pallero
Hi, Marco:

I've installed both packages (from sourceforge) in Octave 4.0 on a
debian box with gcc-4.9 and make 4.0 and 4.1 (make 4.0 is the one in
Debian, and make 4.1 was installed by me in order to match your
version) and all works fine. I haven't any problem in the compilation
process

Best regards


--
*****************************************
José Luis García Pallero
[hidden email]
(o<
/ / \
V_/_
Use Debian GNU/Linux and enjoy!
*****************************************

Reply | Threaded
Open this post in threaded view
|

Re: [forge] octclip & octproj build loop

marco atzeri-2
On 6/16/2015 12:38 PM, José Luis García Pallero wrote:

> Hi, Marco:
>
> I've installed both packages (from sourceforge) in Octave 4.0 on a
> debian box with gcc-4.9 and make 4.0 and 4.1 (make 4.0 is the one in
> Debian, and make 4.1 was installed by me in order to match your
> version) and all works fine. I haven't any problem in the compilation
> process
>
> Best regards
>
Hi Jose,
Thanks for the test.

I discovered that running "make" works fine, and removing
the "clean" step in "all" does not solve the issue.

The problem is in the redefinition of CC=mkoctfile
when calling from inside octave "pkg build .."

Using MKOCTFILE=mkoctfile, as for the attached patch, solve my
build issue.

Regards
Marco

octclip.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [forge] octclip & octproj build loop

José Luis García Pallero
2015-06-16 12:48 GMT+02:00 Marco Atzeri <[hidden email]>:

> On 6/16/2015 12:38 PM, José Luis García Pallero wrote:
>>
>> Hi, Marco:
>>
>> I've installed both packages (from sourceforge) in Octave 4.0 on a
>> debian box with gcc-4.9 and make 4.0 and 4.1 (make 4.0 is the one in
>> Debian, and make 4.1 was installed by me in order to match your
>> version) and all works fine. I haven't any problem in the compilation
>> process
>>
>> Best regards
>>
>
> Hi Jose,
> Thanks for the test.
>
> I discovered that running "make" works fine, and removing
> the "clean" step in "all" does not solve the issue.
>
> The problem is in the redefinition of CC=mkoctfile
> when calling from inside octave "pkg build .."
>
> Using MKOCTFILE=mkoctfile, as for the attached patch, solve my
> build issue.

Hello:

I don't understand. In my installation all works without problems
using also pkg build instead of pkg install

>
> Regards
> Marco



--
*****************************************
José Luis García Pallero
[hidden email]
(o<
/ / \
V_/_
Use Debian GNU/Linux and enjoy!
*****************************************

Reply | Threaded
Open this post in threaded view
|

Re: [forge] octclip & octproj build loop

marco atzeri-2
On 6/16/2015 1:07 PM, José Luis García Pallero wrote:

> 2015-06-16 12:48 GMT+02:00 Marco Atzeri <[hidden email]>:
>> On 6/16/2015 12:38 PM, José Luis García Pallero wrote:
>>>
>>> Hi, Marco:
>>>
>>> I've installed both packages (from sourceforge) in Octave 4.0 on a
>>> debian box with gcc-4.9 and make 4.0 and 4.1 (make 4.0 is the one in
>>> Debian, and make 4.1 was installed by me in order to match your
>>> version) and all works fine. I haven't any problem in the compilation
>>> process
>>>
>>> Best regards
>>>
>>
>> Hi Jose,
>> Thanks for the test.
>>
>> I discovered that running "make" works fine, and removing
>> the "clean" step in "all" does not solve the issue.
>>
>> The problem is in the redefinition of CC=mkoctfile
>> when calling from inside octave "pkg build .."
>>
>> Using MKOCTFILE=mkoctfile, as for the attached patch, solve my
>> build issue.
>
> Hello:
>
> I don't understand. In my installation all works without problems
> using also pkg build instead of pkg install
>
CC is one of the variable used by mkoctfile

$  /usr/bin/mkoctfile-4.0.0.exe -p CC
gcc

At least on cygwin package build system
using CC=mkoctfile causes a circular
dependency loop that spins a never ending
fork chain of mkoctfile's

Attached similar patch for octproj.


Regards
Marco




octproj.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [forge] octclip & octproj build loop

José Luis García Pallero
2015-06-16 14:07 GMT+02:00 Marco Atzeri <[hidden email]>:

> On 6/16/2015 1:07 PM, José Luis García Pallero wrote:
>>
>> 2015-06-16 12:48 GMT+02:00 Marco Atzeri <[hidden email]>:
>>>
>>> On 6/16/2015 12:38 PM, José Luis García Pallero wrote:
>>>>
>>>>
>>>> Hi, Marco:
>>>>
>>>> I've installed both packages (from sourceforge) in Octave 4.0 on a
>>>> debian box with gcc-4.9 and make 4.0 and 4.1 (make 4.0 is the one in
>>>> Debian, and make 4.1 was installed by me in order to match your
>>>> version) and all works fine. I haven't any problem in the compilation
>>>> process
>>>>
>>>> Best regards
>>>>
>>>
>>> Hi Jose,
>>> Thanks for the test.
>>>
>>> I discovered that running "make" works fine, and removing
>>> the "clean" step in "all" does not solve the issue.
>>>
>>> The problem is in the redefinition of CC=mkoctfile
>>> when calling from inside octave "pkg build .."
>>>
>>> Using MKOCTFILE=mkoctfile, as for the attached patch, solve my
>>> build issue.
>>
>>
>> Hello:
>>
>> I don't understand. In my installation all works without problems
>> using also pkg build instead of pkg install
>>
>
> CC is one of the variable used by mkoctfile
>
> $  /usr/bin/mkoctfile-4.0.0.exe -p CC
> gcc
>
> At least on cygwin package build system
> using CC=mkoctfile causes a circular
> dependency loop that spins a never ending
> fork chain of mkoctfile's
>
> Attached similar patch for octproj.

I understand and I'll do the changes. But which is the problem with
the 'clean' target? I think I could maintain it

>
>
> Regards
> Marco
>
>
>



--
*****************************************
José Luis García Pallero
[hidden email]
(o<
/ / \
V_/_
Use Debian GNU/Linux and enjoy!
*****************************************

Reply | Threaded
Open this post in threaded view
|

Re: [forge] octclip & octproj build loop

marco atzeri-2
On 6/16/2015 2:12 PM, José Luis García Pallero wrote:
> 2015-06-16 14:07 GMT+02:00 Marco Atzeri <[hidden email]>:
>> On 6/16/2015 1:07 PM, José Luis García Pallero wrote:

>> CC is one of the variable used by mkoctfile
>>
>> $  /usr/bin/mkoctfile-4.0.0.exe -p CC
>> gcc
>>
>> At least on cygwin package build system
>> using CC=mkoctfile causes a circular
>> dependency loop that spins a never ending
>> fork chain of mkoctfile's
>>
>> Attached similar patch for octproj.
>
> I understand and I'll do the changes. But which is the problem with
> the 'clean' target? I think I could maintain it
>

aesthetical preference ?

I feel wrong to have build and remove instructions
coupled. It looks to me a risk of undefined behaviour

Regards
Marco




Reply | Threaded
Open this post in threaded view
|

Re: [forge] octclip & octproj build loop

José Luis García Pallero
2015-06-16 15:53 GMT+02:00 Marco Atzeri <[hidden email]>:

> On 6/16/2015 2:12 PM, José Luis García Pallero wrote:
>>
>> 2015-06-16 14:07 GMT+02:00 Marco Atzeri <[hidden email]>:
>>>
>>> On 6/16/2015 1:07 PM, José Luis García Pallero wrote:
>
>
>>> CC is one of the variable used by mkoctfile
>>>
>>> $  /usr/bin/mkoctfile-4.0.0.exe -p CC
>>> gcc
>>>
>>> At least on cygwin package build system
>>> using CC=mkoctfile causes a circular
>>> dependency loop that spins a never ending
>>> fork chain of mkoctfile's
>>>
>>> Attached similar patch for octproj.
>>
>>
>> I understand and I'll do the changes. But which is the problem with
>> the 'clean' target? I think I could maintain it
>>
>
> aesthetical preference ?
>
> I feel wrong to have build and remove instructions
> coupled. It looks to me a risk of undefined behaviour

I've deleted the 'clean' order from the 'all' target. I've uploaded
OctCLIP and OctPROJ to the sourceforge tracker, so they will be soon
on octave-forge

Thanks

>
> Regards
> Marco
>
>
>



--
*****************************************
José Luis García Pallero
[hidden email]
(o<
/ / \
V_/_
Use Debian GNU/Linux and enjoy!
*****************************************