[patch #9808] [octave forge](statistics) unifrnd function

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch #9808] [octave forge](statistics) unifrnd function

Mike Miller-5
URL:
  <https://savannah.gnu.org/patch/?9808>

                 Summary: [octave forge](statistics) unifrnd function
                 Project: GNU Octave
            Submitted by: amorast
            Submitted on: Tue 21 May 2019 10:59:07 PM UTC
                Category: Forge : new function
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email:
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Adds the missing unifrnd function which used to be in the core Octave project.


This patch also corrects some behavior differences with ML as described in
this bug report:

https://savannah.gnu.org/bugs/?56342





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 21 May 2019 10:59:07 PM UTC  Name: unifrnd.patch  Size: 5KiB   By:
amorast

<http://savannah.gnu.org/patch/download.php?file_id=46950>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9808>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/


Reply | Threaded
Open this post in threaded view
|

[patch #9808] [octave forge](statistics) unifrnd function

Mike Miller-5
Update of patch #9808 (project octave):

                  Status:                    None => Wont Do                
             Open/Closed:                    Open => Closed                

    _______________________________________________________

Follow-up Comment #1:

The 'unifrnd' function is already part of the statistics package since version
1.4.0 (http://hg.code.sf.net/p/octave/statistics/rev/55c33ee91354). Not
needed.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9808>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/


Reply | Threaded
Open this post in threaded view
|

[patch #9808] [octave forge](statistics) unifrnd function

Mike Miller-5
Follow-up Comment #2, patch #9808 (project octave):

If you need to fix bug #56342, please submit a patch against the existing
function file on the existing bug report, no need to file a separate patch
tracker item.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9808>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/


Reply | Threaded
Open this post in threaded view
|

[patch #9808] [octave forge](statistics) unifrnd function

Mike Miller-5
Follow-up Comment #3, patch #9808 (project octave):

My mistake, I'm a new contributor and was under the assumption that the
functionality was all under the inst/ directories for forge packages.

I should have been more thorough.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9808>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/


Reply | Threaded
Open this post in threaded view
|

[patch #9808] [octave forge](statistics) unifrnd function

Mike Miller-5
Follow-up Comment #4, patch #9808 (project octave):

Hi Anthony, no worries, your assumption is generally correct, but the
statistics package is definitely an outlier. This is because the package wants
to work on both old and new versions of Octave, without overriding functions
like 'normcdf' that used to be included in Octave's core runtime.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9808>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/


Reply | Threaded
Open this post in threaded view
|

[patch #9808] [octave forge](statistics) unifrnd function

Mike Miller-5
Follow-up Comment #5, patch #9808 (project octave):

Thank you for the info, Mike.

I've created a patch against the existing function and attached it to the bug
report, as per your suggestion.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/patch/?9808>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/