predicate name changes

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

predicate name changes

John W. Eaton-6
I've changed the names of the following predicates in CVS Octave:

  is_bool     is_list    is_square  is_symmetric
  is_complex  is_matrix  is_stream  is_vector
  is_global   is_scalar  is_struct

They no longer have the underscore, so is_bool is now isbool,
is_complex is iscomplex, etc.

There is a new directory of M-files (in the sources it is
scripts/deprecated) so the old names still work, but if you ask for
help for any of the old function names, you will be told that the
function is deprecated and to use the new name.

Now I need someone to search through the Octave sources and convert
all the uses of the old names to the new, and submit patches for these
changes.

Can someone please do this?

Thanks,

jwe


Reply | Threaded
Open this post in threaded view
|

Re: predicate name changes

Paul Kienzle-2
On Fri, Aug 09, 2002 at 02:35:33AM -0500, John W. Eaton wrote:

> I've changed the names of the following predicates in CVS Octave:
>
>   is_bool     is_list    is_square  is_symmetric
>   is_complex  is_matrix  is_stream  is_vector
>   is_global   is_scalar  is_struct
>
> They no longer have the underscore, so is_bool is now isbool,
> is_complex is iscomplex, etc.
>
> There is a new directory of M-files (in the sources it is
> scripts/deprecated) so the old names still work, but if you ask for
> help for any of the old function names, you will be told that the
> function is deprecated and to use the new name.
>
> Now I need someone to search through the Octave sources and convert
> all the uses of the old names to the new, and submit patches for these
> changes.
>
> Can someone please do this?

[pkienzle@d121245 scripts]$ grep -ld skip is_ */* */*/* | wc
    262     262    6395

I'll do signal/ and strings/ this morning.  How do you want the patches?
One per file?  One per directory?  One per toolbox?  One for everything?

Paul Kienzle
[hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: predicate name changes

Etienne Grossmann-4
On Fri, Aug 09, 2002 at 09:15:42AM -0400, Paul Kienzle wrote:
# On Fri, Aug 09, 2002 at 02:35:33AM -0500, John W. Eaton wrote:
# > I've changed the names of the following predicates in CVS Octave:
# >
# >   is_bool     is_list    is_square  is_symmetric
# >   is_complex  is_matrix  is_stream  is_vector
# >   is_global   is_scalar  is_struct
# >
# > They no longer have the underscore, so is_bool is now isbool,
# > is_complex is iscomplex, etc.
# >
# > There is a new directory of M-files (in the sources it is
# > scripts/deprecated) so the old names still work, but if you ask for
# > help for any of the old function names, you will be told that the
# > function is deprecated and to use the new name.
# >
# > Now I need someone to search through the Octave sources and convert
# > all the uses of the old names to the new, and submit patches for these
# > changes.
# >
# > Can someone please do this?
#
# [pkienzle@d121245 scripts]$ grep -ld skip is_ */* */*/* | wc
#     262     262    6395
#
# I'll do signal/ and strings/ this morning.  How do you want the patches?
# One per file?  One per directory?  One per toolbox?  One for everything?
#

  Would you like help with the rest? There's nothing a little perl
can't do :-). Paul did you write a script already?

  Cheers,

  Etienne

--
Etienne Grossmann ------ http://www.isr.ist.utl.pt/~etienne


Reply | Threaded
Open this post in threaded view
|

Re: predicate name changes

John W. Eaton-6
In reply to this post by Paul Kienzle-2
On  9-Aug-2002, Paul Kienzle <[hidden email]> wrote:

| On Fri, Aug 09, 2002 at 02:35:33AM -0500, John W. Eaton wrote:
| >
| > Now I need someone to search through the Octave sources and convert
| > all the uses of the old names to the new, and submit patches for these
| > changes.
| >
| > Can someone please do this?
|
| [pkienzle@d121245 scripts]$ grep -ld skip is_ */* */*/* | wc
|     262     262    6395
|
| I'll do signal/ and strings/ this morning.  How do you want the patches?
| One per file?  One per directory?  One per toolbox?  One for everything?

One per directory would be OK, or one for each batch you do, even if
it is more than one directory.

Note that I didn't change any in the control subdirectory yet.

Thanks,

jwe


Reply | Threaded
Open this post in threaded view
|

Re: predicate name changes

Etienne Grossmann-4
In reply to this post by John W. Eaton-6

  I found and replaced 533 occurences of these functions in octave
CVS. Would you like me to send you a huge patch? I will first do a
build process and try 'make check'. Any other goals for checking?

  Cheers

  Etienne

PS : I used two script for the substitution. The first finds
     occurences and printing them out. I then looked for spurious
     occurences of the function names (I found none). The second
     script reads the (perhaps amended, but that was not needed) list
     of occurences and does the changes in it.

On Fri, Aug 09, 2002 at 02:35:33AM -0500, John W. Eaton wrote:
# I've changed the names of the following predicates in CVS Octave:
#
#   is_bool     is_list    is_square  is_symmetric
#   is_complex  is_matrix  is_stream  is_vector
#   is_global   is_scalar  is_struct
#
# They no longer have the underscore, so is_bool is now isbool,
# is_complex is iscomplex, etc.
#
# There is a new directory of M-files (in the sources it is
# scripts/deprecated) so the old names still work, but if you ask for
# help for any of the old function names, you will be told that the
# function is deprecated and to use the new name.
#
# Now I need someone to search through the Octave sources and convert
# all the uses of the old names to the new, and submit patches for these
# changes.
#
# Can someone please do this?
#
# Thanks,
#
# jwe
#
#
#

--
Etienne Grossmann ------ http://www.isr.ist.utl.pt/~etienne


Reply | Threaded
Open this post in threaded view
|

Re: predicate name changes

John W. Eaton-6
On  9-Aug-2002, Etienne Grossmann <[hidden email]> wrote:

|
|   I found and replaced 533 occurences of these functions in octave
| CVS. Would you like me to send you a huge patch? I will first do a
| build process and try 'make check'. Any other goals for checking?

Sure, send a diff -u patch.  You are only changing in scripts, or all
subdirectories?

Thanks,

jwe


Reply | Threaded
Open this post in threaded view
|

Re: predicate name changes

Paul Kienzle-2
In reply to this post by Etienne Grossmann-4
On Fri, Aug 09, 2002 at 04:46:25PM +0100, Etienne Grossmann wrote:
>
>   I found and replaced 533 occurences of these functions in octave
> CVS. Would you like me to send you a huge patch? I will first do a
> build process and try 'make check'. Any other goals for checking?

You did just the is_xxx listed below correct?  Because there are a
number of is_xxx in control which have not been changed (yet).

Keep the script around.  We are going to need it for octave-forge
soon.  I'm not sure when to do this.  I don't want to force all
octave-forge users to bleeding edge, but keeping things working
across versions is going to be painful.  I guess we will need a set
of isxxx in FIXES/oldversionsofoctave/* which call is_xxx.

- Paul

>
>   Cheers
>
>   Etienne
>
> PS : I used two script for the substitution. The first finds
>      occurences and printing them out. I then looked for spurious
>      occurences of the function names (I found none). The second
>      script reads the (perhaps amended, but that was not needed) list
>      of occurences and does the changes in it.
>
> On Fri, Aug 09, 2002 at 02:35:33AM -0500, John W. Eaton wrote:
> # I've changed the names of the following predicates in CVS Octave:
> #
> #   is_bool     is_list    is_square  is_symmetric
> #   is_complex  is_matrix  is_stream  is_vector
> #   is_global   is_scalar  is_struct
> #
> # They no longer have the underscore, so is_bool is now isbool,
> # is_complex is iscomplex, etc.
> #
> # There is a new directory of M-files (in the sources it is
> # scripts/deprecated) so the old names still work, but if you ask for
> # help for any of the old function names, you will be told that the
> # function is deprecated and to use the new name.
> #
> # Now I need someone to search through the Octave sources and convert
> # all the uses of the old names to the new, and submit patches for these
> # changes.
> #
> # Can someone please do this?
> #
> # Thanks,
> #
> # jwe
> #
> #
> #
>
> --
> Etienne Grossmann ------ http://www.isr.ist.utl.pt/~etienne
>


Reply | Threaded
Open this post in threaded view
|

Re: predicate name changes

Etienne Grossmann-4
In reply to this post by John W. Eaton-6

  Hello,

On Fri, Aug 09, 2002 at 10:47:36AM -0500, John W. Eaton wrote:
# On  9-Aug-2002, Etienne Grossmann <[hidden email]> wrote:
#
# |
# |   I found and replaced 533 occurences of these functions in octave
# | CVS. Would you like me to send you a huge patch? I will first do a
# | build process and try 'make check'. Any other goals for checking?
#
# Sure, send a diff -u patch.  You are only changing in scripts, or all
# subdirectories?

  In all .m files in the cvs tree. I will do a build (may take some
time : I never built cvs before, and I have a slow machine) before
sending the patch.

  Cheers,

  Etienne
 
# Thanks,
#
# jwe
#

--
Etienne Grossmann ------ http://www.isr.ist.utl.pt/~etienne